New issue
Advanced search Search tips

Issue 852679 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 852882

Blocking:
issue 439949
issue 786127
issue 849812



Sign in to add a comment

Roll Clang again

Project Member Reported by h...@chromium.org, Jun 14 2018

Issue description

Tracking bug for the next Clang roll.

Previous roll:   https://crbug.com/845798 
 

Comment 1 by h...@chromium.org, Jun 14 2018

Blocking: 786127

Comment 2 by tikuta@chromium.org, Jun 14 2018

Blocking: 439949
Cc: tikuta@chromium.org

Comment 3 by r...@chromium.org, Jun 14 2018

Blockedon: 852882

Comment 4 by mmoroz@chromium.org, Jun 15 2018

Blocking: 849812
We need r334858 for issue 849812.

Comment 6 by tikuta@chromium.org, Jun 22 2018

I think https://reviews.llvm.org/D47578 made installed dir relative in clang-cl, but rolled clang loos not behave like that.

PS C:\src\chromium\src> .\third_party\llvm-build\Release+Asserts\bin\clang-cl.exe -v -no-canonical-prefixes -###
clang version 7.0.0 (trunk 335091)
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\src\chromium\src\third_party\llvm-build\Release+Asserts\bin

Why? Chromium clang has something special config when it is built?

Status: Fixed (was: Available)
Marking this fixed now that the roll is in. Next roll:  https://crbug.com/855772 
tikuta, that's odd. That's not what I'm getting. Before the roll:

C:\src\chromium\src>third_party\llvm-build\Release+Asserts\bin\clang-cl.exe -v -no-canonical-prefixes -###
clang version 7.0.0 (trunk 334100)
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\src\chromium\src\third_party\llvm-build\Release+Asserts\bin

After the roll:

C:\src\chromium\src>third_party\llvm-build\Release+Asserts\bin\clang-cl.exe -v -no-canonical-prefixes -###
clang version 7.0.0 (trunk 335091)
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: third_party\llvm-build\Release+Asserts\bin

But when I run from PowerShell I get the same result as you:

PS C:\src\chromium\src> third_party\llvm-build\Release+Asserts\bin\clang-cl.exe -v -no-canonical-prefixes -###
clang version 7.0.0 (trunk 335091)
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\src\chromium\src\third_party\llvm-build\Release+Asserts\bin
#8, #9
You are right!

PS C:\src\chromium\src> cmd /c third_party\llvm-build\Release+Asserts\bin\clang-cl.exe -v -no-canonical-prefixes -###
clang version 7.0.0 (trunk 335091)
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: third_party\llvm-build\Release+Asserts\bin

Seems strange though.
Anyway thank you for finding!

#11 
I see. thanks.
Roll was https://chromium-review.googlesource.com/c/chromium/src/+/1109394 / #569676 (had no Bug: line, so this bug wasn't updated with the commit)

Sign in to add a comment