Regression : Browser crash is seen after clicking on 'clear' button on 'chrome://settings/content/siteDetails'.
Reported by
pranjali...@etouch.net,
Jun 14 2018
|
|||||
Issue descriptionChrome version : 69.0.3457.2 (Official Build) 9c525f32d5d7caf55004d2318ac334580d63a579-refs/branch-heads/3457@{#5}(32/64-bit) OS : Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.5) and Linux(14.04 LTS) OS Precondition: Enable 'Site settings' flags from 'chrome://flags/'. Steps to reproduce: 1. Launch chrome and navigate to 'https://www.flipkart.com/'. 2. Click on 'secure' chip on omnibox and click on 'site settings'. 3. Now click on 'Clear data' button and again click on 'clear' button on 'clear site data?' overlay. 4. observe. Actual Result: Browser crash is seen after clicking on 'clear' button on 'chrome://settings/content/siteDetails'. Expected Result: Browser should not get crash after clicking on 'clear' button on 'chrome://settings/content/siteDetails'. This is a regression issue broken in ‘M-69’ and will soon update other bisect info. Good build: 69.0.3452.0 Bad build: 69.0.3453.0 You are probably looking for a change made after 565204 (known good), but no later than 565205 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/ f9656207a24252cb5486d98a700dbc72e5430fee..d4c83652a33127a0d4ec9b723e344b854f8f752a Suspect: https://chromium.googlesource.com/chromium/src/+/d4c83652a33127a0d4ec9b723e344b854f8f752a @patricialor: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank you.
,
Jun 14 2018
Thank you so much for finding this! A fix is up at crrev.com/c/1100673.
,
Jun 14 2018
Stack trace for the crash id: ----------------------------- Thread 0 (id: 0x16d4) CRASHED [EXCEPTION_BREAKPOINT @ 0x000007fee7bda773 ] MAGIC SIGNATURE THREAD Stack Quality100%Show frame trust levels 0x000007fee7bda773 (chrome.dll -site_settings_handler.cc:371 ) settings::SiteSettingsHandler::HandleClearUsage(base::ListValue const *) 0x000007fee6abf417 (chrome.dll -web_ui_impl.cc:267 ) content::WebUIImpl::ProcessWebUIMessage(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &) 0x000007fee6abea6b (chrome.dll -web_ui_impl.cc:134 ) content::WebUIImpl::OnWebUISend(content::RenderFrameHost *,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &) 0x000007fee6abe851 (chrome.dll -ipc_message_templates.h:146 ) IPC::MessageT<FrameHostMsg_WebUISend_Meta,std::tuple<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue>,void>::Dispatch<content::WebUIImpl,content::WebUIImpl,content::RenderFrameHost,void (content::WebUIImpl::*)(content::RenderFrameHost *, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > &, const base::ListValue &)> 0x000007fee6abe771 (chrome.dll -web_ui_impl.cc:102 ) content::WebUIImpl::OnMessageReceived(IPC::Message const &,content::RenderFrameHost *) 0x000007fee6219bd1 (chrome.dll -web_contents_impl.cc:847 ) content::WebContentsImpl::OnMessageReceived(content::RenderFrameHostImpl *,IPC::Message const &) 0x000007fee6218b55 (chrome.dll -render_frame_host_impl.cc:948 ) content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const &) 0x000007fee62189a6 (chrome.dll -render_process_host_impl.cc:3050 ) content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const &) 0x000007fee621888c (chrome.dll -ipc_channel_proxy.cc:320 ) IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const &) 0x000007fee5c7ff94 (chrome.dll -task_annotator.cc:101 ) base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *) 0x000007fee5c7fa6b (chrome.dll -message_loop.cc:319 ) base::MessageLoop::RunTask(base::PendingTask *) 0x000007fee5c7f4b7 (chrome.dll -message_loop.cc:373 ) base::MessageLoop::DoWork() 0x000007fee5d6f288 (chrome.dll -message_pump_win.cc:173 ) base::MessagePumpForUI::DoRunLoop() 0x000007fee5cc4907 (chrome.dll -message_pump_win.cc:56 ) base::MessagePumpWin::Run(base::MessagePump::Delegate *) 0x000007fee5c7f010 (chrome.dll -run_loop.cc:102 ) base::RunLoop::Run() 0x000007fee5ffeb63 (chrome.dll -chrome_browser_main.cc:2194 ) ChromeBrowserMainParts::MainMessageLoopRun(int *) 0x000007fee5ffe967 (chrome.dll -browser_main_loop.cc:979 ) content::BrowserMainLoop::RunMainMessageLoopParts() 0x000007fee5ffe912 (chrome.dll -browser_main_runner_impl.cc:169 ) content::BrowserMainRunnerImpl::Run() 0x000007fee67dcbfe (chrome.dll -browser_main.cc:51 ) content::BrowserMain(content::MainFunctionParams const &,std::unique_ptr<content::BrowserProcessSubThread,std::default_delete<content::BrowserProcessSubThread> >) 0x000007fee6d38d2a (chrome.dll -content_main_runner_impl.cc:620 ) content::RunBrowserProcessMain(content::MainFunctionParams const &,content::ContentMainDelegate *,std::unique_ptr<content::BrowserProcessSubThread,std::default_delete<content::BrowserProcessSubThread> >) 0x000007fee5c75765 (chrome.dll -content_main_runner_impl.cc:964 ) content::ContentMainRunnerImpl::Run() 0x000007fee5c65172 (chrome.dll -main.cc:459 ) service_manager::Main(service_manager::MainParams const &) 0x000007fee5c64a07 (chrome.dll -content_main.cc:19 ) content::ContentMain(content::ContentMainParams const &) 0x000007fee5c61af1 (chrome.dll -chrome_main.cc:101 ) ChromeMain 0x000000013f8635d5 (chrome.exe -main_dll_loader_win.cc:201 ) MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks) 0x000000013f861698 (chrome.exe -chrome_exe_main_win.cc:230 ) wWinMain 0x000000013f920b65 (chrome.exe -exe_common.inl:283 ) __scrt_common_main_seh 0x776c59cc (KERNEL32.dll + 0x000159cc ) BaseThreadInitThunk 0x77c7b980 (ntdll.dll + 0x0002b980 ) RtlUserThreadStart Adding release blocker label for this issue.Please reduce priority or remove if not the case. Thank You!
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adbeb52ff0e60ab8107b97e4ad1d3d9cc2941c4d commit adbeb52ff0e60ab8107b97e4ad1d3d9cc2941c4d Author: Patti <patricialor@chromium.org> Date: Mon Jun 18 06:43:57 2018 Settings: Fix crash when trashing storage in Site Details. r565205 introduced a crash when deleting a site's used storage. Fix. Bug: 852676 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8246cc478943dcfa47379ab6e9dfc61c14cae044 Reviewed-on: https://chromium-review.googlesource.com/1100673 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#567939} [modify] https://crrev.com/adbeb52ff0e60ab8107b97e4ad1d3d9cc2941c4d/chrome/browser/resources/settings/site_settings/site_details.html
,
Jun 19 2018
,
Jun 19 2018
Update : Retested above issue in latest Canary build #69.0.3465.0 on Windows(7, 8, 8.1, 10) & Linux (14.04 LTS) OS and the issue is fixed. Browser does not crash after after clicking on 'clear' button on 'chrome://settings/content/siteDetails'. Kindly review an attached screen-cast for the reference. Note: Mac Canary build #69.0.3465.0 failed today hence can not verify this issue on Mac OS and will add TE-Verified labels once the latest Mac build gets available. Thank you....
,
Jun 20 2018
Update: Above issue is verified on Windows(7, 8, 8.1, 10), Linux(14.04 LTS) using Canary #69.0.3465.0 and on Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6) OS with Canary #69.0.3466.0, hence adding TE-Verified-69.0.3465.0 & TE-Verified-69.0.3466.0 labels. Issue is fixed on all (Win, Mac & Linux) platforms and it is working as expected. Thank you..! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pranjali...@etouch.net
, Jun 14 2018