ServiceWorker.ActivateWorkerPreparationForMainFrame.* UMA for NetS13nSW. |
||||
Issue descriptionThese UMA are affected by NetS13nSW: - ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time - ServiceWorker.ActivatedWorkerPreparationForMainFrame.Type Decision: - Deprecate ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time. The intent was to measure SW interception latency from start of navigation to SW started up. But it's flawed because it includes redirects, so we don't use it. We should someday add a metric based on Resource Timing milestones, probably in ServiceWorkerPageLoadMetricsObserver. - Port ServiceWorker.ActivatedWorkerPreparationForMainFrame.Type to NetS13nSW.
,
Jun 14 2018
Note: Grep histograms.xml for "ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time". There are a lot of them. They should be moved to ServiceWorker.ActivatedWorkerPreparationForMainFrame.Type. We could also just leave it for now and say "not supported in S13nSW/NetworkService, will be removed after it ships". That may be easier.
,
Jun 15 2018
Trying to port ServiceWorker.ActivatedWorkerPreparationForMainFrame.Type to NetS13nSW.
,
Jun 19 2018
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/329c9ad37b46be0d412448f49ab651081553597c commit 329c9ad37b46be0d412448f49ab651081553597c Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Jun 21 03:41:32 2018 S13nSW: Record ActivateWorkerPreparationForMainFrame UMAs Before this CL we haven't recorded following UMA in S13nSW path: - ServiceWorker.ActivatedWorkerPreparationForMainFrame.Type This CL adds recording this UMA. Bug: 852664 Change-Id: Iba8701e2a17dc857f26c5cc80ae5dc1075170c1f Reviewed-on: https://chromium-review.googlesource.com/1101606 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569148} [modify] https://crrev.com/329c9ad37b46be0d412448f49ab651081553597c/content/browser/service_worker/service_worker_metrics.cc [modify] https://crrev.com/329c9ad37b46be0d412448f49ab651081553597c/content/browser/service_worker/service_worker_navigation_loader.cc [modify] https://crrev.com/329c9ad37b46be0d412448f49ab651081553597c/content/browser/service_worker/service_worker_navigation_loader.h [modify] https://crrev.com/329c9ad37b46be0d412448f49ab651081553597c/tools/metrics/histograms/histograms.xml
,
Jun 21 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by falken@chromium.org
, Jun 14 2018