New issue
Advanced search Search tips

Issue 852648 link

Starred by 1 user
Status: Fixed
Owner:
mheikal@chromium.org
Closed: Jun 2018
Cc:
mheikal@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.webapps.WebApkIntegrationTest#testWebApkLaunchesByLauncherActivity" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 14 2018 
"org.chromium.chrome.browser.webapps.WebApkIntegrationTest#testWebApkLaunchesByLauncherActivity" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 15 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyaQsSBUZsYWtlIl5vcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIud2ViYXBwcy5XZWJBcGtJbnRlZ3JhdGlvblRlc3QjdGVzdFdlYkFwa0xhdW5jaGVzQnlMYXVuY2hlckFjdGl2aXR5DA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by jdoerrie@chromium.org, Jun 14 2018 

Stack trace:

java.lang.NullPointerException
	at org.chromium.chrome.browser.ChromeActivity.onStop(ChromeActivity.java:1212)
	at android.app.Instrumentation.callActivityOnStop(Instrumentation.java:1212)
	at android.support.test.runner.MonitoringInstrumentation.callActivityOnStop(MonitoringInstrumentation.java:555)
	at android.app.Activity.performStop(Activity.java:5376)
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:3442)
	at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:3501)
	at android.app.ActivityThread.access$1400(ActivityThread.java:135)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1249)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5001)
	at java.lang.reflect.Method.invokeNative(Method.java)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
	at dalvik.system.NativeStart.main(NativeStart.java)

Comment 2 by jdoerrie@chromium.org, Jun 14 2018

Components: Mobile>WebAPKs
Labels: -Sheriff-Chromium
Owner: pkotw...@chromium.org
Status: Assigned (was: Untriaged)
Disabling test in https://crrev.com/c/1100890. Assinging to pkotwicz to investigate further.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b5158183adb0a1eaf1381f3fec7b16e636f1f83

commit 4b5158183adb0a1eaf1381f3fec7b16e636f1f83
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Jun 14 14:58:33 2018

Android: Mark testWebApkLaunchesByLauncherActivity as flaky

TBR=pkotwicz

Bug:  852648 
Change-Id: I2799a73ecec82d9ceef99f0280655096ed2d3bdd
Reviewed-on: https://chromium-review.googlesource.com/1100890
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567265}
[modify] https://crrev.com/4b5158183adb0a1eaf1381f3fec7b16e636f1f83/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java

Comment 4 by yfried...@chromium.org, Jun 14 2018

Cc: mheikal@chromium.org
Could this be related to Mohamed's CL for lazy inflation?

Comment 5 by mheikal@chromium.org, Jun 14 2018 

yes it is, should I revert the CL now or just fix it since the test was marked as flakey.

Comment 6 by mheikal@chromium.org, Jun 14 2018

Owner: mheikal@chromium.org
working on a fix.

Comment 7 by yfried...@chromium.org, Jun 14 2018 

If it's user facing, revert. Otherwise we can fix since it's already marked flaky
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02cbeeca284e237722c16f08342f578e23e68df4

commit 02cbeeca284e237722c16f08342f578e23e68df4
Author: Mohamed Heikal <mheikal@google.com>
Date: Fri Jun 15 02:50:54 2018

[Android] Fix test flake WebApkIntegrationTest#testWebApkLaunchesByLauncherActivity

Fix cause for test flake
WebApkIntegrationTest#testWebApkLaunchesByLauncherActivity and remove the
flakey label.

Bug:  852648 
Change-Id: Iafbfd37297d8b589aa11455f2d6f129a74f2af43
Reviewed-on: https://chromium-review.googlesource.com/1101465
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567525}
[modify] https://crrev.com/02cbeeca284e237722c16f08342f578e23e68df4/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/02cbeeca284e237722c16f08342f578e23e68df4/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkIntegrationTest.java

Comment 9 by mheikal@google.com, Jun 19 2018

Status: Fixed (was: Assigned)
looks like the test is no longer flaky. Closing bug.
►

Sign in to add a comment