New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852633 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 852179



Sign in to add a comment

Failing tests for dev-go packages breaking chromeos-infra-go

Project Member Reported by ayatane@chromium.org, Jun 14 2018

Issue description

Various dev-go ebuild tests are failing
 
Blockedon: 852179
rahulchaudry, so far it looks like the GCP project does a pretty good job hiding its integration tests away from the short flag.  Would that be quick to change in the cros-go eclass?  It would quickly fix what I suspect to be many more broken tests.
Yes, I think we should run the tests with "-short" by default.
Sent https://chromium-review.googlesource.com/1101467
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/61cbad762defe9068675a864e20c59f1df705f6d

commit 61cbad762defe9068675a864e20c59f1df705f6d
Author: Allen Li <ayatane@chromium.org>
Date: Fri Jun 15 17:57:11 2018

chromeos-infra-go: Disable tests

The tests don't work (see linked bug).  In the mean time, we really
need to get the builder and pre-cq working, so disable the tests so we
can get some more recent builds.

BUG= chromium:852633 
TEST=None

Change-Id: I7d339a42ad6d3f1d83d716b55476a6f0cf63c177
Reviewed-on: https://chromium-review.googlesource.com/1100480
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/61cbad762defe9068675a864e20c59f1df705f6d/cbuildbot/stages/infra_stages.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/61cafff06c668945f52895ae3e001987c3591867

commit 61cafff06c668945f52895ae3e001987c3591867
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Jun 15 18:10:50 2018

cros-go.eclass: run tests with "-short" flag.

This is a standard flag supported by "go test". Typically, test files
check it to skip tests that take a long time, or tests that touch the
network. This should be the default behavior when running tests from an
ebuild. If an ebuild wants to run full tests, it can call "go_test"
directly with the desired package names (and without the -short flag).

BUG= chromium:852633 
TEST=Emerged 56 ebuilds in chromiumos-overlay with FEATURES=test.
TEST='sudo FEATURES=test emerge dev-go/net' runs twice as fast.

Change-Id: I645f5c079aa577bdcbcf7ebd78d5d97275e2e366
Reviewed-on: https://chromium-review.googlesource.com/1101467
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/61cafff06c668945f52895ae3e001987c3591867/eclass/cros-go.eclass

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0496b4e506eb35f69d49007198fa1e666d5646df

commit 0496b4e506eb35f69d49007198fa1e666d5646df
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Jun 16 15:52:18 2018

Roll src/third_party/chromite 3a51f2a80a38..ae92f3c98fbe (10 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3a51f2a80a38..ae92f3c98fbe


git log 3a51f2a80a38..ae92f3c98fbe --date=short --no-merges --format='%ad %ae %s'
2018-06-16 chrome-bot@chromium.org Update config settings by config-updater.
2018-06-16 dgarrett@google.com chromeos_config: Require all non-slaves to be important.
2018-06-15 lannm@chromium.org Annotate ScheduleSlavesStage with scheduled build links
2018-06-15 dgarrett@google.com generic_stages: Stop tagging skipped stages.
2018-06-15 dgarrett@google.com chromeos_config: Switch full builders to manifest_version.
2018-06-15 manojgupta@chromium.org Revert "chrome-sdk: Remove absolute path from simple chrome build using goma"
2018-06-15 xixuan@chromium.org SkylabHWTest: Swtich to use nyan_blaze release image to test.
2018-06-15 vapier@chromium.org cros lint: ignore initial UTF-8 BOM in JSON files
2018-06-15 ayatane@chromium.org chromeos-infra-go: Disable tests
2018-06-15 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@ae92f3c98fbe

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:852600,chromium:852916,chromium:851183,chromium:824548,chromium:846610,chromium:845314,chromium:None,chromium:852633
TBR=chrome-os-gardeners@chromium.org

Change-Id: Id646fa70fc50cd3fd10506b67812fb6782bfdf36
Reviewed-on: https://chromium-review.googlesource.com/1103501
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567895}
[modify] https://crrev.com/0496b4e506eb35f69d49007198fa1e666d5646df/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e3b1a74180c30f9b05210383fb94e8422c441e0c

commit e3b1a74180c30f9b05210383fb94e8422c441e0c
Author: Allen Li <ayatane@chromium.org>
Date: Thu Jun 21 23:31:13 2018

Revert "chromeos-infra-go: Disable tests"

This reverts commit 61cbad762defe9068675a864e20c59f1df705f6d.

Reason for revert: (Check if) tests are fixed by running chromeos-infra-go-pre-cq

Original change's description:
> chromeos-infra-go: Disable tests
>
> The tests don't work (see linked bug).  In the mean time, we really
> need to get the builder and pre-cq working, so disable the tests so we
> can get some more recent builds.
>
> BUG= chromium:852633 
> TEST=None
>
> Change-Id: I7d339a42ad6d3f1d83d716b55476a6f0cf63c177
> Reviewed-on: https://chromium-review.googlesource.com/1100480
> Commit-Ready: Allen Li <ayatane@chromium.org>
> Tested-by: Allen Li <ayatane@chromium.org>
> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

Bug:  chromium:852633 
Change-Id: I57ec2769730f5c7b5da6b60f39b3e1963f286242
Reviewed-on: https://chromium-review.googlesource.com/1103637
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/e3b1a74180c30f9b05210383fb94e8422c441e0c/cbuildbot/stages/infra_stages.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9cac21c5d564a4ad329e6f9d743e3708f2b8b12

commit b9cac21c5d564a4ad329e6f9d743e3708f2b8b12
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 22 01:32:08 2018

Roll src/third_party/chromite 0d22d3fa3ae1..694c8ff073d5 (7 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0d22d3fa3ae1..694c8ff073d5


git log 0d22d3fa3ae1..694c8ff073d5 --date=short --no-merges --format='%ad %ae %s'
2018-06-21 metzman@chromium.org [fuzzing] Make env more realistic
2018-06-21 dgarrett@google.com cros_tryjob: Use "default_debug" email template for --debug.
2018-06-21 ayatane@chromium.org Revert "chromeos-infra-go: Disable tests"
2018-06-21 dgarrett@google.com cbuildbot_launch: Tiny tweak to _MaybeCleanDistfiles.
2018-06-21 dgarrett@google.com cbuildbot: Remove .trybot marker concept.
2018-06-21 dgarrett@google.com config_lib: Remove config_lib.UseBuildbucketScheduler.
2018-06-21 dgarrett@google.com buildbucket_lib: Remove config_lib.UseBuildbucketScheduler.


Created with:
  gclient setdep -r src/third_party/chromite@694c8ff073d5

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:648042, chromium:854734 , chromium:852633 ,chromium:None,chromium:None,chromium:853025,chromium:853025
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ifce3485cd2e96d41803591c9a039daf716555a68
Reviewed-on: https://chromium-review.googlesource.com/1111158
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569494}
[modify] https://crrev.com/b9cac21c5d564a4ad329e6f9d743e3708f2b8b12/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b8ef1381e3f0e8ae5ce948eaa52d6e23799c6815

commit b8ef1381e3f0e8ae5ce948eaa52d6e23799c6815
Author: Allen Li <ayatane@chromium.org>
Date: Sat Jun 23 00:22:13 2018

gcp-bigquery: Re-enable tests

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1093538

The tests were originally disabled because they talk to the network,
but we now run Go tests with -short which disables only the bad tests.

BUG= chromium:852633 
TEST=Run chromeos-infra-go-pre-cq tryjob

Change-Id: I1a7541c4b6e8947b60949c3d29d085f95922a381
Reviewed-on: https://chromium-review.googlesource.com/1111329
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[rename] https://crrev.com/b8ef1381e3f0e8ae5ce948eaa52d6e23799c6815/dev-go/gcp-bigquery/gcp-bigquery-0.18.0-r4.ebuild
[modify] https://crrev.com/b8ef1381e3f0e8ae5ce948eaa52d6e23799c6815/dev-go/gcp-bigquery/gcp-bigquery-0.18.0.ebuild

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/de35565465105a5ca3ae911a79817798cac03fb1

commit de35565465105a5ca3ae911a79817798cac03fb1
Author: Allen Li <ayatane@chromium.org>
Date: Tue Jun 26 07:05:24 2018

gcp-monitoring: Re-enable tests

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1097537

The tests were originally disabled because they talk to the network,
but we now run Go tests with -short which disables only the bad tests.

BUG= chromium:852633 
TEST=Run chromeos-infra-go-pre-cq tryjob

Change-Id: I491f7404b282d8b178747e33fb745fef38d79f82
Reviewed-on: https://chromium-review.googlesource.com/1112386
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[rename] https://crrev.com/de35565465105a5ca3ae911a79817798cac03fb1/dev-go/gcp-monitoring/gcp-monitoring-0.18.0-r5.ebuild
[modify] https://crrev.com/de35565465105a5ca3ae911a79817798cac03fb1/dev-go/gcp-monitoring/gcp-monitoring-0.18.0.ebuild

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7bc214b120f845e4b713dc2094e18af43756ce95

commit 7bc214b120f845e4b713dc2094e18af43756ce95
Author: Allen Li <ayatane@chromium.org>
Date: Thu Jun 28 05:07:17 2018

gcp-trace: Re-enable tests

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1100313

The tests were originally disabled because they talk to the network,
but we now run Go tests with -short which disables only the bad tests.

BUG= chromium:852633 
TEST=Run chromeos-infra-go-pre-cq tryjob

Change-Id: Icf2fc5b1ccace0d1236cc555c82ff263cbc3e745
Reviewed-on: https://chromium-review.googlesource.com/1112392
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[rename] https://crrev.com/7bc214b120f845e4b713dc2094e18af43756ce95/dev-go/gcp-trace/gcp-trace-0.18.0-r5.ebuild
[modify] https://crrev.com/7bc214b120f845e4b713dc2094e18af43756ce95/dev-go/gcp-trace/gcp-trace-0.18.0.ebuild

Status: Fixed (was: Assigned)
Okay, that should be all of the packages I touched.

Sign in to add a comment