New issue
Advanced search Search tips

Issue 852623 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug

Blocking:
issue 847104



Sign in to add a comment

Running browser_tests updates chrome/test/data/extensions/theme/Cached Theme.pak in the source tree.

Project Member Reported by tapted@chromium.org, Jun 14 2018

Issue description

Added in r565169

Tests should never modify things in the source tree.
 
Owner: ----
Status: Untriaged (was: Assigned)
Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)
tapted@: Were you seeing a call to WritePackToDiskCallback? (https://cs.chromium.org/chromium/src/chrome/browser/themes/theme_service.cc?rcl=09a09494971fba3dd8ec7573abc5d0c872136303&l=98) That's pretty much the main call I can see that would write to Cached Theme.pak.
Owner: tetsui@chromium.org
no - git was complaining that I had a modified source tree after running browser_tests. chrome/test/data/extensions/theme/Cached Theme.pak was the file that changed.

The file didn't exist before tetsui@'s change in https://chromium-review.googlesource.com/c/chromium/src/+/1086821

I don't have context for why that file was added in that cl, or why it changes.
Labels: OS-Linux
Happens for me on Linux as well.

Sign in to add a comment