Settings crashes on Caroline ToT |
||||||
Issue descriptionChrome Version: 69.0.3458 What steps will reproduce the problem? (1) Open settings (2) Wait (3) Aw, Snap! page appears What is the expected result? Settings page does not crash if left open What happens instead? Settings page crashes It looks like https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/people_page.js?rcl=5b66ed289e297e8a7d0adee64a29728f8b58c1ad&l=295 is calling 'shouldShowSyncAccountControl_' which is not defined for CrOS: https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/sync_page.js?rcl=5b66ed289e297e8a7d0adee64a29728f8b58c1ad&l=572
,
Jun 20 2018
,
Aug 23
Hi Bailey, sorry, this somehow slipped through my fingers! Yes, this probably is a bug. Though shouldShowSyncAccountControl_ is only taken into consideration when shouldRecordSigninImpression is true. This is the case when the user is *NOT* signed in. Shouldn't there always be a signed in user on CrOS?
,
Sep 7
,
Sep 28
,
Nov 13
Closing as I don't think think this is relevant anymore. If this issue still exists please reopen. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by baileyberro@chromium.org
, Jun 13 2018