browser's frame becomes briefly transparent when activation changes. |
|||||||
Issue descriptionToT as of today (#566288) video: https://drive.google.com/file/d/1-AeRQQ5UZXbJeRdsvRirdZ6FYjzSFRs0/view?usp=sharing I'm wondering if this is related to crbug.com/836023. danakj@, can you take a look?
,
Jun 15 2018
bisected to https://chromium.googlesource.com/chromium/src/+/8f007b9234b738cb34689863b43a6fdff62e9f95 reverting it on ToT fixed this.
,
Jun 15 2018
,
Jun 15 2018
Oh no, sorry :( I really looked for this when I was testing the patch to see if it did something weird.. I'll look more.
,
Jun 15 2018
Oh, it's a solid color theme, the kPlus blending mode is only happening for images now.
,
Jun 15 2018
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f074984fcd90bfcb042019683226fb9d1d28967 commit 8f074984fcd90bfcb042019683226fb9d1d28967 Author: danakj <danakj@chromium.org> Date: Mon Jun 18 20:04:03 2018 Use kPlus blending mode for solid-color themed window title bars. With an image theme we use kPlus blending mode so that the alpha of the active and inactive images together adds to 255, and is opaque. Before 8f007b9234b738cb34689863b43a6fdff62e9f95 we did the same for solid colors as well. But afterward it was lost, only applying to images. This CL restores the kPlus mode for solid colors too. R=oshima@chromium.org Bug: 852612 Change-Id: I6f581d34dea85d98dc602e34a4ad87e4115d2d8c Reviewed-on: https://chromium-review.googlesource.com/1103012 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#568120} [modify] https://crrev.com/8f074984fcd90bfcb042019683226fb9d1d28967/ash/frame/custom_frame_header.cc
,
Jun 18 2018
,
Jun 18 2018
M-68 was at 561733. The bug happened in 557265, so this is in M-68.
,
Jun 19 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 19 2018
Does anyone have a canary device and is able to verify the fix there?
,
Jun 19 2018
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/158666cd6d3c0b61f5875ccb0d3fe3e675060a56 commit 158666cd6d3c0b61f5875ccb0d3fe3e675060a56 Author: danakj <danakj@chromium.org> Date: Fri Jun 22 22:45:25 2018 Use kPlus blending mode for solid-color themed window title bars. With an image theme we use kPlus blending mode so that the alpha of the active and inactive images together adds to 255, and is opaque. Before 8f007b9234b738cb34689863b43a6fdff62e9f95 we did the same for solid colors as well. But afterward it was lost, only applying to images. This CL restores the kPlus mode for solid colors too. TBR=danakj@chromium.org, oshima@chromium.org (cherry picked from commit 8f074984fcd90bfcb042019683226fb9d1d28967) Bug: 852612 Change-Id: I6f581d34dea85d98dc602e34a4ad87e4115d2d8c Reviewed-on: https://chromium-review.googlesource.com/1103012 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#568120} Reviewed-on: https://chromium-review.googlesource.com/1112705 Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#499} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/158666cd6d3c0b61f5875ccb0d3fe3e675060a56/ash/frame/custom_frame_header.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by danakj@chromium.org
, Jun 14 2018