New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 852611 link

Starred by 1 user
Status: Fixed
Owner:
█ holte@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
a...@chromium.org
csharrison@chromium.org
█ holte@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Test failures due to UKM entries not recording on official desktop continuous Win and Win64 builder.

Project Member Reported by pbomm...@chromium.org, Jun 13 2018 
PopupTrackerBrowserTest's which are failing :

1.PopupTrackerBrowserTest.ControlClick_HasTracker
2.PopupTrackerBrowserTest.ShiftClick_HasTracker
3.PopupTrackerBrowserTest.WhitelistedPopup_HasTracker
4.PopupTrackerBrowserTest.WindowOpenPopup_HasTracker_GestureClose

Link to builders :
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/86200

https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/35433


Link to Error log : 
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fwin64_trunk%2F35433%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPopupTrackerBrowserTest.ControlClick_HasTracker%2F0

Comment 1 by csharrison@chromium.org, Jun 15 2018

Owner: holte@chromium.org
Status: Assigned (was: Untriaged)
It looks like all the errors have to do with UKM logging in browser_tests. holte: do you know what happened? It looks like the builders are green again.

Comment 2 by holte@chromium.org, Jun 15 2018

Owner: csharrison@chromium.org
I don't think we've made any recent changes on the UKM side that should affect this.

The errors are that an expected event was not recorder, which imply that the code here is not being run:
https://codesearch.chromium.org/chromium/src/chrome/browser/ui/blocked_content/popup_tracker.cc?rcl=deda551f496ebb23f44d75fb241fa22ef41088f3&l=66

Comment 3 by csharrison@chromium.org, Jun 15 2018 

Sorry, I meant that this was a general problem, not just in popup tracker. E.g. if you look at the builder failures:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/35433

Multiple test suites are failing and it seems like they all fail some UKM check. That's why I suspected a lower-level problem.

Comment 4 by csharrison@chromium.org, Jun 15 2018

Cc: holte@chromium.org
+holte back to cc, see response in #3

Comment 5 by holte@chromium.org, Jun 15 2018

Owner: holte@chromium.org
Summary: Test failures due to UKM entries not recording on official desktop continuous Win and Win64 builder. (was: Observing few "PopupTrackerBrowserTest" test's failures on official desktop continuous Win and Win64 builder.)
Ah, yes, that is more compelling.  Looking into this a bit more.

Comment 7 by holte@chromium.org, Jun 15 2018

Status: Fixed (was: Assigned)

Comment 8 by csharrison@chromium.org, Jun 15 2018 

Thanks for investigating!
►

Sign in to add a comment