New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852594 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Use dimensions from swarmbucket for luci builds

Project Member Reported by lijeffrey@chromium.org, Jun 13 2018

Issue description

Instead of getting static dimensions for triggering try jobs, which is read from config and will be deprecated, get them from swarmbucket for luci builds. Fallback to config otherwise
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/efd3a39ea47118eeef4057e80a6212191908b0ab

commit efd3a39ea47118eeef4057e80a6212191908b0ab
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu Jun 14 22:10:49 2018

[Findit] Flake Analyzer - Get bot dimensions from swarmbucket

For luci builds, use swarmbucket to get the dimensions for try jobs. If
the builder is not on luci, then fall back to the static mapping of what's
defined in config.

Bug:  852594 
Change-Id: I39f06d3065f1c33dfc9bc7222424eb6b060b1b45
Reviewed-on: https://chromium-review.googlesource.com/1100477
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/efd3a39ea47118eeef4057e80a6212191908b0ab/appengine/findit/services/test/try_job_test.py
[modify] https://crrev.com/efd3a39ea47118eeef4057e80a6212191908b0ab/appengine/findit/services/try_job.py
[modify] https://crrev.com/efd3a39ea47118eeef4057e80a6212191908b0ab/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[modify] https://crrev.com/efd3a39ea47118eeef4057e80a6212191908b0ab/appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py
[modify] https://crrev.com/efd3a39ea47118eeef4057e80a6212191908b0ab/appengine/findit/pipelines/flake_failure/test/get_isolate_sha_pipeline_test.py
[modify] https://crrev.com/efd3a39ea47118eeef4057e80a6212191908b0ab/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/efd3a39ea47118eeef4057e80a6212191908b0ab/appengine/findit/pipelines/flake_failure/get_isolate_sha_pipeline.py
[modify] https://crrev.com/efd3a39ea47118eeef4057e80a6212191908b0ab/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py
[modify] https://crrev.com/efd3a39ea47118eeef4057e80a6212191908b0ab/appengine/findit/waterfall/flake/initialize_flake_pipeline.py
[modify] https://crrev.com/efd3a39ea47118eeef4057e80a6212191908b0ab/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py

Status: Fixed (was: Untriaged)

Sign in to add a comment