New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852588 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Findit] Auto revert might conflict with other changes

Project Member Reported by chanli@chromium.org, Jun 13 2018

Issue description

Findit's auto revert might conflict with other changes, for example there might be a depending change of the culprit or a fix to the culprit already committed when Findit is trying to revert the culprit.

Solution to it could be:
1. Naive solution: don't commit the revert if there is a change from the culprit author landed.

2. More reliable solution: 
  a. create the revert
  b. run a try job to verify the revert can pass compile and failed tests passes
  c. commit the revert if verified; otherwise abandon the revert.
 

Comment 1 by chanli@chromium.org, Jun 13 2018

Cc: chanli@chromium.org lijeffrey@chromium.org m...@chromium.org
 Issue 844264  has been merged into this issue.

Comment 2 by chanli@chromium.org, Jun 13 2018

 Issue 846922  has been merged into this issue.

Comment 3 by st...@chromium.org, Jun 14 2018

Could we copy miu@'s suggestions here from the duplicated  bug 844264 ?
I'd prefer to use  bug 844264  instead, and update the bug description, but creating this new one is fine too -- just lost some discussion and context.
Status: Fixed (was: Started)

Sign in to add a comment