New issue
Advanced search Search tips

Issue 852581 link

Starred by 3 users
Status: Fixed
Owner:
tandrii@chromium.org
Closed: Jun 2018
Cc:
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove stray depot_tools from PATH on swarming tasks

Project Member Reported by tandrii@chromium.org, Jun 13 2018

Comment 1 by tandrii@chromium.org, Jun 13 2018 

Answer: this is super duper old bot. filed issue 852609 to re-image it.

maruel@ I recall you were working on automatic pruning of depot_tools from PATH. Do you have ETA?

Comment 2 by mar...@chromium.org, Jun 14 2018

Labels: Pri-2 Type-Bug
Status: Available (was: Untriaged)
There's issue 757980 which is the closest. I've been quite cautious about the removal as detection is hard and once the directory are removed it's hard to bring them back at scale.

Comment 3 by tandrii@chromium.org, Jun 14 2018

Owner: tandrii@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/faaf65a86829a8257cab26c4ab830363c191186d

commit faaf65a86829a8257cab26c4ab830363c191186d
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Jun 14 01:12:38 2018

Comment 6 by tandrii@chromium.org, Jun 15 2018

Summary: Remove stray depot_tools from PATH on swarming tasks (was: Why is e:\b\depot_tools making it into PATH on LUCI win swarming tasks)

Comment 7 by tandrii@chromium.org, Jun 18 2018

Labels: -Restrict-View-Google
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/b7b54ba3eb083449ee9e558beebd546d22f2dbcf

commit b7b54ba3eb083449ee9e558beebd546d22f2dbcf
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Jun 18 19:09:53 2018

Comment 9 by tandrii@chromium.org, Jun 18 2018

Status: Started (was: Assigned)
PSA sent. Fun begins now https://chrome-internal-review.googlesource.com/c/infradata/config/+/640335

Revert if you see something, but record that something here.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/4ed3ebfc2aa5d3bc77cd986ff3e3da781be0d70b

commit 4ed3ebfc2aa5d3bc77cd986ff3e3da781be0d70b
Author: Andrii Shyshkalov <tandrii@google.com>
Date: Mon Jun 18 19:57:39 2018
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/647143453af4139497ce0239afeeee352cf294c7

commit 647143453af4139497ce0239afeeee352cf294c7
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Jun 18 21:05:58 2018
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/dd9b3b0e7b8af2fef77615c228589f4e0bff9bc4

commit dd9b3b0e7b8af2fef77615c228589f4e0bff9bc4
Author: Andrii Shyshkalov <tandrii@google.com>
Date: Mon Jun 18 21:23:59 2018
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/96aa535b782f31df0f063213c2958acba32a808d

commit 96aa535b782f31df0f063213c2958acba32a808d
Author: Ben Wagner <benjaminwagner@google.com>
Date: Tue Jun 19 17:29:15 2018

Remove .bat and .exe from commands where possible.

We expect .BAT and .EXE to be on PATHEXT. Also, although Python
CreateProcess doesn't honor PATHEXT, it will try .EXE. This allows most
commands to be platform-independent, and also resolves the issue with
the cpython package not including python.bat.

No-Tree-Checks: true
Docs-Preview: https://skia.org/?cl=135626
Bug:  chromium:852581 
Change-Id: Iab4189407df44ff4ad4d37da07ff52414229d397
Reviewed-on: https://skia-review.googlesource.com/135626
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>

[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/infra/bots/recipe_modules/build/android.py
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/tools/git-sync-deps
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/infra/bots/recipe_modules/build/chromecast.py
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/infra/bots/gen_tasks.go
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/gn/toolchain/BUILD.gn
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/infra/bots/recipe_modules/build/examples/full.expected/Build-Win-Clang-x86_64-Release-Vulkan.json
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/site/user/build.md
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/infra/bots/recipe_modules/build/chromebook.py
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/infra/bots/recipes/compile.expected/Build-Win-Clang-x86-Debug.json
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/infra/bots/recipe_modules/build/examples/full.expected/Build-Win-Clang-arm64-Release-Android.json
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/infra/bots/recipe_modules/build/default.py
[modify] https://crrev.com/96aa535b782f31df0f063213c2958acba32a808d/infra/bots/recipe_modules/build/examples/full.expected/Build-Win-Clang-x86-Debug-Exceptions.json
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/629d0a979920e182948e0a6b93e03d08057f4d44

commit 629d0a979920e182948e0a6b93e03d08057f4d44
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 19 18:53:35 2018

Roll src/third_party/skia ba61029c5b49..96aa535b782f (1 commits)

https://skia.googlesource.com/skia.git/+log/ba61029c5b49..96aa535b782f


git log ba61029c5b49..96aa535b782f --date=short --no-merges --format='%ad %ae %s'
2018-06-19 benjaminwagner@google.com Remove .bat and .exe from commands where possible.


Created with:
  gclient setdep -r src/third_party/skia@96aa535b782f

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:852581 
TBR=kjlubick@chromium.org

Change-Id: I59207c703be4e7429eee0a39a69724e23d9e331b
Reviewed-on: https://chromium-review.googlesource.com/1106497
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568543}
[modify] https://crrev.com/629d0a979920e182948e0a6b93e03d08057f4d44/DEPS
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/64ac95e9d615424c76d7a1d5d23a0628dda14c83

commit 64ac95e9d615424c76d7a1d5d23a0628dda14c83
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Jun 19 19:33:14 2018

Comment 16 by tandrii@chromium.org, Jun 20 2018 

5 hours and no complaints. If this sticks by tomorrow evening PST, this bug is fixed, and can proceed towards removing depot_tools entirely.

Comment 17 by tandrii@chromium.org, Jun 20 2018

Status: Fixed (was: Started)
27 hours and no reports of failures.
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 26 2018

Labels: merge-merged-m68
The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e1b44566996886959f9d01e5dadd5eb779f14c1d

commit e1b44566996886959f9d01e5dadd5eb779f14c1d
Author: Ben Wagner <benjaminwagner@google.com>
Date: Tue Jun 26 20:28:25 2018

Fix Windows on m68 branch.

This includes 3 cherry-picked CLs:

-----

    Update gen_tasks.go to use unforked glog

    Required after https://skia-review.googlesource.com/130562

    Bug: skia:
    Change-Id: I6409622b5124422906e7acfae96acab46305e1f7
    Reviewed-on: https://skia-review.googlesource.com/133042
    Reviewed-by: Ravi Mistry <rmistry@google.com>
    Commit-Queue: Eric Boren <borenet@google.com>

-----

    [infra] Include cpython CIPD package on Windows

    No-Tree-Checks: true
    Bug: skia:
    Change-Id: I08854d88e33d00e4bb56eb6eb346592618bd2693
    Reviewed-on: https://skia-review.googlesource.com/135579
    Commit-Queue: Ben Wagner <benjaminwagner@google.com>
    Reviewed-by: Ben Wagner <benjaminwagner@google.com>
    Reviewed-by: Kevin Lubick <kjlubick@google.com>
    Auto-Submit: Eric Boren <borenet@google.com>

-----

    Remove .bat and .exe from commands where possible.

    We expect .BAT and .EXE to be on PATHEXT. Also, although Python
    CreateProcess doesn't honor PATHEXT, it will try .EXE. This allows most
    commands to be platform-independent, and also resolves the issue with
    the cpython package not including python.bat.

    No-Tree-Checks: true
    Docs-Preview: https://skia.org/?cl=135626
    Bug:  chromium:852581 
    Change-Id: Iab4189407df44ff4ad4d37da07ff52414229d397
    Reviewed-on: https://skia-review.googlesource.com/135626
    Commit-Queue: Ben Wagner <benjaminwagner@google.com>
    Auto-Submit: Ben Wagner <benjaminwagner@google.com>
    Reviewed-by: Eric Boren <borenet@google.com>
    Reviewed-by: Mike Klein <mtklein@google.com>
    (cherry picked from commit 96aa535b782f31df0f063213c2958acba32a808d)

-----

Re-trained due to tasks.json conflict.

No-Try: true
Change-Id: Iab4189407df44ff4ad4d37da07ff52414229d397
Reviewed-on: https://skia-review.googlesource.com/137660
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>

[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/infra/bots/recipe_modules/build/android.py
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/tools/git-sync-deps
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/infra/bots/recipe_modules/build/chromecast.py
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/infra/bots/gen_tasks.go
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/infra/bots/tasks.json
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/gn/toolchain/BUILD.gn
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/infra/bots/recipe_modules/build/examples/full.expected/Build-Win-Clang-x86_64-Release-Vulkan.json
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/site/user/build.md
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/infra/bots/recipe_modules/build/chromebook.py
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/infra/bots/recipes/compile.expected/Build-Win-Clang-x86-Debug.json
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/infra/bots/recipe_modules/build/examples/full.expected/Build-Win-Clang-arm64-Release-Android.json
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/infra/bots/recipe_modules/build/default.py
[modify] https://crrev.com/e1b44566996886959f9d01e5dadd5eb779f14c1d/infra/bots/recipe_modules/build/examples/full.expected/Build-Win-Clang-x86-Debug-Exceptions.json
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/d6c00bf781cf413e3857763a0bf31bead3c02707

commit d6c00bf781cf413e3857763a0bf31bead3c02707
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Jun 28 19:23:11 2018
►

Sign in to add a comment