Offline indicator implementation
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1413ebf700e8e629569d8d41919044539eaada47 commit 1413ebf700e8e629569d8d41919044539eaada47 Author: Jian Li <jianli@chromium.org> Date: Thu Jun 14 20:46:32 2018 Add feature flag for offline indicator Bug: 852577 Change-Id: I092cf8b80fba521725e24425e2e110937af2e222 Reviewed-on: https://chromium-review.googlesource.com/1100010 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#567389} [modify] https://crrev.com/1413ebf700e8e629569d8d41919044539eaada47/chrome/browser/about_flags.cc [modify] https://crrev.com/1413ebf700e8e629569d8d41919044539eaada47/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/1413ebf700e8e629569d8d41919044539eaada47/chrome/browser/flag_descriptions.h [modify] https://crrev.com/1413ebf700e8e629569d8d41919044539eaada47/components/offline_pages/core/offline_page_feature.cc [modify] https://crrev.com/1413ebf700e8e629569d8d41919044539eaada47/components/offline_pages/core/offline_page_feature.h [modify] https://crrev.com/1413ebf700e8e629569d8d41919044539eaada47/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61fe6cb13fa6c537ddc52794d409cae171fd7be3 commit 61fe6cb13fa6c537ddc52794d409cae171fd7be3 Author: Jian Li <jianli@chromium.org> Date: Mon Jun 25 23:27:00 2018 Show offline indicator via snackbar Detect if the network is disconnected. If so, show offline indicator UI via snackbar. Bug: 852577 Change-Id: Id04a2dffcd5a2d4aa582fd7c54e202ebaa14475d Reviewed-on: https://chromium-review.googlesource.com/1109395 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570237} [modify] https://crrev.com/61fe6cb13fa6c537ddc52794d409cae171fd7be3/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/61fe6cb13fa6c537ddc52794d409cae171fd7be3/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [add] https://crrev.com/61fe6cb13fa6c537ddc52794d409cae171fd7be3/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java [modify] https://crrev.com/61fe6cb13fa6c537ddc52794d409cae171fd7be3/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java [modify] https://crrev.com/61fe6cb13fa6c537ddc52794d409cae171fd7be3/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/61fe6cb13fa6c537ddc52794d409cae171fd7be3/chrome/android/java_sources.gni [add] https://crrev.com/61fe6cb13fa6c537ddc52794d409cae171fd7be3/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java [modify] https://crrev.com/61fe6cb13fa6c537ddc52794d409cae171fd7be3/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/61fe6cb13fa6c537ddc52794d409cae171fd7be3/tools/metrics/histograms/enums.xml [modify] https://crrev.com/61fe6cb13fa6c537ddc52794d409cae171fd7be3/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1043f20b94af423ed38c7934415af8a95de3133e commit 1043f20b94af423ed38c7934415af8a95de3133e Author: Jian Li <jianli@chromium.org> Date: Thu Jun 28 22:55:11 2018 Detect connected network without working Internet via Android API Bug: 852577 Change-Id: Icf852d1a7f454e623368fae5ecfeb523ee835bee Reviewed-on: https://chromium-review.googlesource.com/1119061 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#571311} [modify] https://crrev.com/1043f20b94af423ed38c7934415af8a95de3133e/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1088603e4b9da55e411e9d3b4c673998ed69d2ef commit 1088603e4b9da55e411e9d3b4c673998ed69d2ef Author: Jian Li <jianli@chromium.org> Date: Wed Aug 22 22:26:46 2018 Move connectivity detection code out of OfflineIndicatorController Bug: 852577 Change-Id: Ibad70134b5f43877a39ef48e4a6fc99546d7ca3d Reviewed-on: https://chromium-review.googlesource.com/1182288 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#585284} [add] https://crrev.com/1088603e4b9da55e411e9d3b4c673998ed69d2ef/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetector.java [modify] https://crrev.com/1088603e4b9da55e411e9d3b4c673998ed69d2ef/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java [modify] https://crrev.com/1088603e4b9da55e411e9d3b4c673998ed69d2ef/chrome/android/java_sources.gni [modify] https://crrev.com/1088603e4b9da55e411e9d3b4c673998ed69d2ef/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed610d265279583e06744b2de0c9b6b02639643b commit ed610d265279583e06744b2de0c9b6b02639643b Author: Jian Li <jianli@chromium.org> Date: Wed Aug 29 00:46:18 2018 Detect the connectivity via http probes for offline indicator Bug: 852577 Change-Id: If2bbc861084807e3eb5d806439994e92198c5d77 Reviewed-on: https://chromium-review.googlesource.com/1187557 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#586970} [modify] https://crrev.com/ed610d265279583e06744b2de0c9b6b02639643b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetector.java [modify] https://crrev.com/ed610d265279583e06744b2de0c9b6b02639643b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java [modify] https://crrev.com/ed610d265279583e06744b2de0c9b6b02639643b/chrome/android/java_sources.gni [add] https://crrev.com/ed610d265279583e06744b2de0c9b6b02639643b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetectorTest.java [modify] https://crrev.com/ed610d265279583e06744b2de0c9b6b02639643b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d5095ffea96c2388b9a9a7bfbeb96e4b18d3120 commit 4d5095ffea96c2388b9a9a7bfbeb96e4b18d3120 Author: Jian Li <jianli@chromium.org> Date: Wed Aug 29 22:14:29 2018 Update Offline Indicator UI based on latest mock Changed the icon and action link text per spec. Bug: 852577 Change-Id: I7d3a260ead0d1c0affcbde35a343bacd0f5b34c7 Reviewed-on: https://chromium-review.googlesource.com/1195923 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#587319} [modify] https://crrev.com/4d5095ffea96c2388b9a9a7bfbeb96e4b18d3120/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java [modify] https://crrev.com/4d5095ffea96c2388b9a9a7bfbeb96e4b18d3120/chrome/android/java/strings/android_chrome_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a02341179f376723e4a88ecce18cdf706e12749c commit a02341179f376723e4a88ecce18cdf706e12749c Author: Jian Li <jianli@chromium.org> Date: Thu Aug 30 20:58:29 2018 Subsequent offline indicator should be shown after offline is stablized Bug: 852577 Change-Id: I5d929cd04499a9c694c72ab5607871455ff65169 Reviewed-on: https://chromium-review.googlesource.com/1196011 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#587755} [modify] https://crrev.com/a02341179f376723e4a88ecce18cdf706e12749c/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java [modify] https://crrev.com/a02341179f376723e4a88ecce18cdf706e12749c/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java
Comment 1 by bugdroid1@chromium.org
, Jun 14 2018