New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852572 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Create onpictureinpicturecontrolsclick PictureInPictureControlsEventHandler

Project Member Reported by sawtelle@google.com, Jun 13 2018

Issue description

Create the event handler so that future work on the UI can hook up to this and trigger when appropriate.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42eac6a83fc486c1263a7b2c7858312d08c6fb09

commit 42eac6a83fc486c1263a7b2c7858312d08c6fb09
Author: sawtelle <sawtelle@google.com>
Date: Tue Jun 26 03:22:01 2018

[Picture in Picture] Add event handler for custom controls click

This change adds onpictureinpicturecontrolsclick to the partial
interface of an HTMLVideoElement and creates the plumbing that
allows for functions to trigger that event (note: it is not
currently being called in this CL).

Manual testing was done by initiating the call in
overlay_window_views.cc by calling controller_->ControlClick() and
confirming the new EventHandler was triggered.

Bug:  852572 
Change-Id: I57038fa4809085b7000ca7e5d933c38e82d133e7
Reviewed-on: https://chromium-review.googlesource.com/1100043
Commit-Queue: Steven Sawtelle <sawtelle@google.com>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570320}
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/content/common/media/media_player_delegate_messages.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/content/public/browser/picture_in_picture_window_controller.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/content/renderer/media/renderer_webmediaplayer_delegate.cc
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/content/renderer/media/renderer_webmediaplayer_delegate.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/media/blink/webmediaplayer_delegate.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/public/platform/web_media_player_client.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/renderer/core/events/event_type_names.json5
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/renderer/core/html/media/html_audio_element.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.idl
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.h
[modify] https://crrev.com/42eac6a83fc486c1263a7b2c7858312d08c6fb09/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 2 by sawtelle@google.com, Jun 26 2018

Status: Fixed (was: Assigned)

Sign in to add a comment