During https://chromium-review.googlesource.com/c/chromium/src/+/1083880, we had to split SaveCardCallback between local and upload versions due to adding a parameter to the upload version. It resulted in the following presubmit error:
** Presubmit Warnings **
Banned functions were used.
chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc:129:
Please consider using base::{Once,Repeating}Closure instead
of base::Closure. (crbug.com/714018)
chrome/browser/ui/autofill/chrome_autofill_client.cc:216:
Please consider using base::{Once,Repeating}Closure instead
of base::Closure. (crbug.com/714018)
chrome/browser/ui/autofill/save_card_bubble_controller_impl.h:115:
Please consider using base::{Once,Repeating}Closure instead
of base::Closure. (crbug.com/714018)
chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc:99:
Please consider using base::Bind{Once,Repeating} instead
of base::Bind. (crbug.com/714018)
components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc:34:
Please consider using base::{Once,Repeating}Closure instead
of base::Closure. (crbug.com/714018)
components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h:36:
Please consider using base::{Once,Repeating}Closure instead
of base::Closure. (crbug.com/714018)
components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h:82:
Please consider using base::{Once,Repeating}Closure instead
of base::Closure. (crbug.com/714018)
ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm:168:
Please consider using base::{Once,Repeating}Closure instead
of base::Closure. (crbug.com/714018)
These should probably be changed to BindOnce/OnceClosure, but note that web_view_autofill_client_ios.mm actually lists it as a RepeatingClosure (https://cs.chromium.org/chromium/src/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm?l=87&rcl=7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd).
Comment 1 by jsaul@google.com
, Jun 14 2018