New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 852553 link

Starred by 1 user
Status: Fixed
Owner:
alemate@chromium.org
Closed: Oct 20
Cc:
█ elizabethchiu@chromium.org
zalcorn@chromium.org
r...@chromium.org
█ xiaoyinh@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 862778



Sign in to add a comment

Eng tracking: Fingerprint and PIN enrollment in OOBE

Project Member Reported by zalcorn@chromium.org, Jun 13 2018 
Tracking addition of PIN + Fingerprint enrollment to OOBE.
Elizabeth, please add spec once ready.

Comment 1 by zalcorn@chromium.org, Jun 13 2018

Blocking: -814095 828996

Comment 2 by zalcorn@chromium.org, Jul 11

Summary: Eng tracking: Fingerprint and PIN enrollment in OOBE (was: Fingerprint and PIN enrollment in OOBE)

Comment 3 by zalcorn@chromium.org, Jul 12

Blocking: -828996 862778

Comment 4 by elizabethchiu@chromium.org, Aug 14 

Spec for the modules: https://drive.google.com/open?id=1GppG0gB8mshJbCi8sQExpfxjjCRWuSXV&authuser=elizabethchiu@google.com

Spec for Fingerprint: (@xiaoyinh is handling the set up) https://drive.google.com/open?id=17FGBk5ujuE_bRg_GjHR2GOQuKdJ9aO3Q&authuser=elizabethchiu@google.com

Spec for PIN: https://drive.google.com/open?id=18KjCK94LtzfN0zkfTR3K73gz1kEmg_4m&authuser=elizabethchiu@google.com

Please note that the authentication modules shows the same authentication screens that are on OOBE. It appears after user skipped the set up in OOBE.

Comment 5 by weifangsun@chromium.org, Aug 28

Cc: -alemate@chromium.org elizabethchiu@chromium.org
Labels: -M-69 M-70
Owner: alemate@chromium.org

Comment 6 by weifangsun@chromium.org, Aug 28

Cc: xiaoyinh@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a7002ddfac1b1089e1a99846525b5de20fc8794

commit 8a7002ddfac1b1089e1a99846525b5de20fc8794
Author: Alexander Alekseev <alemate@chromium.org>
Date: Thu Aug 30 23:16:01 2018

Chrome OS Discover: add strings for the PIN setup module.

This Cl adds strings only.

Bug:  852553 
Change-Id: Icc72b2c36a8c25a9a115aed33c555be0cf412e00
Reviewed-on: https://chromium-review.googlesource.com/1197845
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587831}
[modify] https://crrev.com/8a7002ddfac1b1089e1a99846525b5de20fc8794/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/8a7002ddfac1b1089e1a99846525b5de20fc8794/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_LEARN_MORE.png.sha1
[add] https://crrev.com/8a7002ddfac1b1089e1a99846525b5de20fc8794/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SKIP.png.sha1
[add] https://crrev.com/8a7002ddfac1b1089e1a99846525b5de20fc8794/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SUBTITLE1.png.sha1
[add] https://crrev.com/8a7002ddfac1b1089e1a99846525b5de20fc8794/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SUBTITLE3.png.sha1
[add] https://crrev.com/8a7002ddfac1b1089e1a99846525b5de20fc8794/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_TITLE1.png.sha1
[add] https://crrev.com/8a7002ddfac1b1089e1a99846525b5de20fc8794/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_TITLE2.png.sha1
[add] https://crrev.com/8a7002ddfac1b1089e1a99846525b5de20fc8794/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_TITLE3.png.sha1
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e8e715a9b15ccd9ac32eb112733f2791434ca65

commit 1e8e715a9b15ccd9ac32eb112733f2791434ca65
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Aug 31 23:37:28 2018

Chrome OS Settings: extract pin-setting keyboard element.

This CL extracts PIN-setting element into separate Polymer object which
could be used outside of Settings UI.

Bug:  852553 
Change-Id: I6da7b1dd0aaffde3b0c220bc2dd1650307904950
Reviewed-on: https://chromium-review.googlesource.com/1196763
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588211}
[modify] https://crrev.com/1e8e715a9b15ccd9ac32eb112733f2791434ca65/chrome/browser/resources/settings/people_page/BUILD.gn
[add] https://crrev.com/1e8e715a9b15ccd9ac32eb112733f2791434ca65/chrome/browser/resources/settings/people_page/settings_setup_pin_keyboard.html
[add] https://crrev.com/1e8e715a9b15ccd9ac32eb112733f2791434ca65/chrome/browser/resources/settings/people_page/settings_setup_pin_keyboard.js
[modify] https://crrev.com/1e8e715a9b15ccd9ac32eb112733f2791434ca65/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/1e8e715a9b15ccd9ac32eb112733f2791434ca65/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/1e8e715a9b15ccd9ac32eb112733f2791434ca65/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/1e8e715a9b15ccd9ac32eb112733f2791434ca65/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Comment 10 by elizabethchiu@chromium.org, Sep 4 

Screenshot of how the card looks on the screen.
02A-showoff-app-start-screen.png
373 KB View Download

Comment 11 by elizabethchiu@chromium.org, Sep 4 

Attached is the confirm password screen and PIN set up screens.
Please note that "Learn more" is removed, same as the settings page.

Updated spec: https://drive.google.com/open?id=18KjCK94LtzfN0zkfTR3K73gz1kEmg_4m
07A- PIN set up.png
130 KB View Download
07A- Confirm password.png
130 KB View Download

Comment 12 by alemate@chromium.org, Sep 5 

Elizabeth, what is the expected error message we should display if password is incorrect?

What is the expected behavior if user clicks on "Forgot password"?

Comment 13 by zalcorn@chromium.org, Sep 7 

Error message should be same as Settings: "Invalid password"

Forgot password should be removed as well, there's no place for that to go.
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f4542f7e24b673c3043a85f495a646d1e8f14da

commit 5f4542f7e24b673c3043a85f495a646d1e8f14da
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sat Sep 08 01:31:41 2018

Chrome OS Settings: Move set-pin keyboard element to cr_components.

This CL extracts PIN-setting element into cr_components so that it could be
integrated into another WebUI.

Bug:  852553 
Change-Id: Ia7e08465fbaf5d457f1d804dbfc2dbba2e6a5071
Reviewed-on: https://chromium-review.googlesource.com/1212404
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589748}
[modify] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/chrome/browser/resources/settings/people_page/BUILD.gn
[modify] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/chrome/browser/resources/settings/people_page/lock_screen.html
[delete] https://crrev.com/274cc4cc8cf5be0ef72c1ebc24bbf02838ebedff/chrome/browser/resources/settings/people_page/lock_screen_constants.html
[modify] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/chrome/browser/resources/settings/people_page/lock_screen_password_prompt_dialog.html
[modify] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
[modify] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/ui/webui/resources/cr_components/chromeos/quick_unlock/BUILD.gn
[add] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/ui/webui/resources/cr_components/chromeos/quick_unlock/lock_screen_constants.html
[rename] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/ui/webui/resources/cr_components/chromeos/quick_unlock/lock_screen_constants.js
[rename] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.html
[rename] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js
[modify] https://crrev.com/5f4542f7e24b673c3043a85f495a646d1e8f14da/ui/webui/resources/cr_components/cr_components_resources.grdp
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee7afcce1d2b5c96c5eb17d4cf4d4285209fb6b9

commit ee7afcce1d2b5c96c5eb17d4cf4d4285209fb6b9
Author: Alexander Alekseev <alemate@chromium.org>
Date: Thu Oct 11 23:37:13 2018

Chrome OS quick unlock: Add support for First run UI


This CL adds required changes to quick_unlock code to allow further integration
into First run UI.

Bug:  852553 
Change-Id: Ica3a431c1c24d3f6c658695c8c333a11f528245a
Reviewed-on: https://chromium-review.googlesource.com/c/1247261
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599011}
[modify] https://crrev.com/ee7afcce1d2b5c96c5eb17d4cf4d4285209fb6b9/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
[modify] https://crrev.com/ee7afcce1d2b5c96c5eb17d4cf4d4285209fb6b9/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/ee7afcce1d2b5c96c5eb17d4cf4d4285209fb6b9/ui/login/account_picker/md_user_pod_template.html
[modify] https://crrev.com/ee7afcce1d2b5c96c5eb17d4cf4d4285209fb6b9/ui/login/account_picker/user_pod_template.html
[modify] https://crrev.com/ee7afcce1d2b5c96c5eb17d4cf4d4285209fb6b9/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
[modify] https://crrev.com/ee7afcce1d2b5c96c5eb17d4cf4d4285209fb6b9/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js
[modify] https://crrev.com/ee7afcce1d2b5c96c5eb17d4cf4d4285209fb6b9/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.html
[modify] https://crrev.com/ee7afcce1d2b5c96c5eb17d4cf4d4285209fb6b9/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f479db8f992be027ddc9b715919df65ad4e40bb6

commit f479db8f992be027ddc9b715919df65ad4e40bb6
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Oct 12 07:43:54 2018

Chrome OS: Integrate PIN setup into Discover UI

Bug:  852553 
Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae
Reviewed-on: https://chromium-review.googlesource.com/c/1249496
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599130}
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP.png.sha1
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_DONE.png.sha1
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_SUBTITLE.png.sha1
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_TITLE.png.sha1
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SUBTITLE3.png.sha1
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/discover_app.html
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/discover_app.js
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/discover_components.html
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/discover_components.js
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/discover_module_behavior.js
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/discover_ui.html
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/discover_ui.js
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/discover_welcome.css
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.css
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_1x.svg
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_2x.svg
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/resources/chromeos/login/screen_discover.html
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/discover_module.h
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.cc
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.h
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.cc
[add] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.h
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.cc
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.h
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.cc
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.h
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.cc
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.h
[modify] https://crrev.com/f479db8f992be027ddc9b715919df65ad4e40bb6/chrome/common/extensions/api/_api_features.json
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a

commit 761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Oct 12 08:08:38 2018

Chrome OS: Integrate Discover PIN setup into First run UI.

Bug:  852553 
Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525
Reviewed-on: https://chromium-review.googlesource.com/c/1250136
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599137}
[modify] https://crrev.com/761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
[modify] https://crrev.com/761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h
[modify] https://crrev.com/761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a/chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
[modify] https://crrev.com/761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a/chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
[modify] https://crrev.com/761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a/chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
[modify] https://crrev.com/761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a/chrome/browser/ui/webui/chromeos/login/discover/discover_ui.cc

Comment 18 by rkc@google.com, Oct 17

Labels: -M-70 M-72

Comment 19 by alemate@chromium.org, Oct 20

Labels: -M-72 Merge-Request-71 M-71
Status: Fixed (was: Assigned)

Comment 20 by alemate@chromium.org, Oct 20 

Requesting merge for f479db8f992be027ddc9b715919df65ad4e40bb6 and I215392305eee1555441d5dd66f0bb2908d0f5525 .
Project Member

Comment 21 by sheriffbot@chromium.org, Oct 20

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: There is .grd file changes and we are only 44 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 22 by kbleicher@google.com, Oct 20 

This change impacts a number of areas.  Can you add context to verify all is working and low risk?  Thanks

Comment 23 by alemate@chromium.org, Oct 20 

>Re #22:

These two CLs that are needed for "PIN setup while creating new users" feature.
They've been in canary for more than a week now. At least 4 other merge-approved issues ( issue 896645 , issue 890685,  issue 884667 ,  issue 852553 ) depend on this.

So these two should be low risk, as this has been checked a lot this week.

Comment 24 by kbleicher@google.com, Oct 22

Labels: -Merge-Review-71 Merge-Approved-71
Thanks for the details...

Approving merge to M71 Chrome OS.
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 22

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a5118af03c97cd523b8341e0c20f87d38e8b74

commit 33a5118af03c97cd523b8341e0c20f87d38e8b74
Author: Alexander Alekseev <alemate@chromium.org>
Date: Mon Oct 22 05:06:00 2018

Chrome OS: Integrate PIN setup into Discover UI

TBR=alemate@chromium.org

(cherry picked from commit f479db8f992be027ddc9b715919df65ad4e40bb6)

Bug:  852553 
Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae
Reviewed-on: https://chromium-review.googlesource.com/c/1249496
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599130}
Reviewed-on: https://chromium-review.googlesource.com/c/1293180
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#197}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP.png.sha1
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_DONE.png.sha1
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_SUBTITLE.png.sha1
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_TITLE.png.sha1
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SUBTITLE3.png.sha1
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/discover_app.html
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/discover_app.js
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/discover_components.html
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/discover_components.js
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/discover_module_behavior.js
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/discover_ui.html
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/discover_ui.js
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/discover_welcome.css
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.css
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_1x.svg
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_2x.svg
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/resources/chromeos/login/screen_discover.html
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/discover_module.h
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.cc
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.h
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.cc
[add] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.h
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.cc
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.h
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.cc
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.h
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.cc
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.h
[modify] https://crrev.com/33a5118af03c97cd523b8341e0c20f87d38e8b74/chrome/common/extensions/api/_api_features.json
Project Member

Comment 26 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0

commit aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0
Author: Alexander Alekseev <alemate@chromium.org>
Date: Mon Oct 22 05:06:59 2018

Chrome OS: Integrate Discover PIN setup into First run UI.

TBR=alemate@chromium.org

(cherry picked from commit 761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a)

Bug:  852553 
Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525
Reviewed-on: https://chromium-review.googlesource.com/c/1250136
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599137}
Reviewed-on: https://chromium-review.googlesource.com/c/1293181
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#198}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
[modify] https://crrev.com/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h
[modify] https://crrev.com/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0/chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
[modify] https://crrev.com/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0/chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
[modify] https://crrev.com/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0/chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
[modify] https://crrev.com/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0/chrome/browser/ui/webui/chromeos/login/discover/discover_ui.cc
Project Member

Comment 27 by cr-audit...@appspot.gserviceaccount.com, Oct 23

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/33a5118af03c97cd523b8341e0c20f87d38e8b74

Commit: 33a5118af03c97cd523b8341e0c20f87d38e8b74
Author: alemate@chromium.org
Commiter: alemate@chromium.org
Date: 2018-10-22 05:06:00 +0000 UTC

Chrome OS: Integrate PIN setup into Discover UI

TBR=alemate@chromium.org

(cherry picked from commit f479db8f992be027ddc9b715919df65ad4e40bb6)

Bug:  852553 
Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae
Reviewed-on: https://chromium-review.googlesource.com/c/1249496
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599130}
Reviewed-on: https://chromium-review.googlesource.com/c/1293180
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#197}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 28 by cr-audit...@appspot.gserviceaccount.com, Oct 23 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0

Commit: aad6618a2a6aa99ca99572cbcf2eb661ec3c70f0
Author: alemate@chromium.org
Commiter: alemate@chromium.org
Date: 2018-10-22 05:06:59 +0000 UTC

Chrome OS: Integrate Discover PIN setup into First run UI.

TBR=alemate@chromium.org

(cherry picked from commit 761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a)

Bug:  852553 
Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525
Reviewed-on: https://chromium-review.googlesource.com/c/1250136
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599137}
Reviewed-on: https://chromium-review.googlesource.com/c/1293181
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#198}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
►

Sign in to add a comment