New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852551 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 828996


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Updates - OOBE Update

Project Member Reported by zalcorn@chromium.org, Jun 13 2018

Issue description

Tracking updates to "Checking for update" OOBE screens.
Elizabeth, please update with spec when ready.
 
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41f1a59750d0348fbc5f84dedfb7f596fea0ea35

commit 41f1a59750d0348fbc5f84dedfb7f596fea0ea35
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sun Aug 12 10:40:00 2018

Chrome OS OOBE: make icons of the Back and Next button use button color.

This Cl enables "Back" and "Forward" icons to follow the color style of the
button.

Bug:  852551 
Change-Id: I75cec2058d7e330db5c7b5d226f47cd0f9f54571
Reviewed-on: https://chromium-review.googlesource.com/1171956
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582473}
[modify] https://crrev.com/41f1a59750d0348fbc5f84dedfb7f596fea0ea35/chrome/browser/resources/chromeos/login/oobe_buttons.html

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d005963ac26197e35f709a028d0aeb06c3fd573

commit 5d005963ac26197e35f709a028d0aeb06c3fd573
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sun Aug 12 10:50:01 2018

Chrome OS OOBE: Make dialog icons match button colors.

Bug:  852551 
Change-Id: Ie7b3a95dee5ed135661f47f765e0fb37adb84273
Reviewed-on: https://chromium-review.googlesource.com/1171958
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582474}
[modify] https://crrev.com/5d005963ac26197e35f709a028d0aeb06c3fd573/chrome/browser/resources/chromeos/login/oobe_dialog.css

Status: Fixed (was: Started)
Labels: Merge-Request-69
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 15

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
M69 merge approved.
Labels: -Merge-Review-69 Merge-Approved-69
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 15

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a37e1f97ea38b1843e669af9e639dd4f0ddd97cc

commit a37e1f97ea38b1843e669af9e639dd4f0ddd97cc
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 15 18:52:27 2018

Chrome OS OOBE: make icons of the Back and Next button use button color.

This Cl enables "Back" and "Forward" icons to follow the color style of the
button.

TBR=alemate@chromium.org

(cherry picked from commit 41f1a59750d0348fbc5f84dedfb7f596fea0ea35)

Bug:  852551 
Change-Id: I75cec2058d7e330db5c7b5d226f47cd0f9f54571
Reviewed-on: https://chromium-review.googlesource.com/1171956
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#582473}
Reviewed-on: https://chromium-review.googlesource.com/1176210
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#651}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/a37e1f97ea38b1843e669af9e639dd4f0ddd97cc/chrome/browser/resources/chromeos/login/oobe_buttons.html

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4efc8b08bf32f90602de495be59c0901eda0955

commit e4efc8b08bf32f90602de495be59c0901eda0955
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 15 18:53:20 2018

Chrome OS OOBE: Make dialog icons match button colors.

TBR=alemate@chromium.org

(cherry picked from commit 5d005963ac26197e35f709a028d0aeb06c3fd573)

Bug:  852551 
Change-Id: Ie7b3a95dee5ed135661f47f765e0fb37adb84273
Reviewed-on: https://chromium-review.googlesource.com/1171958
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#582474}
Reviewed-on: https://chromium-review.googlesource.com/1176211
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#652}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/e4efc8b08bf32f90602de495be59c0901eda0955/chrome/browser/resources/chromeos/login/oobe_dialog.css

Sign in to add a comment