New issue
Advanced search Search tips

Issue 852545 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove maxWidth in BoundedLinearLayout

Project Member Reported by xingliu@chromium.org, Jun 13 2018

Issue description

Chrome Version: 69.*

We have introduced maxWidthLandscape and maxWidthPortrait, so maxWidth
can be removed, because:

1. Functionality overlap, and unnecessary complexity when using this
widget.

2. maxWidthLandscape/maxWidthPortrait can force people to notice
the difference between landscape and portrait views.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31ea1563ab1ddce15e6505c20ceabfe4da64ac89

commit 31ea1563ab1ddce15e6505c20ceabfe4da64ac89
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Jun 18 18:21:15 2018

Android UI: remove maxWidth in BoundedLinearLayout.

We have introduced maxWidthLandscape and maxWidthPortrait, so maxWidth
can be removed, because:

1. Functionality overlap, and unnecessary complexity when using this
widget.

2. maxWidthLandscape/maxWidthPortrait can force people to notice
the difference between landscape and portrait views.

TBR=twellington@chromium.org

Bug:  852545 
Change-Id: I3532701b3886969d8232a348ae36738ea3dc4259
Reviewed-on: https://chromium-review.googlesource.com/1099774
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568080}
[modify] https://crrev.com/31ea1563ab1ddce15e6505c20ceabfe4da64ac89/chrome/android/java/res/layout/payment_request.xml
[modify] https://crrev.com/31ea1563ab1ddce15e6505c20ceabfe4da64ac89/chrome/android/java/res/layout/payment_request_error.xml
[modify] https://crrev.com/31ea1563ab1ddce15e6505c20ceabfe4da64ac89/chrome/android/java/res/layout/promo_dialog_layout.xml
[modify] https://crrev.com/31ea1563ab1ddce15e6505c20ceabfe4da64ac89/chrome/android/java/res/layout/updating_gms_progress_view.xml
[modify] https://crrev.com/31ea1563ab1ddce15e6505c20ceabfe4da64ac89/chrome/android/java/src/org/chromium/chrome/browser/widget/BoundedLinearLayout.java

Status: Fixed (was: Assigned)

Sign in to add a comment