New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 852541 link

Starred by 2 users
Status: Fixed
Owner:
w...@chromium.org
Closed: Aug 1
Cc:
sergeyu@chromium.org
█ kulakowski@chromium.org
kmarshall@chromium.org
█ jam...@chromium.org
mark@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Migrate from custom ScopedZxHandle to using libzx move-only wrappers

Project Member Reported by w...@chromium.org, Jun 13 2018 
The Fuchsia SDK now provides a set of move-only containers for the different Zircon kernel object types, providing the same lifetime management as ScopedZxHandle, with the added benefit of type-safety.

We are also starting to land FIDL integrations, for which the generated C++ uses the libzx wrapper types, so we end up with increasing amounts of boilerplate translating between the libzx and Chromium wrappers.  This is fragile both in terms of type-safety and correctness of lifetime management, since we're often forced to release() and re-adopt handles.

We should work through the existing ScopedZxHandle users and migrate them to libzx containers.

Comment 1 by w...@chromium.org, Jun 13 2018

Cc: sergeyu@chromium.org

Comment 2 by w...@chromium.org, Jun 13 2018 

/me is going to start migrating //base to use libzx, starting with the things that don't have ScopedZxHandle in their public interface, where feasible.

Comment 3 by w...@chromium.org, Jun 14 2018

Owner: w...@chromium.org
Status: Started (was: Untriaged)
wez -> Adding temporary ScopedZxHandle -> zx::handle shim.
kmarshall -> Will migrate ServiceDirectory and ComponentContext next.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514

commit e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514
Author: Wez <wez@chromium.org>
Date: Thu Jun 14 19:52:21 2018

Make base::ScopedZxHandle a zx::handle.

- Add the ScopedZxHandle APIs to the base zx::handle.
- Add missing includes.

This allows ScopedZxHandle to be removed incrementally from call-sites.

Bug:  852541 
Change-Id: Idc452a450ce2bbe1266e9e0ee266115e2ea38f97
Reviewed-on: https://chromium-review.googlesource.com/1100132
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567382}
[modify] https://crrev.com/e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514/base/BUILD.gn
[modify] https://crrev.com/e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514/base/fuchsia/scoped_zx_handle.h
[modify] https://crrev.com/e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514/base/memory/shared_memory_fuchsia.cc
[modify] https://crrev.com/e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514/content/browser/browser_main_loop.cc
[modify] https://crrev.com/e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514/ipc/handle_attachment_fuchsia.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/089bc8ad95d8121ab8b969a803f3843b7a07d1e3

commit 089bc8ad95d8121ab8b969a803f3843b7a07d1e3
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Jun 14 20:55:34 2018

Fuchsia: Migrate ServicesDirectory from ScopedZxHandle to zx::channel.

Part of a larger effort to use Fuchsia native zx::channel objects
for smoother integration with FIDL types and API calls.


Bug:  852541 
Change-Id: I095e17b98a334964e72cbb97dc7ea4dbded67ec8
Reviewed-on: https://chromium-review.googlesource.com/1101413
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567405}
[modify] https://crrev.com/089bc8ad95d8121ab8b969a803f3843b7a07d1e3/base/fuchsia/scoped_service_binding.h
[modify] https://crrev.com/089bc8ad95d8121ab8b969a803f3843b7a07d1e3/base/fuchsia/services_directory.cc
[modify] https://crrev.com/089bc8ad95d8121ab8b969a803f3843b7a07d1e3/base/fuchsia/services_directory.h
[modify] https://crrev.com/089bc8ad95d8121ab8b969a803f3843b7a07d1e3/base/fuchsia/services_directory_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e0857a0db62e3e9a317f7139c5482cd205853d7

commit 2e0857a0db62e3e9a317f7139c5482cd205853d7
Author: François Doray <fdoray@chromium.org>
Date: Thu Jun 14 21:05:19 2018

Revert "Make base::ScopedZxHandle a zx::handle."

This reverts commit e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514.

Reason for revert: Compile failure  https://crbug.com/852958 

Original change's description:
> Make base::ScopedZxHandle a zx::handle.
> 
> - Add the ScopedZxHandle APIs to the base zx::handle.
> - Add missing includes.
> 
> This allows ScopedZxHandle to be removed incrementally from call-sites.
> 
> Bug:  852541 
> Change-Id: Idc452a450ce2bbe1266e9e0ee266115e2ea38f97
> Reviewed-on: https://chromium-review.googlesource.com/1100132
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567382}

TBR=wez@chromium.org,gab@chromium.org,rockot@chromium.org,kmarshall@chromium.org

Change-Id: I44b3be92d12a29a972ca3c59d3356f97b21292f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  852541 
Reviewed-on: https://chromium-review.googlesource.com/1101777
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567416}
[modify] https://crrev.com/2e0857a0db62e3e9a317f7139c5482cd205853d7/base/BUILD.gn
[modify] https://crrev.com/2e0857a0db62e3e9a317f7139c5482cd205853d7/base/fuchsia/scoped_zx_handle.h
[modify] https://crrev.com/2e0857a0db62e3e9a317f7139c5482cd205853d7/base/memory/shared_memory_fuchsia.cc
[modify] https://crrev.com/2e0857a0db62e3e9a317f7139c5482cd205853d7/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/2e0857a0db62e3e9a317f7139c5482cd205853d7/content/browser/browser_main_loop.cc
[modify] https://crrev.com/2e0857a0db62e3e9a317f7139c5482cd205853d7/ipc/handle_attachment_fuchsia.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cb38ff4fe4871cbf740e731ae832345b428783a

commit 8cb38ff4fe4871cbf740e731ae832345b428783a
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Jun 14 22:53:42 2018

Fuchsia: Migrate ComponentContext from ScopedZxHandle to zx::channel.

Part of a larger effort to use Fuchsia native zx::channel objects
for smoother integration with FIDL types and API calls.


Bug:  852541 
Change-Id: I421819558de9a20fe9e5fa24f083b103b46bd654
Reviewed-on: https://chromium-review.googlesource.com/1101461
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567457}
[modify] https://crrev.com/8cb38ff4fe4871cbf740e731ae832345b428783a/base/fuchsia/component_context.cc
[modify] https://crrev.com/8cb38ff4fe4871cbf740e731ae832345b428783a/base/fuchsia/component_context.h
[modify] https://crrev.com/8cb38ff4fe4871cbf740e731ae832345b428783a/base/fuchsia/services_directory_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6

commit bfbca08b392dbf8c0be1f4fc487534e4f2993ec6
Author: Wez <wez@chromium.org>
Date: Fri Jun 15 02:52:07 2018

Reland "Make base::ScopedZxHandle a zx::handle."

This is a reland of e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514

Original change's description:
> Make base::ScopedZxHandle a zx::handle.
>
> - Add the ScopedZxHandle APIs to the base zx::handle.
> - Add missing includes.
>
> This allows ScopedZxHandle to be removed incrementally from call-sites.
>
> Bug:  852541 
> Change-Id: Idc452a450ce2bbe1266e9e0ee266115e2ea38f97
> Reviewed-on: https://chromium-review.googlesource.com/1100132
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567382}

TBR: gab, rockot, kmarshall
Bug:  852541 ,  852958 
Change-Id: I66df191da2449007a154595255efc01ac732d110
Reviewed-on: https://chromium-review.googlesource.com/1101742
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567526}
[modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/base/BUILD.gn
[modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/base/fuchsia/scoped_zx_handle.h
[modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/base/memory/shared_memory_fuchsia.cc
[modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/content/browser/browser_main_loop.cc
[modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/ipc/handle_attachment_fuchsia.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad910ae2f13f930e5db7dcb7a28fc1ab215513eb

commit ad910ae2f13f930e5db7dcb7a28fc1ab215513eb
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Sat Jun 16 05:40:53 2018

Fuchsia: Enable mounting handles as dirs on child processess.

This functionality will be used by the ContextProvider service to
bind an arbitrary, client-supplied directory handle to the "/data"
directory of the child Context processes.

* Adds a helper function for extracting file handles from File objects.
* Adds unit tests.
* Migrates some uses of ScopedZxHandle to zx::handle.

Bug:  850743 ,  852541 
Change-Id: Iada1775485745124822e32b9ac81aefaff6b9059
Reviewed-on: https://chromium-review.googlesource.com/1091803
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567880}
[modify] https://crrev.com/ad910ae2f13f930e5db7dcb7a28fc1ab215513eb/base/BUILD.gn
[add] https://crrev.com/ad910ae2f13f930e5db7dcb7a28fc1ab215513eb/base/fuchsia/file_utils.cc
[add] https://crrev.com/ad910ae2f13f930e5db7dcb7a28fc1ab215513eb/base/fuchsia/file_utils.h
[modify] https://crrev.com/ad910ae2f13f930e5db7dcb7a28fc1ab215513eb/base/process/launch.h
[modify] https://crrev.com/ad910ae2f13f930e5db7dcb7a28fc1ab215513eb/base/process/launch_fuchsia.cc
[modify] https://crrev.com/ad910ae2f13f930e5db7dcb7a28fc1ab215513eb/base/process/process_util_unittest.cc
[modify] https://crrev.com/ad910ae2f13f930e5db7dcb7a28fc1ab215513eb/content/common/sandbox_policy_fuchsia.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82017b0e57f2d48d0684c3a5903e42335be56d30

commit 82017b0e57f2d48d0684c3a5903e42335be56d30
Author: Wez <wez@chromium.org>
Date: Mon Jul 09 17:21:10 2018

Migrate from ScopedZxHandle & zx_handle_t to zx::job and unowned_job.

This migrates all use of Zircon job objects to use the libzx containers,
with the exception of Crashpad, which will be updated separately.

Bug:  852541 
Change-Id: Id342092e38e49d60f930b67e1fe9440e1c479c47
Reviewed-on: https://chromium-review.googlesource.com/1127492
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573348}
[modify] https://crrev.com/82017b0e57f2d48d0684c3a5903e42335be56d30/base/fuchsia/default_job.cc
[modify] https://crrev.com/82017b0e57f2d48d0684c3a5903e42335be56d30/base/fuchsia/default_job.h
[modify] https://crrev.com/82017b0e57f2d48d0684c3a5903e42335be56d30/base/process/launch_fuchsia.cc
[modify] https://crrev.com/82017b0e57f2d48d0684c3a5903e42335be56d30/base/process/process_fuchsia.cc
[modify] https://crrev.com/82017b0e57f2d48d0684c3a5903e42335be56d30/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/82017b0e57f2d48d0684c3a5903e42335be56d30/content/browser/browser_main_loop.cc
[modify] https://crrev.com/82017b0e57f2d48d0684c3a5903e42335be56d30/webrunner/service/context_provider/context_provider_impl.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/157707d63f0cd8ea00723bf7bac6a0a49191831b

commit 157707d63f0cd8ea00723bf7bac6a0a49191831b
Author: Wez <wez@chromium.org>
Date: Tue Jul 10 22:48:47 2018

Migrate Chromium callers from ScopedZxHandle to libzx containers.

- Migrate Chromium call-sites to appropriate libzx containers.
- Mojo / IPC callers still often need to use generic zx::handle.
- Redefine ScopedZxHandle as a typedef to zx::handle, for Crashpad code
  to build against.

Bug:  852541 
Change-Id: Idc317a91e718c680de7d01e53c92e83b5950b146
Reviewed-on: https://chromium-review.googlesource.com/1130540
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573960}
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/BUILD.gn
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/fuchsia/async_dispatcher.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/fuchsia/async_dispatcher.h
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/fuchsia/async_dispatcher_unittest.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/fuchsia/component_context.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/fuchsia/fidl_interface_request.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/fuchsia/fidl_interface_request.h
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/fuchsia/filtered_service_directory.cc
[delete] https://crrev.com/c051f0ac232f997f6c26744303c13796af793ede/base/fuchsia/scoped_zx_handle.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/fuchsia/scoped_zx_handle.h
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/logging_unittest.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/memory/platform_shared_memory_region.h
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/memory/platform_shared_memory_region_fuchsia.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/memory/shared_memory_fuchsia.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/memory/shared_memory_handle.h
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/memory/shared_memory_unittest.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/native_library_fuchsia.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/process/launch_fuchsia.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/process/process.h
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/base/process/process_fuchsia.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/ipc/handle_attachment_fuchsia.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/ipc/handle_attachment_fuchsia.h
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/ipc/ipc_message_attachment.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/ipc/ipc_message_utils.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/mojo/core/channel_fuchsia.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/mojo/core/platform_handle_utils.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/mojo/public/cpp/platform/BUILD.gn
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/mojo/public/cpp/platform/platform_channel.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/mojo/public/cpp/platform/platform_handle.cc
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/mojo/public/cpp/platform/platform_handle.h
[modify] https://crrev.com/157707d63f0cd8ea00723bf7bac6a0a49191831b/net/base/network_interfaces_fuchsia.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63c0b268adf941fcf0beb139fdcec4d58011dda9

commit 63c0b268adf941fcf0beb139fdcec4d58011dda9
Author: Wez <wez@chromium.org>
Date: Wed Jul 11 04:30:36 2018

Reference result if DCHECKs are off.

Replace call to ZX_DLOG_IF(), which won't reference |result| in builds
in which DCHECKs are disabled.

Bug:  852541 
TBR: rockot
Change-Id: I0b8ff421a690691277a4f73730f4c756faf5a17e
Reviewed-on: https://chromium-review.googlesource.com/1132488
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574070}
[modify] https://crrev.com/63c0b268adf941fcf0beb139fdcec4d58011dda9/mojo/public/cpp/platform/platform_handle.cc

Comment 13 by w...@chromium.org, Jul 19

Cc: mark@chromium.org
Not-to-self: Remaining cleanup work is in Crashpad, which requires making 'zx' available in the non-Chromium build in some way, e.g. by bundling it into mini_chromium.

Comment 14 by w...@chromium.org, Jul 27

Labels: -M-69 M-70
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/bc50af15a28d5995fa2b3f4770dc05828263ae52

commit bc50af15a28d5995fa2b3f4770dc05828263ae52
Author: Wez <wez@chromium.org>
Date: Wed Aug 01 17:38:19 2018

Migrate from ScopedZxHandle to libzx containers.

Bug:  chromium:852541 
Change-Id: Ie05c70f249e6f843183a02ec61fd09f6a0607598
Reviewed-on: https://chromium-review.googlesource.com/1148923
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Wez <wez@chromium.org>

[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/client/BUILD.gn
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/client/crashpad_client_fuchsia.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/handler/BUILD.gn
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/handler/fuchsia/crash_report_exception_handler.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/handler/fuchsia/crash_report_exception_handler.h
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/handler/fuchsia/exception_handler_server.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/handler/fuchsia/exception_handler_server.h
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/handler/handler_main.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/snapshot/crashpad_info_client_options_test.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/snapshot/elf/elf_image_reader_test.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/snapshot/fuchsia/memory_map_fuchsia.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/snapshot/fuchsia/memory_map_fuchsia.h
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/snapshot/fuchsia/process_reader_fuchsia.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/snapshot/fuchsia/process_reader_fuchsia.h
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/snapshot/fuchsia/process_reader_fuchsia_test.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/snapshot/fuchsia/process_snapshot_fuchsia.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/snapshot/fuchsia/process_snapshot_fuchsia.h
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/test/BUILD.gn
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/test/multiprocess_exec_fuchsia.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/test/process_type.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/test/process_type.h
[add] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/third_party/fuchsia/BUILD.gn
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/tools/generate_dump.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/util/BUILD.gn
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/util/fuchsia/koid_utilities.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/util/fuchsia/koid_utilities.h
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/util/fuchsia/scoped_task_suspend.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/util/fuchsia/scoped_task_suspend.h
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/util/process/process_memory_fuchsia.cc
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/util/process/process_memory_fuchsia.h
[modify] https://crrev.com/bc50af15a28d5995fa2b3f4770dc05828263ae52/util/process/process_memory_range_test.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/804a694c44d77dfb810ae6d2cf765f66a184e7cb

commit 804a694c44d77dfb810ae6d2cf765f66a184e7cb
Author: Wez <wez@chromium.org>
Date: Wed Aug 01 20:59:04 2018

Remove unused base::ScopedZxHandle.

Bug:  852541 
Change-Id: Ifb5c2cc57b9f4cb7e01183c1ed02fc25005fa32c
Reviewed-on: https://chromium-review.googlesource.com/1159162
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579936}
[modify] https://crrev.com/804a694c44d77dfb810ae6d2cf765f66a184e7cb/base/BUILD.gn
[delete] https://crrev.com/7eab3260e95cf0a8fd9e965ddaad474a9fb908a3/base/fuchsia/scoped_zx_handle.h
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/mini_chromium/+/8d641e30a8b12088649606b912c2bc4947419ccc

commit 8d641e30a8b12088649606b912c2bc4947419ccc
Author: Wez <wez@chromium.org>
Date: Wed Aug 01 21:33:42 2018

Remove unused base::ScopedZxHandle.

Bug:  chromium:852541 
Change-Id: I60270c548ab3bd6f30c44a8e6a94cf3119eca7c4
Reviewed-on: https://chromium-review.googlesource.com/1159103
Reviewed-by: Mark Mentovai <mark@chromium.org>

[delete] https://crrev.com/dd77be1abce5e420154b8b4136b67546dbc9ba34/base/fuchsia/scoped_zx_handle.h

Comment 18 by w...@chromium.org, Aug 1

Status: Fixed (was: Started)
►

Sign in to add a comment