New issue
Advanced search Search tips

Issue 852536 link

Starred by 1 user
Status: Assigned
Owner:
sdy@chromium.org
Cc:
karandeepb@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
M-X



Sign in to add a comment

SelectFileDialogMacTest.MultipleDialogs fails on Mac 10.10

Project Member Reported by jbudorick@chromium.org, Jun 13 2018 
[ RUN      ] SelectFileDialogMacTest.MultipleDialogs
../../ui/shell_dialogs/select_file_dialog_mac_unittest.mm:435: Failure
Expected equality of these values:
  0lu
    Which is: 0
  GetActivePanelCount()
    Which is: 1
Stack trace:
0   shell_dialogs_unittests             0x0000000106bd446b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   shell_dialogs_unittests             0x0000000106bd3e29 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   shell_dialogs_unittests             0x00000001069a9c15 ui::test::SelectFileDialogMacTest_MultipleDialogs_Test::TestBody() + 1365
[  FAILED  ] SelectFileDialogMacTest.MultipleDialogs (1917 ms)

disabling on mac
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/125a66ada730475c005b9143088f7cb3927e623e

commit 125a66ada730475c005b9143088f7cb3927e623e
Author: John Budorick <jbudorick@chromium.org>
Date: Wed Jun 13 22:54:41 2018

Disable SelectFileDialogMacTest.MultipleDialogs.

Failing on Mac10.10.

TBR=thakis@chromium.org

Change-Id: I906d7ffe323f10630a21ec93f953b40c33fb0182
Bug: 852536
Reviewed-on: https://chromium-review.googlesource.com/1099715
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567034}
[modify] https://crrev.com/125a66ada730475c005b9143088f7cb3927e623e/ui/shell_dialogs/select_file_dialog_mac_unittest.mm

Comment 2 by thakis@chromium.org, Jun 14 2018

Cc: karandeepb@chromium.org
(Background for triage: We used to not run these tests at all until I added them in https://chromium-review.googlesource.com/1098621 yesterday, so it's possible this never worked on 10.10, or that it's a regression since the test was added -- we don't know.)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54b4f8dc66a7aa94f9f5e714c8df810a46cef5ef

commit 54b4f8dc66a7aa94f9f5e714c8df810a46cef5ef
Author: Nico Weber <thakis@chromium.org>
Date: Thu Jun 14 14:04:38 2018

Disable SelectFileDialogMacTest.MultipleDialogs only on macOS 10.10.

It passes on other versions, so keep running the test there.

Follow-up to https://chromium-review.googlesource.com/c/1099715/ and
https://chromium-review.googlesource.com/1098621

Bug: 852536
Change-Id: I42ffe80b4876ccc95be5f45d431d6c441fe11e73
Reviewed-on: https://chromium-review.googlesource.com/1100902
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567252}
[modify] https://crrev.com/54b4f8dc66a7aa94f9f5e714c8df810a46cef5ef/ui/shell_dialogs/select_file_dialog_mac_unittest.mm

Comment 4 by ellyjo...@chromium.org, Jun 15 2018

Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)
mac triage: thakis@, can you take a look at this?

Comment 5 by thakis@chromium.org, Jun 15 2018

Status: utnr (was: Assigned)
No.

Comment 6 by thakis@chromium.org, Jun 15 2018

Owner: ----
Status: Untriaged (was: utnr)

Comment 7 by thakis@chromium.org, Jun 15 2018 

(Don't have a 10.10 box, haven't done mac ui work in years, busy with other things, etc)

Comment 8 by ellyjo...@chromium.org, Jun 15 2018

Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
Copy :)

Here you go sdy@!

Comment 9 by sdy@chromium.org, Aug 14

Labels: M-X
►

Sign in to add a comment