New issue
Advanced search Search tips

Issue 852531 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 850728



Sign in to add a comment

Fix viz_unittests when building with Vulkan support

Project Member Reported by cblume@chromium.org, Jun 13 2018

Issue description

viz_unittests currently do not build with Vulkan support enabled.

One of the failing Viz unittests is GL related and can just NOTREACHED() I believe. The other tests overlays and may want to contain a proper Vulkan code path. However, the immediate goal is to just get it building so we can enable Vulkan builds by default. I think it is okay to implement the proper Vulkan code path later.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39a790e807c56735b1c77221c1b33f468a6caa9d

commit 39a790e807c56735b1c77221c1b33f468a6caa9d
Author: Chris Blume <cblume@chromium.org>
Date: Wed Jun 13 22:14:42 2018

Fix viz_unittests to build with Vulkan enabled

viz_unittests currently do not build with Vulkan enabled.
One of the unit tests is GL related and can probably just have a
NOTREACHED().
The other unit test might benefit from a proper Vulkan code path. But
the immediate goal is to just get Vulkan enabled by default quickly. We
can later circle back and add a proper Vulkan code path to the overlay
test if it would be correct.

BUG= 852531 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I02a5bd1224575b452e92e3c147ab0c8d0efef76b
Reviewed-on: https://chromium-review.googlesource.com/1099755
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567014}
[modify] https://crrev.com/39a790e807c56735b1c77221c1b33f468a6caa9d/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/39a790e807c56735b1c77221c1b33f468a6caa9d/components/viz/service/display/overlay_unittest.cc

Comment 2 by cblume@chromium.org, Jun 13 2018

Status: Fixed (was: Assigned)

Sign in to add a comment