New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852529 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 835004



Sign in to add a comment

Different frecency behavior between iOS and Desktop

Project Member Reported by dlkumar@google.com, Jun 13 2018

Issue description

Autofill suggestion order is based on frecency (frequency + recency) algorithm., though the behavior looks different between iOS and Desktop

On iOS - It happens immediately after suggestion is selected. Steps to reproduce this
(1) Add multiple cards to payments/chrome local
(2) Interact with a form to see suggestions, note down the order
(3) Select last card in the order, if "CVC", reject the prompt
(4) You would see next time when interacted that order is changed, so that last chosen card appears first. 

On Desktop. 
Same steps, but original order is preserved. Refreshed page and tried.

Next steps
(Durga/Dennis) - Define the right behavior
(Eng) - Make sure all platforms respect it. 


 

Comment 1 by dlkumar@google.com, Jun 28 2018

Checked on iOS prod and that super dynamic ordering is present on iOS always. 
Owner: mahmadi@chromium.org
Blocking: 835004
Labels: -OS-Android -OS-Windows -Pri-3 M-69 Pri-1
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/230fda928bb5f628824cae695f81e40ee8066c75

commit 230fda928bb5f628824cae695f81e40ee8066c75
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed Jul 18 13:57:02 2018

[AF][IOS] Fixs bug with GPay logo appearing out of order in CC suggestions.

1) Removes the logic to bring the most recently used suggestion to the
   front of the list for consistency with other platforms.
2) Keeps the GPay logo as the first suggestion when "Clear Form" is moved
   the front of the list.

Bug:  852529 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5f214078f2a64507a0c326665d5dce9a2f35d7f4
Reviewed-on: https://chromium-review.googlesource.com/1140900
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576027}
[modify] https://crrev.com/230fda928bb5f628824cae695f81e40ee8066c75/components/autofill/ios/browser/autofill_agent.h
[modify] https://crrev.com/230fda928bb5f628824cae695f81e40ee8066c75/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/230fda928bb5f628824cae695f81e40ee8066c75/components/autofill/ios/browser/autofill_agent_unittests.mm
[modify] https://crrev.com/230fda928bb5f628824cae695f81e40ee8066c75/components/autofill/ios/browser/form_suggestion_provider.h
[modify] https://crrev.com/230fda928bb5f628824cae695f81e40ee8066c75/ios/chrome/browser/autofill/form_suggestion_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment