New issue
Advanced search Search tips

Issue 852528 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Components:
EstimatedDays: 1
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Bug
Proj-XR

Blocking:
issue 864810



Sign in to add a comment

WebXR: Rename XRPresentationFrame to XRFrame

Project Member Reported by bajones@chromium.org, Jun 13 2018

Issue description

See https://github.com/immersive-web/webxr/pull/372

No functionality changes associated with the rename, it's just to clarify that not all uses of the object are presentation-oriented.
 

Comment 1 Deleted

Comment 2 by codei...@gmail.com, Jun 14 2018

If no one is working on this, can I take this issue?
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bc8796c5048e999c2808035102c88082038f871

commit 9bc8796c5048e999c2808035102c88082038f871
Author: codeimpl <codeimpl@gmail.com>
Date: Wed Jun 20 00:07:41 2018

[WebXR] Change from XRPresentationFrame to XRFrame

XRFrame is a more generric name because with the addition of the input API
we're using frames in places where there's no expectation of rendering or
presentation involved[1].

[1] https://github.com/immersive-web/webxr/issues/364

Bug:  852528 
Change-Id: Ie9a325cd626912b09bb2b77fe1b46d29baaef0b8
Reviewed-on: https://chromium-review.googlesource.com/1103426
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568654}
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/WebKit/LayoutTests/external/wpt/interfaces/webxr.idl
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/WebKit/LayoutTests/external/wpt/webxr/interfaces.https-expected.txt
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/WebKit/LayoutTests/external/wpt/webxr/resources/webxr_util.js
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_called.html
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/WebKit/LayoutTests/xr/getDevicePose_oneframeupdate.html
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/WebKit/LayoutTests/xr/xrView_match.html
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/BUILD.gn
[rename] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_frame.cc
[rename] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_frame.h
[rename] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_frame.idl
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_frame_request_callback.idl
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.cc
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.h
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_input_source.h
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_input_source_event.cc
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_input_source_event.h
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_input_source_event.idl
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_input_source_event_init.idl
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_session.h
[modify] https://crrev.com/9bc8796c5048e999c2808035102c88082038f871/third_party/blink/renderer/modules/xr/xr_view.cc

Status: Fixed (was: Available)
Components: Blink>WebXR
Blocking: 864810

Sign in to add a comment