New issue
Advanced search Search tips

Issue 852524 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 16
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-XR

Blocking:
issue 864810



Sign in to add a comment

WebXR: Rename 'exclusive' to 'immersive'

Project Member Reported by bajones@chromium.org, Jun 13 2018

Issue description

The functionality is the same as before, but the name has changed for clarity.
See https://github.com/immersive-web/webxr/pull/371
 
Labels: -Pri-3 Pri-2

Comment 2 by codei...@gmail.com, Jun 14 2018

If no one is working on this, can I take this issue?

Comment 3 by jmedley@google.com, Jun 15 2018

I wish I had caught this before the PR got to Gerrit. This change overloads the umbrella term for the technology. Whatever clarity it brings to the session type is at the expense of clarity when discussing the technology.
Labels: -OS-Android -OS-Windows -Type-Bug Type-Task
Components: Blink>WebXR
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4693397852cf6b02f2223fc12f55d80047d7d9d

commit e4693397852cf6b02f2223fc12f55d80047d7d9d
Author: codeimpl <codeimpl@gmail.com>
Date: Mon Jul 16 18:04:20 2018

[WebXR] Use 'immersive' instead of 'exclusive'

The 'immersive' is more intuitive term than 'exclusive'[1].

[1] https://github.com/immersive-web/webxr/pull/371

Bug:  852524 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If5c5ab6563df40a783f9d346d319dceed1f7cc58
Reviewed-on: https://chromium-review.googlesource.com/1101601
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575344}
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrBrowserTransitionTest.java
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrFeedbackInfoBarTest.java
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrVrInputTest.java
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrVrTransitionTest.java
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/XrTransitionUtils.java
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/browser/vr/service/browser_xr_device.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/browser/vr/service/browser_xr_device.h
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/browser/vr/service/vr_display_host.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/browser/vr/test/vr_xr_browser_test.h
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/browser/vr/test/xr_browser_test.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/browser/vr/webvr_frame_pose_browser_test.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/browser/vr/webvr_transition_browser_test.cc
[rename] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/test_non_immersive_stops_during_immersive.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/test_webxr_capabilities.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/test_webxr_input.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/test_webxr_poses.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/test_webxr_reentry_from_vr_browser.html
[rename] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/test_window_raf_fires_during_non_immersive_session.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/webxr_page_submits_once.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/webxr_test_presentation_locks_focus.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/webxr_test_presentation_promise_rejected_if_don_canceled.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/webxr_test_presentation_promise_unresolved_during_don.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/webxr_test_screen_taps_not_registered.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/webxr_test_window_raf_fires_while_presenting.html
[rename] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/html/webxr_test_window_raf_stops_firing_during_immersive_session.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/chrome/test/data/xr/e2e_test_files/resources/webxr_boilerplate.js
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/device/vr/oculus/oculus_render_loop.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/device/vr/openvr/openvr_render_loop.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/device/vr/orientation/orientation_device.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/device/vr/public/mojom/isolated_xr_service.mojom
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/device/vr/public/mojom/vr_service.mojom
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/device/vr/vr_display_impl_unittest.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/external/wpt/interfaces/webxr.idl
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/external/wpt/webxr/interfaces.https-expected.txt
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/ar_hittest-expected.txt
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/ar_hittest.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/events_session_end.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/events_session_resetpose.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/events_session_select.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/events_session_select_subframe.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_called.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_invalidhandle.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_nolayer.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/exclusive_requestFrame_unregister.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/getDevicePose_oneframeupdate.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/getInputPose_hand.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_no_gesture.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_supported.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_unsupported.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrDevice_supportsSession_exclusive_rejects.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrDevice_supportsSession_exclusive_resolves.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrDevice_supportsSession_non_exclusive.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrFrameOfReference_stage_updates.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrInputSource_add_remove.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrSession_environmentBlendMode.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrSession_exclusive.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrSession_prevent_multiple_exclusive.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrSession_requestFrameOfReference.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrView_match.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrView_oneframeupdate.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrViewport_valid.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_constructor.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_dirty_framebuffer.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_framebuffer_draw.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_framebuffer_scale.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_incompatible_device.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_opaque_framebuffer.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_viewport_scale.html
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/vr/vr_display.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr.h
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr_canvas_input_provider.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr_device.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr_device.h
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr_frame_provider.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr_frame_provider.h
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr_session.h
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr_session.idl
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr_session_creation_options.idl
[modify] https://crrev.com/e4693397852cf6b02f2223fc12f55d80047d7d9d/third_party/blink/renderer/modules/xr/xr_webgl_layer.cc

Status: Fixed (was: Available)
Blocking: 864810

Sign in to add a comment