New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852521 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Extra URL appears in AppleScript Javascript Injection Error

Project Member Reported by spqc...@chromium.org, Jun 13 2018

Issue description

The URL appears twice. Remove the extra URL
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b61296f435cc01fd337a3611a20292facd160cb0

commit b61296f435cc01fd337a3611a20292facd160cb0
Author: spqchan <spqchan@chromium.org>
Date: Thu Jun 14 17:05:15 2018

[Mac] Remove extra URL in AppleScript Javascript Injection Error

Bug:  852521 
Change-Id: Ief55e563304cb2ea8677ef7914e1eb065ea1261a
Reviewed-on: https://chromium-review.googlesource.com/1099733
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567317}
[modify] https://crrev.com/b61296f435cc01fd337a3611a20292facd160cb0/chrome/browser/ui/cocoa/applescript/error_applescript.mm

Labels: Merge-Request-68
Status: Started (was: Assigned)
Merge request for #1. Cl is low risk and tested
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 15 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68 Merge-Approved-68
Approved - branch:3440
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 17 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39977970fd6acdb9a3e79e9b9e6c03526aa0169a

commit 39977970fd6acdb9a3e79e9b9e6c03526aa0169a
Author: spqchan <spqchan@chromium.org>
Date: Sun Jun 17 23:02:57 2018

[Mac] Remove extra URL in AppleScript Javascript Injection Error

(cherry picked from commit b61296f435cc01fd337a3611a20292facd160cb0)

Bug:  852521 
Change-Id: Ief55e563304cb2ea8677ef7914e1eb065ea1261a
Reviewed-on: https://chromium-review.googlesource.com/1099733
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567317}
Reviewed-on: https://chromium-review.googlesource.com/1103840
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#388}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/39977970fd6acdb9a3e79e9b9e6c03526aa0169a/chrome/browser/ui/cocoa/applescript/error_applescript.mm

Status: Fixed (was: Started)

Sign in to add a comment