New issue
Advanced search Search tips

Issue 852520 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Components:
EstimatedDays: 1
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Bug
Proj-XR

Blocking:
issue 864810



Sign in to add a comment

WebXR: Rename XRFrameOfReferenceType enums

Project Member Reported by bajones@chromium.org, Jun 13 2018

Issue description

'headModel' -> 'head-model'
'eyeLevel' -> 'eye-level'

The names of these enums was updated in https://github.com/immersive-web/webxr/pull/370 to conform to web platform prefences.
 
Labels: WebXR-69

Comment 2 by codei...@gmail.com, Jun 14 2018

If no one is working on this, can I take this issue?
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82c919ff5b8106e640192b223ea2a8f8c8150732

commit 82c919ff5b8106e640192b223ea2a8f8c8150732
Author: codeimpl <codeimpl@gmail.com>
Date: Thu Jun 14 17:55:44 2018

Rename XRFrameOfReferenceType enums

The values of the enum was updated in the spec[1].

[1] https://github.com/immersive-web/webxr/pull/370

Bug:  852520 
Change-Id: I916943bee355936e7430aa4e36d0eeb6b76607d5
Reviewed-on: https://chromium-review.googlesource.com/1101118
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#567340}
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/chrome/test/data/vr/e2e_test_files/resources/webxr_boilerplate.js
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/WebKit/LayoutTests/external/wpt/interfaces/webxr.idl
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/WebKit/LayoutTests/xr/ar_hittest.html
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/WebKit/LayoutTests/xr/getDevicePose_oneframeupdate.html
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/WebKit/LayoutTests/xr/getInputPose_hand.html
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/WebKit/LayoutTests/xr/xrSession_requestFrameOfReference.html
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/WebKit/LayoutTests/xr/xrView_match.html
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/WebKit/LayoutTests/xr/xrView_oneframeupdate.html
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/WebKit/LayoutTests/xr/xrViewport_valid.html
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/blink/renderer/modules/xr/xr_frame_of_reference.cc
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/blink/renderer/modules/xr/xr_frame_of_reference.idl
[modify] https://crrev.com/82c919ff5b8106e640192b223ea2a8f8c8150732/third_party/blink/renderer/modules/xr/xr_session.cc

Status: Fixed (was: Available)
Components: Blink>WebXR
Blocking: 864810

Sign in to add a comment