New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852495 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 853865
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEnded" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 13 2018

Issue description

"telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEnded" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkx0ZWxlbWV0cnkuaW50ZXJuYWwuYWN0aW9ucy5wbGF5X3VuaXR0ZXN0LlBsYXlBY3Rpb25UZXN0LnRlc3RQbGF5V2FpdEZvckVuZGVkDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: Speed>Telemetry
Labels: -Sheriff-Chromium
Owner: perezju@chromium.org
Status: Assigned (was: Untriaged)
Reassigning to perezju@ as an OWNER, please investigate.
Cc: perezju@chromium.org
Owner: jdoerrie@chromium.org
Can you disable the test and assign back?
Reverting CL is here: https://crrev.com/c/1101203 I'm not allowed to TBR and land it myself, so I added you as a reviewer.
*Disabling CL
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/67c2514bf571093be848f4375675dc1406576bfb

commit 67c2514bf571093be848f4375675dc1406576bfb
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Fri Jun 15 08:14:31 2018

Telemetry: Disable testPlayWaitForEnded On Mac

Bug:  chromium:852495 
Change-Id: I420dd8f9b9942b15bebf9d1d3aa85d5f206e1b42
Reviewed-on: https://chromium-review.googlesource.com/1101203
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/67c2514bf571093be848f4375675dc1406576bfb/telemetry/telemetry/internal/actions/play_unittest.py

Cc: -perezju@chromium.org jdoerrie@chromium.org
Owner: perezju@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05ae9b7afc4e8e02cd5e73c5301a7786f7d3e214

commit 05ae9b7afc4e8e02cd5e73c5301a7786f7d3e214
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 15 10:03:51 2018

Roll src/third_party/catapult b520f6298c3e..67c2514bf571 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/b520f6298c3e..67c2514bf571


git log b520f6298c3e..67c2514bf571 --date=short --no-merges --format='%ad %ae %s'
2018-06-15 jdoerrie@chromium.org Telemetry: Disable testPlayWaitForEnded On Mac


Created with:
  gclient setdep -r src/third_party/catapult@67c2514bf571

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:852495 
TBR=sullivan@chromium.org

Change-Id: Ifc95d7a8bf8b94c216fee96d8666b1ab47dbf069
Reviewed-on: https://chromium-review.googlesource.com/1101730
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567595}
[modify] https://crrev.com/05ae9b7afc4e8e02cd5e73c5301a7786f7d3e214/DEPS

Labels: -Pri-1 Pri-2
A few tasks where this fails:
https://chromium-swarm.appspot.com/task?id=3e1a0e2bdaabcb10&refresh=10&show_raw=1&wide_logs=true
https://chromium-swarm.appspot.com/task?id=3e1a8520ba38d510&refresh=10&show_raw=1&wide_logs=true
https://chromium-swarm.appspot.com/task?id=3e1b77ce201ae910&refresh=10&show_raw=1&wide_logs=true

The error stack is:

[45/298] telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEnded failed unexpectedly 7.7976s:
  Chrome build location for mac_x86_64 not found. Browser will be run without Flash.
  Traceback (most recent call last):
    File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/testing/browser_test_case.py", line 39, in WrappedMethod
      method(self)
    File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/play_unittest.py", line 77, in testPlayWaitForEnded
      action.RunAction(self._tab)
    File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
      return func(*args, **kwargs)
    File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/play.py", line 48, in RunAction
      self._ended_event_timeout_in_seconds)
    File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
      return func(*args, **kwargs)
    File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/media_action.py", line 33, in WaitForEvent
      timeout=timeout_in_seconds)
    File "/b/s/w/ir/third_party/catapult/common/py_utils/py_utils/__init__.py", line 148, in WaitFor
      (timeout, GetConditionString()))
  TimeoutException: Timed out while waiting 5s for lambda: self.HasEventCompletedOrError(tab, selector, event_name),.

Cc: nednguyen@chromium.org
+nednguyen, I'm thinking to increase the timeout in:
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/actions/play_unittest.py?rcl=b520f6298c3e149100f869b57b6c19c1f8c0df60&l=72

to see if that fixes the flakiness. 

Is there an easy way to check if that fix would work? The error was happening on CQ in a mac bot.
Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, Jun 15 2018

Labels: Sheriff-Chromium
Detected 9 new flakes for test/step "telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEnded". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkx0ZWxlbWV0cnkuaW50ZXJuYWwuYWN0aW9ucy5wbGF5X3VuaXR0ZXN0LlBsYXlBY3Rpb25UZXN0LnRlc3RQbGF5V2FpdEZvckVuZGVkDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 11 by holte@chromium.org, Jun 18 2018

Labels: Test-Disabled

Comment 12 by holte@chromium.org, Jun 18 2018

Labels: -Sheriff-Chromium
Mergedinto: 853865
Status: Duplicate (was: Assigned)

Comment 14 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 15 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment