New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 852486 link

Starred by 1 user
Status: Fixed
Owner:
█ diegomtzg@google.com
Last visit > 30 days ago
Closed: Aug 8
Cc:
qyears...@chromium.org
█ emso@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Spacey checks for trailing lines at the end of a file

Project Member Reported by diegomtzg@google.com, Jun 13 2018 
Spacey should check for empty lines at the end of a file
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d6950c54d466a6ae5aa1629a8a62484982e4b9fc

commit d6950c54d466a6ae5aa1629a8a62484982e4b9fc
Author: Diego Martinez <diegomtzg@google.com>
Date: Thu Jun 14 19:21:48 2018

[Spacey] Add checks for empty lines at the end of a file

Bug:  852486 
Change-Id: I3c27a7ba7253cfc93db0eee727e6713b0f51558b
Reviewed-on: https://chromium-review.googlesource.com/1099599
Commit-Queue: Diego Martinez <diegomtzg@google.com>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/d6950c54d466a6ae5aa1629a8a62484982e4b9fc/go/src/infra/tricium/functions/spacey/spacey.go
[modify] https://crrev.com/d6950c54d466a6ae5aa1629a8a62484982e4b9fc/go/src/infra/tricium/functions/spacey/spacey_test.go

Comment 2 by qyears...@chromium.org, Jun 14 2018 

Spacey now makes trailing line comments!

https://chromium-review.googlesource.com/c/playground/gerrit-tricium/+/1097599
https://chromium-swarm.appspot.com/task?id=3e1894b84ceebd10

But for some reason the comments don't seem to be showing up in the right location any more... this could be due to one of the other recent changes?

Comment 3 by diegomtzg@google.com, Aug 8

Status: Fixed (was: Started)
►

Sign in to add a comment