[Accessibility ]Download Infobar : Announce more specific option text |
||||||
Issue descriptionMore discussions on https://bugs.chromium.org/p/chromium/issues/detail?id=848135 As decided, the download infobar accessibility text for talkback should go through the following states. 1 - speeding up your download. (No options should be here) 2 - downloading xyz file (200 MB) Details:Button 3 - same as #2 when download fails/pending/multiple download etc. 4 - xyz file downloaded Open:Button
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/547058bf278275c8028fd65de67eda93eac5199b commit 547058bf278275c8028fd65de67eda93eac5199b Author: Shakti Sahu <shaktisahu@chromium.org> Date: Wed Jun 13 17:54:16 2018 Download infobar : Better accessibility string for buttons This CL changes the download infobar to have a more specific accessibility string about the presence of 'Open' and 'Details' link rather than announcing a generic message about 'options available at the bottom of the screen'. Bug: 852467 Change-Id: I81c078d0f3bbf2d7ad294618bfb81bf3c97fe488 Reviewed-on: https://chromium-review.googlesource.com/1097511 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#566905} [modify] https://crrev.com/547058bf278275c8028fd65de67eda93eac5199b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java [modify] https://crrev.com/547058bf278275c8028fd65de67eda93eac5199b/chrome/android/java/strings/android_chrome_strings.grd
,
Jun 13 2018
,
Jun 13 2018
This bug requires manual review: There is .grd file changes and we are only 40 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 13 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15690f4b0d5f20a16932222c1c02af665e663986 commit 15690f4b0d5f20a16932222c1c02af665e663986 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri Jun 15 22:21:16 2018 Download infobar : Better accessibility string for buttons This CL changes the download infobar to have a more specific accessibility string about the presence of 'Open' and 'Details' link rather than announcing a generic message about 'options available at the bottom of the screen'. Bug: 852467 Change-Id: I81c078d0f3bbf2d7ad294618bfb81bf3c97fe488 Reviewed-on: https://chromium-review.googlesource.com/1097511 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566905}(cherry picked from commit 547058bf278275c8028fd65de67eda93eac5199b) Reviewed-on: https://chromium-review.googlesource.com/1103358 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#383} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/15690f4b0d5f20a16932222c1c02af665e663986/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java [modify] https://crrev.com/15690f4b0d5f20a16932222c1c02af665e663986/chrome/android/java/strings/android_chrome_strings.grd
,
Jun 15 2018
,
Jun 18 2018
Retested on M69-69.0.3461.3 and M68 -68.0.3440.30 build. Observed Behavior:it is not reading the "speeding up your download" infobar
,
Jun 18 2018
Since there is too much text to speak in chrome already, the talkback skips the "speeding up your download" text which appears only for 3 seconds. The talkback directly moves to the subsequent messages e.g. "Downloading file" or <completed filename>. This is expected behavior. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by shaktisahu@chromium.org
, Jun 13 2018