New issue
Advanced search Search tips

Issue 852461 link

Starred by 2 users

Issue metadata

Status: Verified
Merged: issue 712244
Owner:
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-16
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MdRefresh] Omnibox Dropdown flickers/a shadow is to see when it disappears

Project Member Reported by meh...@chromium.org, Jun 13 2018

Issue description

Chrome Version: Version 69.0.3457.0 Canary
OS: macOS 10.13, but probably OS=All

What steps will reproduce the problem?
(1) Enable MdRefresh
(2) Type something into the Omnibox, so that the Dropdown appears
(3) Now press enter or delete the text, so that the Dropdown disappears

What is the expected result?
No flicker or kind of shadow when the Dropdown disappears

What happens instead?
It flicker or a kind of shadow is to see, when the Dropdown disappears. This is a bit disruptive.

A screencast is attached.

Thanks
Mehmet

 
Omnibox_Dropdown_flashing.mov
976 KB View Download
Owner: jdonnelly@chromium.org
Cc: -sdy@chromium.org jdonnelly@chromium.org
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
Labels: Pri-1
Triage: Upgrading to P1 - Flicker or movement now meets the P1 bar.
Labels: Proj-MacViews
Labels: Pri-2
Labels: Group-Omnibox
I'd like to make this "p1.5". I know MacViews have bigger fish to fry right now, but I'd like this to be at top of bug fixes after MacViews perf stuff
sdy: I'm assuming that you're working on this. If you need help from the omnibox team, let me know. I can't promise we can offer it before the branch point, but we'll keep it in mind.
I think this was actually fixed by ccameron@'s changes for  issue 712244  :-). Can someone double-check on canary?
Mergedinto: 712244
Status: Duplicate (was: Assigned)
Tentatively duping!
I just tried on today's Mac Canary and I don't see the flicker.
Hi @All, I think this was fixed with the following revert https://chromium.googlesource.com/chromium/src/+/ddedf9e5d46e1bfa61e8f396646d68df50d1c7af

Since there is a reland in the pipeline, I tend to say to keep this bug open and see if it will reappear after the reland. WDY?
NextAction: 2018-07-16
Status: Assigned (was: Duplicate)
Sure.
mehmet: can you provide a link to the reland? Did it... umm... reland yet?
Hello jdonnelly@: I mean CL https://chromium-review.googlesource.com/c/chromium/src/+/1138514 which probably will bring back the open and close opacity animations back.
Status: Verified (was: Assigned)
Okay, the CL mentioned in c#15 has been landed now at Snapshot #575706. I tested latest Snapshot #575714 and I can't repro the flicker there.

So, closing as fixed + verified :)

Sign in to add a comment