[MdRefresh] AIS Magnifying Glass and Result is not aligned with the rest of the Dropdown |
||||||
Issue descriptionChrome Version: Version 69.0.3457.0 Canary OS: macOS 10.13, but probably OS=All What steps will reproduce the problem? (1) Enable MdRefresh (2) Type weather into the Omnibox (3) What is the expected result? AIS Magnifying Glass and Result should be aligned with the rest of the Dropdown. What happens instead? AIS Magnifying Glass and Result is not aligned with the rest of the Dropdown. Screenshot are attached. Thanks Mehmet
,
Jun 14 2018
Please triage
,
Jun 14 2018
Try using the chrome://flags/#upcoming-ui-features flag instead. The above is expected behavior if the user sets chrome://flags/#top-chrome-md to Refresh without the upcoming-ui-features flag.
,
Jun 14 2018
But, per our recent email thread ("New Style Answers and Material Refresh shipped together?"), I'd ideally like to support MD Refresh enabled, with #omnibox-new-answer-layout *not* enabled. Which currently has this issue.
dschuyler: If this is not a trivial fix, let's discuss. We can consider making new answers 1:1 with MD Refresh. But if we decide to do that, then we should eliminate the separate flag and just have Refresh always enable new answers.
,
Jun 14 2018
Does step 1 refer to #top-chrome-md, Refresh? (I'm not seeing MdRefresh as an option).
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71a8fd1995d3b79f2d81a240014b824b20b6b07f commit 71a8fd1995d3b79f2d81a240014b824b20b6b07f Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Jun 14 23:55:31 2018 [omnibox] align magnifying glass icons in md refresh AiS This CL adjusts the placement of the icon and text to align icons whether MD Refresh is enabled or disabled. AiS refers to Answers in Suggest which is what the bug was reported on. Bug: 852450 Change-Id: I48633f3e799d50b0f0bd73a1b8ce713115142c8e Reviewed-on: https://chromium-review.googlesource.com/1101971 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#567490} [modify] https://crrev.com/71a8fd1995d3b79f2d81a240014b824b20b6b07f/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc [modify] https://crrev.com/71a8fd1995d3b79f2d81a240014b824b20b6b07f/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.h
,
Jun 15 2018
,
Jun 15 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by meh...@chromium.org
, Jun 13 201830.8 KB
30.8 KB View Download