Picture-in-Picture: disable feature on WebView via WebPreferences |
||
Issue descriptionWe should disable the feature on WebView because it doesn't have a UI implemented. This should be done via the Override... function for WebPreferences. We could do the same for Chrome Android until we have a UI implemented but I would rather not expose the API for now as we will implement it later while there are no plans to do this for WebView.
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/621da806975bd4bbf0c69a20105208d14b791de3 commit 621da806975bd4bbf0c69a20105208d14b791de3 Author: François Beaufort <beaufort.francois@gmail.com> Date: Thu Jun 14 17:57:50 2018 [Android Webview] Disable pictureInPictureEnabled. This makes sure Picture-in-Picture is disabled on Android Webview as there is no UI implemented. Bug: 852449 Change-Id: I526e02b0c2210fb5d71883f9db4ab05d76c56d2c Reviewed-on: https://chromium-review.googlesource.com/1100464 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#567341} [modify] https://crrev.com/621da806975bd4bbf0c69a20105208d14b791de3/android_webview/browser/aw_settings.cc
,
Jun 15 2018
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d94396277cd8943c8044bd7c04cfb6b98f2bf930 commit d94396277cd8943c8044bd7c04cfb6b98f2bf930 Author: François Beaufort <beaufort.francois@gmail.com> Date: Tue Jun 26 09:11:11 2018 Don't expose Picture-in-Picture API for Android WebView. Picture-in-Picture API is disabled in Android WebView as there is no UI implemented. Bug: 855270 , 852449 Change-Id: Id7c0ebcc94085f6e1b3f00383254780a5357269b Reviewed-on: https://chromium-review.googlesource.com/1112247 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#570352} [modify] https://crrev.com/d94396277cd8943c8044bd7c04cfb6b98f2bf930/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt |
||
►
Sign in to add a comment |
||
Comment 1 by fbeaufort@chromium.org
, Jun 14 2018