New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852444 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
fan



Sign in to add a comment

npcx/fan: after RPM=0, PWM is disabled but never re-enabled

Project Member Reported by dnojiri@chromium.org, Jun 13 2018

Issue description

When RPM=0, ncpx/fan.c disables PWM but it's not enabled even after RPM becomes non-zero.

This bug has been fixed in Fizz branch by https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1096547 but we're looking for a more thorough fix, which may require us to (re)define the interface between common/fan.c and chip/*/fan.c and refactor the fan control system (thermal.c, fan.c, chip/*/fan.c, chip/*/pwm.c) based on it.

 

Sign in to add a comment