New issue
Advanced search Search tips

Issue 852436 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Add method to remove all local data.

Project Member Reported by jzw@chromium.org, Jun 13 2018

Issue description

On most Chrome clients, only "server data" is deleted when sync is disabled, leaving "local data" intact. However, clients of //ios/web_view may wish to remove all local data as part of disabling sync.

Easy way is to provide a method on PersonalDataManager called "ClearAllLocalData" that is analogous to it's existing  "ClearAllServerData" method.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce616f3caef498d93851dd3fb8c4944cc5b7d74c

commit ce616f3caef498d93851dd3fb8c4944cc5b7d74c
Author: John Z Wu <jzw@chromium.org>
Date: Thu Jun 14 19:41:12 2018

Add a method to delete all local data in PersonalDataManager.

//ios/web_view will delete all locally saved data after logging out.

Change-Id: Ief9ea2ead7d49d9900575ce1c7784333baa99ea6
Bug:  852436 
Reviewed-on: https://chromium-review.googlesource.com/1089796
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567362}
[modify] https://crrev.com/ce616f3caef498d93851dd3fb8c4944cc5b7d74c/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/ce616f3caef498d93851dd3fb8c4944cc5b7d74c/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/ce616f3caef498d93851dd3fb8c4944cc5b7d74c/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/ce616f3caef498d93851dd3fb8c4944cc5b7d74c/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/ce616f3caef498d93851dd3fb8c4944cc5b7d74c/components/autofill/core/browser/webdata/autofill_table.h
[modify] https://crrev.com/ce616f3caef498d93851dd3fb8c4944cc5b7d74c/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc
[modify] https://crrev.com/ce616f3caef498d93851dd3fb8c4944cc5b7d74c/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h
[modify] https://crrev.com/ce616f3caef498d93851dd3fb8c4944cc5b7d74c/components/autofill/core/browser/webdata/autofill_webdata_service.cc
[modify] https://crrev.com/ce616f3caef498d93851dd3fb8c4944cc5b7d74c/components/autofill/core/browser/webdata/autofill_webdata_service.h

Status: Fixed (was: Untriaged)

Sign in to add a comment