New issue
Advanced search Search tips

Issue 852429 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 4
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Collections: Add badge to URL table view cell

Project Member Reported by kkhorimoto@chromium.org, Jun 13 2018

Issue description

The Reading List has a small badge for unread items that are unread and available offline.  This needs to be added to the URL table view cell superclass and integrated with the ReadingListTableViewItems
 
The NextAction date has arrived: 2018-06-20
Status: Started (was: Assigned)
crrev.com/c/1104891 adds the badge functionality to TableViewItem and TableViewItemCell.  I will extend ReadingListTableViewItem in a future CL to use this functionality to display the badge.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48977ea678de176b2c49b619162553774503b4ad

commit 48977ea678de176b2c49b619162553774503b4ad
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Jun 27 03:52:22 2018

[iOS] Update TableViewURLItem/Cell for Reading List.

This CL adds the ability to specify supplemental text for the URL label
and an optional badge view to display over the favicon view.

Bug:  805209 ,  852429 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I609fe777feda0242a3748902e739e07fe43590ad
Reviewed-on: https://chromium-review.googlesource.com/1104891
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570655}
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/resources/BUILD.gn
[add] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_check_mark.imageset/Contents.json
[add] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_check_mark.imageset/table_view_cell_check_mark.png
[add] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_check_mark.imageset/table_view_cell_check_mark@2x.png
[add] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/resources/table_view_cell_check_mark.imageset/table_view_cell_check_mark@3x.png
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/table_view_url_item.h
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
[modify] https://crrev.com/48977ea678de176b2c49b619162553774503b4ad/ios/chrome/browser/ui/table_view/cells/table_view_url_item_unittest.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25c846ec5c19db8ff6363e9a680fc9a3c8e5ac99

commit 25c846ec5c19db8ff6363e9a680fc9a3c8e5ac99
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Fri Jun 29 01:41:29 2018

[iOS] Add distillation badge to reading list table items.

Bug:  852429 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I32d6cae65a26ab3439caa41447a8ffd027b8e0ac
Reviewed-on: https://chromium-review.googlesource.com/1111382
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571356}
[modify] https://crrev.com/25c846ec5c19db8ff6363e9a680fc9a3c8e5ac99/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/25c846ec5c19db8ff6363e9a680fc9a3c8e5ac99/ios/chrome/browser/ui/reading_list/reading_list_table_view_item.mm
[modify] https://crrev.com/25c846ec5c19db8ff6363e9a680fc9a3c8e5ac99/ios/chrome/browser/ui/reading_list/resources/BUILD.gn
[add] https://crrev.com/25c846ec5c19db8ff6363e9a680fc9a3c8e5ac99/ios/chrome/browser/ui/reading_list/resources/distillation_fail_new.imageset/Contents.json
[add] https://crrev.com/25c846ec5c19db8ff6363e9a680fc9a3c8e5ac99/ios/chrome/browser/ui/reading_list/resources/distillation_fail_new.imageset/distillation_fail_new.png
[add] https://crrev.com/25c846ec5c19db8ff6363e9a680fc9a3c8e5ac99/ios/chrome/browser/ui/reading_list/resources/distillation_fail_new.imageset/distillation_fail_new@2x.png
[add] https://crrev.com/25c846ec5c19db8ff6363e9a680fc9a3c8e5ac99/ios/chrome/browser/ui/reading_list/resources/distillation_fail_new.imageset/distillation_fail_new@3x.png

Status: Fixed (was: Started)
Updating the state so it reflects on tracking.

Sign in to add a comment