Credit card save infobar should use same short title in both local save and upstreaming |
||||||||
Issue description"Save card?" should be used instead of "Do you want Chrome to save this card?" in local save
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/436b55566a707e1967d77e746e06ec0d000888be commit 436b55566a707e1967d77e746e06ec0d000888be Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Jun 14 15:23:39 2018 [AF] Use same short title in both local & upstream credit card save infobar Bug: 852427 Change-Id: I6a397b8fa5e3d3013e69d7e55e50679dc27c875e Reviewed-on: https://chromium-review.googlesource.com/1099178 Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567271} [modify] https://crrev.com/436b55566a707e1967d77e746e06ec0d000888be/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc [modify] https://crrev.com/436b55566a707e1967d77e746e06ec0d000888be/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc [modify] https://crrev.com/436b55566a707e1967d77e746e06ec0d000888be/components/autofill_strings.grdp
,
Jun 18 2018
,
Jun 18 2018
This bug requires manual review: There is .grd file changes and we are only 35 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 18 2018
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9468ff63497f24c4670156ef49f7e8f044e35e0 commit a9468ff63497f24c4670156ef49f7e8f044e35e0 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Mon Jun 18 19:05:46 2018 [AF] Use same short title in both local & upstream credit card save infobar Bug: 852427 Change-Id: I6a397b8fa5e3d3013e69d7e55e50679dc27c875e Reviewed-on: https://chromium-review.googlesource.com/1099178 Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#567271}(cherry picked from commit 436b55566a707e1967d77e746e06ec0d000888be) Reviewed-on: https://chromium-review.googlesource.com/1104822 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#407} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/a9468ff63497f24c4670156ef49f7e8f044e35e0/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc [modify] https://crrev.com/a9468ff63497f24c4670156ef49f7e8f044e35e0/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc [modify] https://crrev.com/a9468ff63497f24c4670156ef49f7e8f044e35e0/components/autofill_strings.grdp
,
Jun 20 2018
Able to verify the fix on Mac 10.13.1 and Ubuntu 14.04 with the chrome version 68.0.3440.33 with the below mentioned steps. 1. Launched chrome and Signed into it. 2. Enabled flags #wallet-service-use-sandbox, #use-sync-sandbox and #enable-autofill-credit-card-upload 3. Navigated to http://rsolomakhin.github.io/autofill/ 4. Autofilled credit card details -> entered CVV then Submitted. We were able to verify on Mac and Linux but some how could not verify on Windows as we are not getting the pop-up. @Moe Ahmadi: Could you please help us in verifying the fix on Windows. Thanks!
,
Jun 20 2018
Unfortunately I don't have a Windows machine.
,
Jun 20 2018
Fabio: are you able to verify the fix on the latest Chrome beta? Relevant release from the archive: https://pantheon.corp.google.com/storage/browser/chrome-signed/desktop-5c0tCh/68.0.3440.33/win64-clang/
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/491c3c22430f08e350a17d7a224ef64353d57d8c commit 491c3c22430f08e350a17d7a224ef64353d57d8c Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Aug 30 19:41:01 2018 [AF] Use same short title in CC local save & upstream infobar (part 2) This change splits the string resource used for local save and upstreaming (originally introduced in crrev.com/c/1099178) into two resources with the same string in order to allow string experiments for the upstream infobar. Bug: 852427 Change-Id: I859f29a9f06ba412299b21bc3fa096ce5da9e6c3 Reviewed-on: https://chromium-review.googlesource.com/1196825 Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#587714} [modify] https://crrev.com/491c3c22430f08e350a17d7a224ef64353d57d8c/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc [modify] https://crrev.com/491c3c22430f08e350a17d7a224ef64353d57d8c/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc [modify] https://crrev.com/491c3c22430f08e350a17d7a224ef64353d57d8c/components/autofill_strings.grdp
,
Aug 31
Able to verify the fix on Mac 10.13.6, Ubuntu 17.10 and Windows 10 with the chrome version 70.0.3538.0 with the below mentioned steps. 1. Launched chrome and Signed into it. 2. Enabled flags #wallet-service-use-sandbox, #use-sync-sandbox and #enable-autofill-credit-card-upload as per comment #10 3. Navigated to http://rsolomakhin.github.io/autofill/ 4. Auto filled credit card details -> entered CVV then Submitted. Attaching scree shot for reference. Observed that "Able to see the credit card popup" The fix is working as expected, adding Verified labels Thanks! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mahmadi@chromium.org
, Jun 13 2018