New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852420 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 858862



Sign in to add a comment

V8 Young Generation Large Objects

Project Member Reported by hpayer@chromium.org, Jun 13 2018

Issue description

V8 Young Generation Large Objects
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af

commit fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af
Author: Hannes Payer <hpayer@chromium.org>
Date: Wed Jun 27 13:37:41 2018

[heap] Adds a young generation large object space

This CL adds the young generation lage object spaces and a flag
--young-generation-large-objects that by default allocates all
large objects in this space. This is a preparation CL. The space
is not fully functional.

Bug: chromium:852420
Change-Id: Ib66d26fa52cda89bf04787084826aeb84b6ec1ac
Reviewed-on: https://chromium-review.googlesource.com/1099164
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54056}
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/src/flag-definitions.h
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/src/globals.h
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/src/heap/heap-inl.h
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/src/heap/heap.cc
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/src/heap/heap.h
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/src/heap/spaces.cc
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/src/heap/spaces.h
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/src/snapshot/serializer-common.h
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/src/snapshot/serializer.cc
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af/test/cctest/test-api.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6

commit e5416386e615cca88b1f70aa7d1b6e7161ed1ba6
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Jun 28 06:18:35 2018

Revert "[heap] Adds a young generation large object space"

This reverts commit fdf69d53b6ea0b4b2bda5d68fdbfa4a4f92dd0af.

Reason for revert: Speculative revert for broken GPU bots:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/Linux%20V8%20FYI%20Release%20%28NVIDIA%29/1638
https://ci.chromium.org/p/v8/builders/luci.v8.ci/Mac%20V8%20FYI%20Release%20%28Intel%29/1624

Original change's description:
> [heap] Adds a young generation large object space
> 
> This CL adds the young generation lage object spaces and a flag
> --young-generation-large-objects that by default allocates all
> large objects in this space. This is a preparation CL. The space
> is not fully functional.
> 
> Bug: chromium:852420
> Change-Id: Ib66d26fa52cda89bf04787084826aeb84b6ec1ac
> Reviewed-on: https://chromium-review.googlesource.com/1099164
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54056}

TBR=ulan@chromium.org,yangguo@chromium.org,hpayer@chromium.org

Change-Id: I175514f806a19c7837022795210625ca40e3c318
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:852420
Reviewed-on: https://chromium-review.googlesource.com/1118038
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54072}
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/src/flag-definitions.h
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/src/globals.h
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/src/heap/heap-inl.h
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/src/heap/heap.cc
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/src/heap/heap.h
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/src/heap/spaces.cc
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/src/heap/spaces.h
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/src/snapshot/serializer-common.h
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/src/snapshot/serializer.cc
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/e5416386e615cca88b1f70aa7d1b6e7161ed1ba6/test/cctest/test-api.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/831e4d1fffc21204e38a2ff1ebe0bf100236daf2

commit 831e4d1fffc21204e38a2ff1ebe0bf100236daf2
Author: Hannes Payer <hpayer@chromium.org>
Date: Mon Jul 02 08:41:11 2018

Add new_large_object_space to allocator dump whitelist.

Bug: chromium:852420
Change-Id: I5974bf3d0576e383f1a1ae0b1163aed94ca88445
Reviewed-on: https://chromium-review.googlesource.com/1119906
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571841}
[modify] https://crrev.com/831e4d1fffc21204e38a2ff1ebe0bf100236daf2/base/trace_event/memory_infra_background_whitelist.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783

commit a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783
Author: Hannes Payer <hpayer@chromium.org>
Date: Mon Jul 02 11:08:09 2018

Reland "[heap] Adds a young generation large object space"

Bug: chromium:852420
Change-Id: I44d0bde25283ac8c00155344f879eb1143b43bc9
Reviewed-on: https://chromium-review.googlesource.com/1119688
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54130}
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/src/flag-definitions.h
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/src/globals.h
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/src/heap/heap-inl.h
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/src/heap/heap.cc
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/src/heap/heap.h
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/src/heap/spaces.cc
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/src/heap/spaces.h
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/src/snapshot/serializer-common.h
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/src/snapshot/serializer.cc
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/a383aa33e5c9aa5a5ff5c47dfd41b58aa867c783/test/cctest/test-api.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e438d5d4de28f7002145e6ef5a85390e48209dc6

commit e438d5d4de28f7002145e6ef5a85390e48209dc6
Author: Hannes Payer <hpayer@chromium.org>
Date: Wed Jul 04 09:45:45 2018

[heap] Make objects allocated in new_lo_space look like young generation objects.

The scavenger still does not handle young generation large objects correctly.
This will be added in a follow-up CL.

Bug: chromium:852420
Change-Id: I2587509d6e7f329aeff3db246d949bb30b3a91a5
Reviewed-on: https://chromium-review.googlesource.com/1124477
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54197}
[modify] https://crrev.com/e438d5d4de28f7002145e6ef5a85390e48209dc6/src/heap/heap-inl.h
[modify] https://crrev.com/e438d5d4de28f7002145e6ef5a85390e48209dc6/src/heap/incremental-marking.cc
[modify] https://crrev.com/e438d5d4de28f7002145e6ef5a85390e48209dc6/src/heap/incremental-marking.h
[modify] https://crrev.com/e438d5d4de28f7002145e6ef5a85390e48209dc6/src/heap/spaces.cc
[modify] https://crrev.com/e438d5d4de28f7002145e6ef5a85390e48209dc6/src/heap/spaces.h
[modify] https://crrev.com/e438d5d4de28f7002145e6ef5a85390e48209dc6/test/cctest/heap/test-heap.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/12b47ec62c5f941cfd197426b7aa9a283b937b97

commit 12b47ec62c5f941cfd197426b7aa9a283b937b97
Author: Yang Guo <yangguo@chromium.org>
Date: Wed Jul 04 11:55:37 2018

Revert "[heap] Make objects allocated in new_lo_space look like young generation objects."

This reverts commit e438d5d4de28f7002145e6ef5a85390e48209dc6.

Reason for revert: TSAN failures - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21357

Original change's description:
> [heap] Make objects allocated in new_lo_space look like young generation objects.
> 
> The scavenger still does not handle young generation large objects correctly.
> This will be added in a follow-up CL.
> 
> Bug: chromium:852420
> Change-Id: I2587509d6e7f329aeff3db246d949bb30b3a91a5
> Reviewed-on: https://chromium-review.googlesource.com/1124477
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54197}

TBR=ulan@chromium.org,hpayer@chromium.org

Change-Id: Ief44cfd841278f2d53d51f3a21c03b70b8025a7a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:852420
Reviewed-on: https://chromium-review.googlesource.com/1125979
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54205}
[modify] https://crrev.com/12b47ec62c5f941cfd197426b7aa9a283b937b97/src/heap/heap-inl.h
[modify] https://crrev.com/12b47ec62c5f941cfd197426b7aa9a283b937b97/src/heap/incremental-marking.cc
[modify] https://crrev.com/12b47ec62c5f941cfd197426b7aa9a283b937b97/src/heap/incremental-marking.h
[modify] https://crrev.com/12b47ec62c5f941cfd197426b7aa9a283b937b97/src/heap/spaces.cc
[modify] https://crrev.com/12b47ec62c5f941cfd197426b7aa9a283b937b97/src/heap/spaces.h
[modify] https://crrev.com/12b47ec62c5f941cfd197426b7aa9a283b937b97/test/cctest/heap/test-heap.cc

Blockedon: 858862
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/659db1986dfe3b33e4c2832dd7a38e05b5b683e0

commit 659db1986dfe3b33e4c2832dd7a38e05b5b683e0
Author: Hannes Payer <hpayer@chromium.org>
Date: Fri Jul 06 13:28:47 2018

[heap] Add new large object space to --trace-gc-verbose.

Bug: chromium:852420
Change-Id: Ibab2798cde017b178bf6db51c92ecff9e81ef641
Reviewed-on: https://chromium-review.googlesource.com/1127787
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54292}
[modify] https://crrev.com/659db1986dfe3b33e4c2832dd7a38e05b5b683e0/src/heap/heap.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8fe6b87fdddec42bb093430a2dd345dfc37693d1

commit 8fe6b87fdddec42bb093430a2dd345dfc37693d1
Author: Hannes Payer <hpayer@chromium.org>
Date: Fri Jul 06 13:33:05 2018

[heap] Tenure large objects based on size (currently 32K).

Bug: chromium:852420
Change-Id: Ibb8cd735036368c5bda83fe60b12b427e8e7ce7f
Reviewed-on: https://chromium-review.googlesource.com/1127887
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54296}
[modify] https://crrev.com/8fe6b87fdddec42bb093430a2dd345dfc37693d1/src/globals.h
[modify] https://crrev.com/8fe6b87fdddec42bb093430a2dd345dfc37693d1/src/heap/heap-inl.h
[modify] https://crrev.com/8fe6b87fdddec42bb093430a2dd345dfc37693d1/test/cctest/heap/test-heap.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 10

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f29fbf35a91b8808aea1c21071e189b47d6c831b

commit f29fbf35a91b8808aea1c21071e189b47d6c831b
Author: Hannes Payer <hpayer@chromium.org>
Date: Tue Aug 21 20:20:51 2018

[heap] Provide memory order relaxed accessor of page flags.

Bug:  chromium:874437 ,chromium:852420
Change-Id: I4f484a6bb7072804dbcaacab77d25ba7a3fe338f
Reviewed-on: https://chromium-review.googlesource.com/1183188
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55287}
[modify] https://crrev.com/f29fbf35a91b8808aea1c21071e189b47d6c831b/src/heap/spaces.h

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/fc8a34a3f10afd6d4830a3f0093d2b26358cf231

commit fc8a34a3f10afd6d4830a3f0093d2b26358cf231
Author: Hannes Payer <hpayer@chromium.org>
Date: Wed Aug 22 14:40:56 2018

Revert "[heap] Provide memory order relaxed accessor of page flags."

This reverts commit f29fbf35a91b8808aea1c21071e189b47d6c831b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [heap] Provide memory order relaxed accessor of page flags.
> 
> Bug:  chromium:874437 ,chromium:852420
> Change-Id: I4f484a6bb7072804dbcaacab77d25ba7a3fe338f
> Reviewed-on: https://chromium-review.googlesource.com/1183188
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55287}

TBR=ulan@chromium.org,hpayer@chromium.org

Change-Id: I5703641fd99a9dc79e2819af1597d4440e2e9990
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:874437 , chromium:852420
Reviewed-on: https://chromium-review.googlesource.com/1185161
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55307}
[modify] https://crrev.com/fc8a34a3f10afd6d4830a3f0093d2b26358cf231/src/heap/spaces.h

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/26fcc4aaf5fb0d7f225ed2917b7a3b226d3de057

commit 26fcc4aaf5fb0d7f225ed2917b7a3b226d3de057
Author: Hannes Payer <hpayer@chromium.org>
Date: Thu Aug 23 08:13:26 2018

Revert "[heap] Use std::atomic for page flags."

This reverts commit 7f3f7e8a9547ece1a7f80ce902bc23632e902b0b.

Reason for revert: performance

Original change's description:
> [heap] Use std::atomic for page flags.
> 
> Bug: chromium:852420,chromium:852420
> Change-Id: I873666df415c6b4919f8b3385494c9a08f105188
> Reviewed-on: https://chromium-review.googlesource.com/1170700
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55055}

TBR=ulan@chromium.org,hpayer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:852420
Change-Id: I89fcd085395fa372ae9fb254e55954ff3b7ca4d7
Reviewed-on: https://chromium-review.googlesource.com/1184982
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55329}
[modify] https://crrev.com/26fcc4aaf5fb0d7f225ed2917b7a3b226d3de057/src/heap/factory.cc
[modify] https://crrev.com/26fcc4aaf5fb0d7f225ed2917b7a3b226d3de057/src/heap/mark-compact-inl.h
[modify] https://crrev.com/26fcc4aaf5fb0d7f225ed2917b7a3b226d3de057/src/heap/spaces.cc
[modify] https://crrev.com/26fcc4aaf5fb0d7f225ed2917b7a3b226d3de057/src/heap/spaces.h

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/adea021bbf90cfc93d032d649f112895a482cb3e

commit adea021bbf90cfc93d032d649f112895a482cb3e
Author: Hannes Payer <hpayer@chromium.org>
Date: Thu Aug 23 17:40:24 2018

[heap] Reuse object evacuation information for slot recording in Scavenger.

Bug: chromium:852420
Change-Id: If092b5c8b093b313807687a27bc29bebd1c4ee5f
Reviewed-on: https://chromium-review.googlesource.com/1187143
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55364}
[modify] https://crrev.com/adea021bbf90cfc93d032d649f112895a482cb3e/src/heap/scavenger-inl.h
[modify] https://crrev.com/adea021bbf90cfc93d032d649f112895a482cb3e/src/heap/scavenger.cc
[modify] https://crrev.com/adea021bbf90cfc93d032d649f112895a482cb3e/src/heap/scavenger.h

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5876d8f58d27f145497d7ea17f191a0f4d99b55b

commit 5876d8f58d27f145497d7ea17f191a0f4d99b55b
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Aug 23 19:15:07 2018

Revert "[heap] Reuse object evacuation information for slot recording in Scavenger."

This reverts commit adea021bbf90cfc93d032d649f112895a482cb3e.

Reason for revert:
 https://crbug.com/v8/8087 

Original change's description:
> [heap] Reuse object evacuation information for slot recording in Scavenger.
> 
> Bug: chromium:852420
> Change-Id: If092b5c8b093b313807687a27bc29bebd1c4ee5f
> Reviewed-on: https://chromium-review.googlesource.com/1187143
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55364}

TBR=ulan@chromium.org,hpayer@chromium.org

Change-Id: I480328e852c09f460a38e141eb7d2960c5001d35
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:852420
Reviewed-on: https://chromium-review.googlesource.com/1187301
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55367}
[modify] https://crrev.com/5876d8f58d27f145497d7ea17f191a0f4d99b55b/src/heap/scavenger-inl.h
[modify] https://crrev.com/5876d8f58d27f145497d7ea17f191a0f4d99b55b/src/heap/scavenger.cc
[modify] https://crrev.com/5876d8f58d27f145497d7ea17f191a0f4d99b55b/src/heap/scavenger.h

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/177e0aa380194df059494c9b336aa201e345b9cd

commit 177e0aa380194df059494c9b336aa201e345b9cd
Author: Hannes Payer <hpayer@chromium.org>
Date: Fri Aug 24 11:48:17 2018

[heap] Reland: Reuse object evacuation information for slot recording in Scavenger.

This reverts commit 5876d8f58d27f145497d7ea17f191a0f4d99b55b.

Bug: chromium:852420
Change-Id: I318587f20409f98d05278fc0b4c14da09d259cd3
Reviewed-on: https://chromium-review.googlesource.com/1188128
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55393}
[modify] https://crrev.com/177e0aa380194df059494c9b336aa201e345b9cd/src/heap/scavenger-inl.h
[modify] https://crrev.com/177e0aa380194df059494c9b336aa201e345b9cd/src/heap/scavenger.cc
[modify] https://crrev.com/177e0aa380194df059494c9b336aa201e345b9cd/src/heap/scavenger.h

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/136ecbb9bf04acc147677b31360f61f3165fd3bc

commit 136ecbb9bf04acc147677b31360f61f3165fd3bc
Author: Maya Lekova <mslekova@chromium.org>
Date: Fri Aug 24 13:15:50 2018

Revert "[heap] Reland: Reuse object evacuation information for slot recording in Scavenger."

This reverts commit 177e0aa380194df059494c9b336aa201e345b9cd.

Reason for revert: Causes a flaky test on Windows - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/4373

Bug:  v8:8087 

Original change's description:
> [heap] Reland: Reuse object evacuation information for slot recording in Scavenger.
> 
> This reverts commit 5876d8f58d27f145497d7ea17f191a0f4d99b55b.
> 
> Bug: chromium:852420
> Change-Id: I318587f20409f98d05278fc0b4c14da09d259cd3
> Reviewed-on: https://chromium-review.googlesource.com/1188128
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55393}

TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org

Change-Id: If553b74f8443ad98822a2a3d147dc8963346043c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:852420
Reviewed-on: https://chromium-review.googlesource.com/1188542
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55405}
[modify] https://crrev.com/136ecbb9bf04acc147677b31360f61f3165fd3bc/src/heap/scavenger-inl.h
[modify] https://crrev.com/136ecbb9bf04acc147677b31360f61f3165fd3bc/src/heap/scavenger.cc
[modify] https://crrev.com/136ecbb9bf04acc147677b31360f61f3165fd3bc/src/heap/scavenger.h

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0d66b4d85e68e860de0ff5da81545af15d8ac6fc

commit 0d66b4d85e68e860de0ff5da81545af15d8ac6fc
Author: Hannes Payer <hpayer@chromium.org>
Date: Tue Aug 28 15:44:28 2018

[heap] Reland: Reuse object evacuation information for slot recording in Scavenger.

This reverts commit 136ecbb9bf04acc147677b31360f61f3165fd3bc.

Bug: chromium:852420
Change-Id: I4fab9d6ed7b18085352fa7488c2849b90588deaf
Reviewed-on: https://chromium-review.googlesource.com/1189802
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55467}
[modify] https://crrev.com/0d66b4d85e68e860de0ff5da81545af15d8ac6fc/src/heap/scavenger-inl.h
[modify] https://crrev.com/0d66b4d85e68e860de0ff5da81545af15d8ac6fc/src/heap/scavenger.cc
[modify] https://crrev.com/0d66b4d85e68e860de0ff5da81545af15d8ac6fc/src/heap/scavenger.h

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d6de4af5739a34e01d06ae5e624ead0cac0faa93

commit d6de4af5739a34e01d06ae5e624ead0cac0faa93
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Aug 28 17:51:15 2018

Revert "[heap] Reland: Reuse object evacuation information for slot recording in Scavenger."

This reverts commit 0d66b4d85e68e860de0ff5da81545af15d8ac6fc.

Reason for revert:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/22200

Original change's description:
> [heap] Reland: Reuse object evacuation information for slot recording in Scavenger.
> 
> This reverts commit 136ecbb9bf04acc147677b31360f61f3165fd3bc.
> 
> Bug: chromium:852420
> Change-Id: I4fab9d6ed7b18085352fa7488c2849b90588deaf
> Reviewed-on: https://chromium-review.googlesource.com/1189802
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55467}

TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org

Change-Id: I03991a02eb5e06e7db91f88462232dde4bd97f49
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:852420
Reviewed-on: https://chromium-review.googlesource.com/1194005
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55468}
[modify] https://crrev.com/d6de4af5739a34e01d06ae5e624ead0cac0faa93/src/heap/scavenger-inl.h
[modify] https://crrev.com/d6de4af5739a34e01d06ae5e624ead0cac0faa93/src/heap/scavenger.cc
[modify] https://crrev.com/d6de4af5739a34e01d06ae5e624ead0cac0faa93/src/heap/scavenger.h

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/067afa54cf90794c329ea725faeff3757b50d505

commit 067afa54cf90794c329ea725faeff3757b50d505
Author: Hannes Payer <hpayer@chromium.org>
Date: Tue Aug 28 18:47:00 2018

[heap] Reland: Reuse object evacuation information for slot recording in Scavenger.

This reverts commit d6de4af5739a34e01d06ae5e624ead0cac0faa93.

Bug: chromium:852420
Change-Id: Ife02a0e47ddb4a136c552965d9e01c6a0ef18e02
Reviewed-on: https://chromium-review.googlesource.com/1194363
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55470}
[modify] https://crrev.com/067afa54cf90794c329ea725faeff3757b50d505/src/heap/scavenger-inl.h
[modify] https://crrev.com/067afa54cf90794c329ea725faeff3757b50d505/src/heap/scavenger.cc
[modify] https://crrev.com/067afa54cf90794c329ea725faeff3757b50d505/src/heap/scavenger.h

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/989e2e31d261708e6eca922869bf8905c7a90093

commit 989e2e31d261708e6eca922869bf8905c7a90093
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Fri Sep 28 10:08:55 2018

Revert "[heap] Free dead young generation large objects."

This reverts commit e4c650ad94ca67b7d91646d6d5df7808046b2902.

Reason for revert: Break Linux nosnap: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/20786

Original change's description:
> [heap] Free dead young generation large objects.
> 
> Bug: chromium:852420
> Change-Id: I77479c3a96bcae6041ddce316c5062f129447edd
> Reviewed-on: https://chromium-review.googlesource.com/1249124
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56280}

TBR=hpayer@chromium.org,mlippautz@chromium.org

Change-Id: If35a09497e09f5cc7ceef8ec33a7c86761f2a336
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:852420
Reviewed-on: https://chromium-review.googlesource.com/1251124
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56282}
[modify] https://crrev.com/989e2e31d261708e6eca922869bf8905c7a90093/src/heap/heap.cc
[modify] https://crrev.com/989e2e31d261708e6eca922869bf8905c7a90093/src/heap/heap.h
[modify] https://crrev.com/989e2e31d261708e6eca922869bf8905c7a90093/src/heap/mark-compact.cc
[modify] https://crrev.com/989e2e31d261708e6eca922869bf8905c7a90093/src/heap/scavenger.cc
[modify] https://crrev.com/989e2e31d261708e6eca922869bf8905c7a90093/src/heap/spaces.cc
[modify] https://crrev.com/989e2e31d261708e6eca922869bf8905c7a90093/src/heap/spaces.h
[modify] https://crrev.com/989e2e31d261708e6eca922869bf8905c7a90093/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/989e2e31d261708e6eca922869bf8905c7a90093/test/cctest/test-api.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6cf351e8fe1ec28bdb2bb156f58b3ed450041247

commit 6cf351e8fe1ec28bdb2bb156f58b3ed450041247
Author: Hannes Payer <hpayer@chromium.org>
Date: Fri Oct 05 11:26:59 2018

[heap] Never read out of the [x,y) range during Bitmap operations.

Bug=chromium:852420

Change-Id: Ia810292e4f9592836e7ce734686cadc69328b1c3
Reviewed-on: https://chromium-review.googlesource.com/c/1262475
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56408}
[modify] https://crrev.com/6cf351e8fe1ec28bdb2bb156f58b3ed450041247/src/heap/marking.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/49c7b308d90797c27852af53a92952f5683f68b6

commit 49c7b308d90797c27852af53a92952f5683f68b6
Author: Hannes Payer <hpayer@chromium.org>
Date: Wed Nov 21 14:18:26 2018

[serializer] Tenure young large object in the serializer.

Bug: chromium:852420
Change-Id: I54d1708991468bb062d9e7b246e724594f252e5e
Reviewed-on: https://chromium-review.googlesource.com/c/1346369
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57686}
[modify] https://crrev.com/49c7b308d90797c27852af53a92952f5683f68b6/src/snapshot/serializer-allocator.cc
[modify] https://crrev.com/49c7b308d90797c27852af53a92952f5683f68b6/src/snapshot/serializer.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/42c41a1fbbd96eaca395fb816ab3e19aee52f126

commit 42c41a1fbbd96eaca395fb816ab3e19aee52f126
Author: Hannes Payer <hpayer@chromium.org>
Date: Wed Nov 21 18:52:44 2018

Don't run young generation large object tests for nosnap configurations.

Bug: chromium:852420
Change-Id: I01d0bed33a573adbe1d9365868d63ea9c3cb0552
Reviewed-on: https://chromium-review.googlesource.com/c/1346499
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57697}
[modify] https://crrev.com/42c41a1fbbd96eaca395fb816ab3e19aee52f126/test/cctest/heap/test-heap.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/be77c3ef754b8a852c6f2965a980963ae76f19fb

commit be77c3ef754b8a852c6f2965a980963ae76f19fb
Author: Hannes Payer <hpayer@chromium.org>
Date: Thu Nov 22 17:48:43 2018

[heap] Handle young generation large objects by MC.

Bug: chromium:852420
Change-Id: Ice7548bf9993bc5dd57b301c410c019eb956daa5
Reviewed-on: https://chromium-review.googlesource.com/c/1348077
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57755}
[modify] https://crrev.com/be77c3ef754b8a852c6f2965a980963ae76f19fb/src/heap/mark-compact.cc
[modify] https://crrev.com/be77c3ef754b8a852c6f2965a980963ae76f19fb/src/heap/mark-compact.h
[modify] https://crrev.com/be77c3ef754b8a852c6f2965a980963ae76f19fb/src/heap/spaces.cc
[modify] https://crrev.com/be77c3ef754b8a852c6f2965a980963ae76f19fb/test/cctest/heap/test-heap.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/40b448eaddc86d1dcedc2e0982a5fc31ea701c7c

commit 40b448eaddc86d1dcedc2e0982a5fc31ea701c7c
Author: Hannes Payer <hpayer@chromium.org>
Date: Fri Nov 23 08:04:49 2018

[heap] Release dead young generation large objects in the Scavenger.

Bug: chromium:852420
Change-Id: Ieefbee7bfd625d62e9104950bdfa8e46d5f4270a
Reviewed-on: https://chromium-review.googlesource.com/c/1348081
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57761}
[modify] https://crrev.com/40b448eaddc86d1dcedc2e0982a5fc31ea701c7c/src/heap/scavenger.cc
[modify] https://crrev.com/40b448eaddc86d1dcedc2e0982a5fc31ea701c7c/src/heap/spaces.cc
[modify] https://crrev.com/40b448eaddc86d1dcedc2e0982a5fc31ea701c7c/src/heap/spaces.h
[modify] https://crrev.com/40b448eaddc86d1dcedc2e0982a5fc31ea701c7c/test/cctest/heap/test-heap.cc

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/33713b5b611089101f3b2c0cadefed3c71be3d83

commit 33713b5b611089101f3b2c0cadefed3c71be3d83
Author: Yang Guo <yangguo@chromium.org>
Date: Fri Nov 23 09:15:33 2018

Revert "[heap] Release dead young generation large objects in the Scavenger."

This reverts commit 40b448eaddc86d1dcedc2e0982a5fc31ea701c7c.

Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/27711

Original change's description:
> [heap] Release dead young generation large objects in the Scavenger.
> 
> Bug: chromium:852420
> Change-Id: Ieefbee7bfd625d62e9104950bdfa8e46d5f4270a
> Reviewed-on: https://chromium-review.googlesource.com/c/1348081
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#57761}

TBR=ulan@chromium.org,hpayer@chromium.org

Change-Id: I6b57dd8ed92d85b5ce012da754611278ceaefe20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:852420
Reviewed-on: https://chromium-review.googlesource.com/c/1349270
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57763}
[modify] https://crrev.com/33713b5b611089101f3b2c0cadefed3c71be3d83/src/heap/scavenger.cc
[modify] https://crrev.com/33713b5b611089101f3b2c0cadefed3c71be3d83/src/heap/spaces.cc
[modify] https://crrev.com/33713b5b611089101f3b2c0cadefed3c71be3d83/src/heap/spaces.h
[modify] https://crrev.com/33713b5b611089101f3b2c0cadefed3c71be3d83/test/cctest/heap/test-heap.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8a659d38590e3739d81edb68f7462bb414b0e9e8

commit 8a659d38590e3739d81edb68f7462bb414b0e9e8
Author: Hannes Payer <hpayer@chromium.org>
Date: Fri Nov 23 15:37:42 2018

Derive kMaximumSlots in ConstructorBuiltins from kMaxRegularHeapObjectSize.

Bug: chromium:852420
Change-Id: I348dbf52bc43078861e40e8377257c8f9a2bc920
Reviewed-on: https://chromium-review.googlesource.com/c/1349242
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57791}
[modify] https://crrev.com/8a659d38590e3739d81edb68f7462bb414b0e9e8/src/builtins/builtins-constructor.h

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2d3a893ae6df90bb9ec777dfd610d35807f91ddb

commit 2d3a893ae6df90bb9ec777dfd610d35807f91ddb
Author: Hannes Payer <hpayer@chromium.org>
Date: Mon Nov 26 08:58:25 2018

[heap] Clear surviving new large objects map after Scavenge.

Bug: chromium:852420
Change-Id: I106b783899cef2f124450f8cc266b3b2ac09b4ae
Reviewed-on: https://chromium-review.googlesource.com/c/1350114
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57812}
[modify] https://crrev.com/2d3a893ae6df90bb9ec777dfd610d35807f91ddb/src/heap/scavenger.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5ee0f0092d03d20fa5f352d82c9eaede433970f5

commit 5ee0f0092d03d20fa5f352d82c9eaede433970f5
Author: Hannes Payer <hpayer@chromium.org>
Date: Mon Nov 26 16:16:45 2018

[heap] Fix space DCHECK in Scavenger::ScavengeObject to allow young generation LOs.

Bug: chromium:852420
Change-Id: I920c4ac8e66a7f29c28fcc62a0b1ea62370bdf5d
Reviewed-on: https://chromium-review.googlesource.com/c/1350993
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57842}
[modify] https://crrev.com/5ee0f0092d03d20fa5f352d82c9eaede433970f5/src/heap/scavenger-inl.h

Project Member

Comment 35 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8930ad2bb9bb83735610739470c4942886479548

commit 8930ad2bb9bb83735610739470c4942886479548
Author: Hannes Payer <hpayer@chromium.org>
Date: Mon Nov 26 18:13:00 2018

[heap] Flip between large object and new large object allocation mode based on --young_generation_large_objects.

Bug: chromium:852420
Change-Id: I5bb03c6ab14b4e42988e917f7ca7d449d53723d8
Reviewed-on: https://chromium-review.googlesource.com/c/1350995
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57849}
[modify] https://crrev.com/8930ad2bb9bb83735610739470c4942886479548/src/heap/heap-inl.h

Project Member

Comment 36 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9266bc24537a7dd20d95a78dc089d5f6f6b095b8

commit 9266bc24537a7dd20d95a78dc089d5f6f6b095b8
Author: Hannes Payer <hpayer@chromium.org>
Date: Mon Nov 26 19:47:20 2018

Reland: [heap] Release dead young generation large objects in the Scavenger.

This reverts commit 33713b5b611089101f3b2c0cadefed3c71be3d83.

Bug: chromium:852420
Change-Id: I45f447b690af8534aeec8630a717abe92f4099f8
Reviewed-on: https://chromium-review.googlesource.com/c/1350997
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57850}
[modify] https://crrev.com/9266bc24537a7dd20d95a78dc089d5f6f6b095b8/src/heap/scavenger.cc
[modify] https://crrev.com/9266bc24537a7dd20d95a78dc089d5f6f6b095b8/src/heap/spaces.cc
[modify] https://crrev.com/9266bc24537a7dd20d95a78dc089d5f6f6b095b8/src/heap/spaces.h
[modify] https://crrev.com/9266bc24537a7dd20d95a78dc089d5f6f6b095b8/test/cctest/heap/test-heap.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bf5cc5624f10121995ce6219443997c31b8f2027

commit bf5cc5624f10121995ce6219443997c31b8f2027
Author: Hannes Payer <hpayer@chromium.org>
Date: Tue Nov 27 18:24:11 2018

[heap] Don't reset objects_size_ counter before freeing new LOs.

Bug: chromium:852420
Change-Id: I12cac5981cbb2af1c1bd150bfb5fcec028e8876d
Reviewed-on: https://chromium-review.googlesource.com/c/1352297
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57882}
[modify] https://crrev.com/bf5cc5624f10121995ce6219443997c31b8f2027/src/heap/spaces.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9c2fc213d32967262634bf354e78cb0297e8ddd2

commit 9c2fc213d32967262634bf354e78cb0297e8ddd2
Author: Hannes Payer <hpayer@chromium.org>
Date: Wed Nov 28 13:57:43 2018

[heap] Various new LO spaces fixes in Scavenger.

Bug: chromium:852420
Change-Id: I54db2251378147df63ca20f3d32d286186f3b784
Reviewed-on: https://chromium-review.googlesource.com/c/1352306
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57903}
[modify] https://crrev.com/9c2fc213d32967262634bf354e78cb0297e8ddd2/src/heap/scavenger-inl.h
[modify] https://crrev.com/9c2fc213d32967262634bf354e78cb0297e8ddd2/src/heap/spaces.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/47d4ac12ff89ce1223aa880671d1fa78a94fa000

commit 47d4ac12ff89ce1223aa880671d1fa78a94fa000
Author: Hannes Payer <hpayer@chromium.org>
Date: Thu Nov 29 13:35:48 2018

[heap] Make page promotion infrastructure aware of large objects.

Bug: chromium:852420
Change-Id: I869ee5d6b705da0dab3c78dfd01eff9aca469d01
Reviewed-on: https://chromium-review.googlesource.com/c/1354886
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57936}
[modify] https://crrev.com/47d4ac12ff89ce1223aa880671d1fa78a94fa000/src/heap/mark-compact-inl.h
[modify] https://crrev.com/47d4ac12ff89ce1223aa880671d1fa78a94fa000/src/heap/mark-compact.cc
[modify] https://crrev.com/47d4ac12ff89ce1223aa880671d1fa78a94fa000/src/heap/scavenger.cc

Project Member

Comment 41 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9ec92be9c83ffd36ba525d156347c81238e499ba

commit 9ec92be9c83ffd36ba525d156347c81238e499ba
Author: Hannes Payer <hpayer@chromium.org>
Date: Fri Nov 30 14:47:54 2018

[heap] Fix cctest expectations for large object allocations.

Bug: chromium:852420
Change-Id: Ie1f656cafe78c517ff53676d8cb7200d0bf1d7cc
Reviewed-on: https://chromium-review.googlesource.com/c/1356518
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57972}
[modify] https://crrev.com/9ec92be9c83ffd36ba525d156347c81238e499ba/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/9ec92be9c83ffd36ba525d156347c81238e499ba/test/cctest/heap/test-invalidated-slots.cc
[modify] https://crrev.com/9ec92be9c83ffd36ba525d156347c81238e499ba/test/cctest/test-api.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8ca0137a2c714dcacc6c0992196ae553d475046c

commit 8ca0137a2c714dcacc6c0992196ae553d475046c
Author: Hannes Payer <hpayer@chromium.org>
Date: Fri Nov 30 16:39:30 2018

[heap] Ensure consistent large MemoryChunk checks.

Bug: chromium:852420
Change-Id: I47ea0994b7f1933095995c051fce76c288a25d6a
Reviewed-on: https://chromium-review.googlesource.com/c/1356515
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57975}
[modify] https://crrev.com/8ca0137a2c714dcacc6c0992196ae553d475046c/src/heap/heap.cc
[modify] https://crrev.com/8ca0137a2c714dcacc6c0992196ae553d475046c/src/heap/heap.h
[modify] https://crrev.com/8ca0137a2c714dcacc6c0992196ae553d475046c/src/heap/spaces.cc
[modify] https://crrev.com/8ca0137a2c714dcacc6c0992196ae553d475046c/src/heap/spaces.h

Sign in to add a comment