New issue
Advanced search Search tips

Issue 852419 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

snapshot_unittests doesn't run on android

Project Member Reported by thakis@chromium.org, Jun 13 2018

Issue description

Android uses the code in ui/snapshot, but it doesn't run its tests. I tried to just add the tests in https://chromium-review.googlesource.com/c/chromium/src/+/1098632/ , but alas, the test fails to start:

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/16121
https://chromium-swarm.appspot.com/task?id=3e1273584481e110&refresh=10&show_raw=1


Traceback (most recent call last):
  File "/b/swarming/w/ir/build/android/test_runner.py", line 1042, in main
    return RunTestsCommand(args)
  File "/b/swarming/w/ir/build/android/test_runner.py", line 745, in RunTestsCommand
    return RunTestsInPlatformMode(args)
  File "/b/swarming/w/ir/build/android/test_runner.py", line 877, in RunTestsInPlatformMode
    raw_results = test_run.RunTests()
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_test_run.py", line 58, in RunTests
    tests = self._GetTests()
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_gtest_run.py", line 432, in _GetTests
    'Failed to list tests on any device')
CommandFailedError: Failed to list tests on any device


Probably easy to fix for anyone with Android experience.

+agrieve because he knows android infra stuff, +tedchoc because he hooked up ui/snapshot on Android.
 
Components: UI>Browser>Mobile Test>Android
Are there any tests to run on Android?  It looks like the two included files are snapshot_aura_unittest.cc and snapshot_mac_unittest.mm.

Comment 2 by thakis@chromium.org, Jun 13 2018

Heh, that explains the error :-) Maybe snapshot_android.cc should have a test? It looks like it mostly forwards though, so maybe this can just be WontFix'd, not sure.

Comment 3 by peconn@chromium.org, Jun 26 2018

Status: WontFix (was: Untriaged)
I'm gonna close this for triage - feel free to reopen (ideally assigning to someone) if you think snapshot_android.cc needs a test!

Sign in to add a comment