Issue metadata
Sign in to add a comment
|
4.2%-24.9% regression in system_health.memory_mobile at 565917:565986 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 13 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11ed04f9240000
,
Jun 13 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/11ed04f9240000 [oilpan] Fix for EsimateLiveSize by mlippautz@chromium.org https://chromium.googlesource.com/chromium/src/+/aceb7d670d0cca38d219cadfc529390c755c299c 9.638e+07 → 1.19e+08 (+2.261e+07) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jun 14 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74356a2c40df79b2aa0ab89b7d27a8e4bb3bf6ee commit 74356a2c40df79b2aa0ab89b7d27a8e4bb3bf6ee Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Jun 14 04:22:43 2018 Revert "[oilpan] Fix for EsimateLiveSize" This reverts commit aceb7d670d0cca38d219cadfc529390c755c299c. Reason for revert: Even though the heuristic seems off we tuned parameters around it that will trigger GCs. Bug: 852413 Original change's description: > [oilpan] Fix for EsimateLiveSize > > Take current value for base size, similarly to what is used for > PartitionAlloc. This makes sure that an esimate is computed at the time > of calling the method. > > Bug: chromium:840789 > Change-Id: Iab7e63f5395cbc74226cd786d420c6145fdb7dd9 > Reviewed-on: https://chromium-review.googlesource.com/1094822 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565967} TBR=haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:840789 Change-Id: I323527b2f6d4703773ca11f980a4233cb8554f7a Reviewed-on: https://chromium-review.googlesource.com/1100435 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567131} [modify] https://crrev.com/74356a2c40df79b2aa0ab89b7d27a8e4bb3bf6ee/third_party/blink/renderer/platform/heap/thread_state.cc [modify] https://crrev.com/74356a2c40df79b2aa0ab89b7d27a8e4bb3bf6ee/third_party/blink/renderer/platform/heap/thread_state.h
,
Jun 15 2018
,
Jun 15 2018
Issue 852753 has been merged into this issue.
,
Jun 15 2018
,
Jun 15 2018
The graphs that already have the fix have recovered. Closing this one for now. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jun 13 2018