New issue
Advanced search Search tips

Issue 852412 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 800767



Sign in to add a comment

Remove private PPAPI VideoDestination and VideoSource

Project Member Reported by orphis@chromium.org, Jun 13 2018

Issue description

Those APIs are whitelisted to be used only by the Hangouts plugin which is not in use anymore.
With the deprecation of URL.createObjectURL(MediaStream), those APIs have become obsolete and should be removed.


 

Comment 1 by orphis@chromium.org, Jun 27 2018

Blocking: 800767
Status: Verified (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de49ea19de9c808a6545fd49af26814a75ceb7d0

commit de49ea19de9c808a6545fd49af26814a75ceb7d0
Author: Florent Castelli <orphis@chromium.org>
Date: Wed Sep 05 10:32:50 2018

Remove VideoDestination_Private and VideoSource_Private PPAPI

Those can only be used by the old Hangouts effect plugin and it isn't
used anymore.
Since those APIs depend on URL.createObjectURL(MediaStream) which is
deprecated, it is necessary to first remove them from the codebase
in order to continue removing URL.createObjectURL(MediaStream).

Bug:  852412 
Change-Id: If64e8e7259a6d51ccf89362b59c9d6fc7c890a30
Reviewed-on: https://chromium-review.googlesource.com/1099159
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588819}
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/BUILD.gn
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/chrome/common/ppapi_utils.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/chrome/renderer/chrome_content_renderer_client_unittest.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/chrome/test/ppapi/ppapi_browsertest.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/content/renderer/BUILD.gn
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/content/renderer/media/pepper/pepper_to_video_track_adapter.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/content/renderer/media/pepper/pepper_to_video_track_adapter.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/content/renderer/media/pepper/pepper_to_video_track_adapter_unittest.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/content/renderer/media/pepper/video_track_to_pepper_adapter.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/content/renderer/media/pepper/video_track_to_pepper_adapter.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/content/renderer/media/pepper/video_track_to_pepper_adapter_unittest.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/content/renderer/pepper/content_renderer_pepper_host_factory.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/content/renderer/pepper/pepper_video_destination_host.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/content/renderer/pepper/pepper_video_destination_host.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/content/renderer/pepper/pepper_video_source_host.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/content/renderer/pepper/pepper_video_source_host.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/content/renderer/pepper/plugin_module.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/content/renderer/pepper/resource_creation_impl.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/content/renderer/pepper/resource_creation_impl.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/content/test/BUILD.gn
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/BUILD.gn
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/api/private/ppb_video_destination_private.idl
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/api/private/ppb_video_source_private.idl
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/c/BUILD.gn
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/c/private/ppb_video_destination_private.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/c/private/ppb_video_source_private.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/cpp/BUILD.gn
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/cpp/private/video_destination_private.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/cpp/private/video_destination_private.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/cpp/private/video_source_private.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/cpp/private/video_source_private.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/examples/BUILD.gn
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/examples/video_effects/BUILD.gn
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/examples/video_effects/video_effects.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/examples/video_effects/video_effects.html
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/proxy/BUILD.gn
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/proxy/interface_list.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/proxy/ppapi_messages.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/proxy/resource_creation_proxy.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/proxy/resource_creation_proxy.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/proxy/video_destination_resource.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/proxy/video_destination_resource.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/proxy/video_source_resource.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/proxy/video_source_resource.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/shared_impl/resource.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/tests/all_c_includes.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/tests/all_cpp_includes.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/tests/test_video_destination.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/tests/test_video_destination.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/tests/test_video_source.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/tests/test_video_source.h
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/thunk/BUILD.gn
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/thunk/interfaces_ppb_private_no_permissions.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/thunk/ppb_video_destination_private_api.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/thunk/ppb_video_destination_private_thunk.cc
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/thunk/ppb_video_source_private_api.h
[delete] https://crrev.com/b1a7e23aa7ceace07f9eebe649001734e2fc7a0c/ppapi/thunk/ppb_video_source_private_thunk.cc
[modify] https://crrev.com/de49ea19de9c808a6545fd49af26814a75ceb7d0/ppapi/thunk/resource_creation_api.h

Sign in to add a comment