New issue
Advanced search Search tips

Issue 852395 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[LayoutNG] Vertical scrollbar not handled properly in vertical-rl mode

Project Member Reported by mstensho@chromium.org, Jun 13 2018

Issue description

Looks like an inline-children block NG fragment painting issue, since it's not reproducible if I remove the BR. See attachment.
 
tc.html
421 bytes View Download
Owner: atotic@chromium.org
Status: Assigned (was: Available)
Aleks, is this something you'd be interested in?

Comment 2 by atotic@chromium.org, Jun 13 2018

Looking at this already. We are not painting borders/scrollbars on inline-blocks.
Note that this is not an inline-block. This is a block with inline children.

Comment 4 by atotic@chromium.org, Jun 13 2018

Thanks for the alert. The example I am working on also works if you remove <br>, just assumed it was the same issue.

Comment 5 by atotic@chromium.org, Jun 13 2018

Looks like vertical-rl offset paint_offset issue. I've fixed bunch of these before...
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9a923c317538450b2f542adba5f866a96288917

commit c9a923c317538450b2f542adba5f866a96288917
Author: Aleks Totic <atotic@chromium.org>
Date: Thu Jun 28 11:28:50 2018

[LayoutNG] bugfix for NG painting in vertical-rl with scrollbars.

This bug occurs when painting NG child inside non-inline vertical-rl parent
with scrollbars.

Root cause is extra scrollbar offset that Paint applies to Legacy painting that
is not needed for NG.

The fix is hacky: NG applies reverse offset.

This fix does not make any additional tests pass or fail.

Bug:  852395 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7dda2cdbf682485ab30c048987ae683981731886
Reviewed-on: https://chromium-review.googlesource.com/1115863
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571080}
[add] https://crrev.com/c9a923c317538450b2f542adba5f866a96288917/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/reference/scrollbar-vertical-rl-ref.html
[add] https://crrev.com/c9a923c317538450b2f542adba5f866a96288917/third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/scrollbar-vertical-rl.html
[modify] https://crrev.com/c9a923c317538450b2f542adba5f866a96288917/third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc

Status: Fixed (was: Assigned)

Sign in to add a comment