kkhorimoto@ can you see if there's anything obvious broken with our fullscreen implementation on iOS12?

It looks like Safari has the same new functionality.  When opening single_page_wide.pdf and swiping up on 11.4, the toolbar goes away.  The same steps on 12 the toolbar stays, on Safari.

I can't tell one way or another if this is WAI and we should just update the tests, or if this is a bug and we should file a radar.

I created crrev.com/c/1100337 in case it's the former.

kkhorimoto@ WDYT?

per offline discussion with kkhorimoto@ we think this is WAI, and in fact the old functionality was arguably wrong.

Hmm, something else weird is going on.  I could reproduce and fix this test when running just the single testSmallWidePDFScroll by itself.

But if I run the entire suite FullscreenTestCase, testSmallWidePDFScroll fails at the first swipe down event, failing at wait for toolbar.

To make things more interesting, if we run testLongPDFScroll by itself, it also fails.

kkhorimoto@, do you have some cycles to dig further into this?  I'm tempted to just disable these tests on iOS12 entirely for the time being, but I'd like to understand what's going.

I probably won't be able to look at this until next week cuz I'm a little behind on reading list stuff.  Handing back over to Justin for the time being; if you can't get to this by the end of the current sprint, feel free to assign back to me.  Judging by Issue 852503, it looks like there might actually be some issues with iOS12 pdf rendering.

Example failure here for FYI: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8943625534943196288%2F%2B%2Fsteps%2Fios_chrome_ui_egtests__iPhone_6s_iOS_12.0__shard_0%2F0%2Fstdout

tirodkar@ FYI for an iOS12 potential issue with PDF's in WKWebView.  Although it's equally likely we have a bug in our fullscreen implementation and an animation is hanging.

tirodkar@ noted that it's weird to see 4 windows, one of which is a text effect window, and shared the following link.

https://omlog.wordpress.com/2009/09/17/whats-a-uitexteffectswindow-and-why-is-it-receiving-messages/

kkhorimoto@ perhaps we are doing something weird here?

I'll land a workaround, and keep checking with each new Xcode 10 beta.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be3a9821c12be7c77d73aefc7d190b195e68e6b2

commit be3a9821c12be7c77d73aefc7d190b195e68e6b2
Author: Justin Cohen <justincohen@google.com>
Date: Sat Jun 16 00:56:23 2018

[ios] Update wide pdf test for iOS12.

Swiping up on a short/wide pdf no longer hides the toolbar.

Also disable synchronization for testSmallWidePDFScroll on iOS12,
but it's likely something larger is going on.

Bug: 852393
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iab556064447cfe54cb498678d192a45f36b55a1a
Reviewed-on: https://chromium-review.googlesource.com/1100337
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567846}
[modify] https://crrev.com/be3a9821c12be7c77d73aefc7d190b195e68e6b2/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm

The NextAction date has arrived: 2018-06-20

Same issue with beta 2. kkhorimoto@ can you PTAL to see if it's not an animation running forever on our side?

The NextAction date has arrived: 2018-07-09

Same issue with beta 3. 

kkhorimoto@ Still happening in beta 6.  Can you take a look?