New issue
Advanced search Search tips

Issue 852388 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Material Refresh - Inactive tabs and NTB don't update the text colors when the accent color changes

Project Member Reported by kylixrd@chromium.org, Jun 13 2018

Issue description

Under Material Refresh mode, when the frame accent color changes in Win10, the text/glyph color isn't recalculated. This includes going between the active/inactive window state and when the base accent color is changed.
 
Status: Assigned (was: Available)
 Issue 852331  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c04d6f470c86695c535ba722d33f834adba0c7a8

commit c04d6f470c86695c535ba722d33f834adba0c7a8
Author: Allen Bauer <kylixrd@chromium.org>
Date: Fri Jun 15 12:53:55 2018

Update tab strip foreground colors on activation and color changes.

The previous CL (https://crrev.com/c/1089723) only focused on getting the tab
colors from the browser frame. This CL focuses on ensuring the tab strip is
notified of activation and color changes so those colors can be recalculated.

Bug:  852388 
Change-Id: Ib66c43038e1e8ea823fe991e55239754e5fce097
Reviewed-on: https://chromium-review.googlesource.com/1099048
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567617}
[modify] https://crrev.com/c04d6f470c86695c535ba722d33f834adba0c7a8/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/c04d6f470c86695c535ba722d33f834adba0c7a8/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/c04d6f470c86695c535ba722d33f834adba0c7a8/chrome/browser/ui/views/tabs/new_tab_button.h
[modify] https://crrev.com/c04d6f470c86695c535ba722d33f834adba0c7a8/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/c04d6f470c86695c535ba722d33f834adba0c7a8/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/c04d6f470c86695c535ba722d33f834adba0c7a8/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/c04d6f470c86695c535ba722d33f834adba0c7a8/chrome/browser/ui/views/tabs/tab_strip.h

Status: Fixed (was: Started)

Sign in to add a comment