Sync: GetUploadToGoogleState doesn't handle ModelType-specific errors well |
||
Issue descriptionGetUploadToGoogleState supposedly tells the caller whether a given Sync ModelType is actively being synced to Google. It checks a whole bunch of things to ensure this, but one case it currently doesn't handle is if an individual ModelType fails to start up for some reason. I think "disabled via policy" could be one reason for a ModelType to not start. I think the solution is probably to make sure the type in question is in GetActiveDataTypes().
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d18891fc7b891bcf13deac94d24e2b1f6a8b038 commit 1d18891fc7b891bcf13deac94d24e2b1f6a8b038 Author: Marc Treib <treib@chromium.org> Date: Tue Jun 19 09:35:18 2018 syncer::GetUploadToGoogleState: Handle individual ModelType failures GetUploadToGoogleState supposedly tells you whether a given ModelType is actively being uploaded to Google. However, before this CL, it only checked that the ModelType is "preferred" (i.e. not disabled by the user) and that the SyncService itself is in an active state. That missed some cases, e.g. when a ModelType is disabled via browser policy. This CL fixes this by also checking that the ModelType in question is in an active state. Bug: 852385 Change-Id: Ifb3f4e912844ece21c691199091b3cf65ad02ad1 Reviewed-on: https://chromium-review.googlesource.com/1099239 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568379} [modify] https://crrev.com/1d18891fc7b891bcf13deac94d24e2b1f6a8b038/components/autofill/core/browser/autofill_experiments_unittest.cc [modify] https://crrev.com/1d18891fc7b891bcf13deac94d24e2b1f6a8b038/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/1d18891fc7b891bcf13deac94d24e2b1f6a8b038/components/autofill/core/browser/test_sync_service.cc [modify] https://crrev.com/1d18891fc7b891bcf13deac94d24e2b1f6a8b038/components/autofill/core/browser/test_sync_service.h [modify] https://crrev.com/1d18891fc7b891bcf13deac94d24e2b1f6a8b038/components/sync/driver/sync_service_utils.cc [modify] https://crrev.com/1d18891fc7b891bcf13deac94d24e2b1f6a8b038/components/sync/driver/sync_service_utils_unittest.cc
,
Jun 19 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by treib@chromium.org
, Jun 13 2018