New issue
Advanced search Search tips

Issue 852379 link

Starred by 1 user
Status: Fixed
Owner:
ftirelo@chromium.org
Closed: Jun 2018
Cc:
ftirelo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill] Double border on credit card icon in Save Card dialog

Project Member Reported by ma...@chromium.org, Jun 13 2018 
See attached screenshot.

See code: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/autofill/save_card_bubble_views.cc?rcl=21718cc2274ec87c679d9a14643d440148966cdd&l=271

Our png assets already have a border, see components/resources/default_300_percent/autofill/
Screen Shot 2018-06-13 at 9.38.01 AM.png
72.8 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/385dab7603779ae3d149b2ffb91dcc1bd5b8991a

commit 385dab7603779ae3d149b2ffb91dcc1bd5b8991a
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Wed Jun 13 22:42:44 2018

[Save card dialog] Remove double border on CC icon

Credit card assets already have a border, so adding a solid border
around the icon on the UI is not needed.

Bug:  852379 
Change-Id: Ifb11db8a27e4914b9c7f373ae4bc35d2780358b2
Reviewed-on: https://chromium-review.googlesource.com/1099760
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567026}
[modify] https://crrev.com/385dab7603779ae3d149b2ffb91dcc1bd5b8991a/chrome/browser/ui/views/autofill/save_card_bubble_views.cc

Comment 2 by ftirelo@chromium.org, Jun 19 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment