New issue
Advanced search Search tips

Issue 852377 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"tools/perf/run_benchmark list" is broken

Project Member Reported by h...@chromium.org, Jun 13 2018

Issue description

I just ran it like this, expecting to get a list of supported benchmarks as suggested by the help message:

$ tools/perf/run_benchmark list
(INFO) 2018-06-13 15:37:46,315 timeout_retry.WaitFor:105  condition '<lambda>' met
(INFO) 2018-06-13 15:37:46,316 cmd_helper._ValidateAndLogCommand:160  [host]> /work/chromium/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb devices
(INFO) 2018-06-13 15:37:49,438 cmd_helper._ValidateAndLogCommand:160  [host]> /work/chromium/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb devices
(INFO) 2018-06-13 15:37:49,505 cmd_helper._ValidateAndLogCommand:160  [host]> /work/chromium/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb kill-server
(WARNING) 2018-06-13 15:37:49,571 desktop_browser_finder.FindAllAvailableBrowsers:278  Chrome build location for linux_x86_64 not found. Browser will be run without Flash.
(INFO) 2018-06-13 15:37:49,573 exception_formatter.PrintFormattedException:19  Try printing formatted exception: <class 'telemetry.internal.browser.browser_finder_exceptions.BrowserTypeRequiredException'> --browser must be specified. Available browsers:
stable
system <traceback object at 0x7f9021d83c20>

Traceback (most recent call last):
  <module> at /work/chromium/src/tools/perf/run_benchmark:27
    sys.exit(main())
  main at /work/chromium/src/tools/perf/run_benchmark:23
    return benchmark_runner.main(config, [trybot_command.Trybot])
  main at /work/chromium/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py:439
    return command_instance.Run(options)
  Run at /work/chromium/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py:220
    possible_browser = browser_finder.FindBrowser(args)
  Cacher at /work/chromium/src/third_party/catapult/telemetry/telemetry/decorators.py:35
    cacher.__cache[key] = obj(*args, **kwargs)
  FindBrowser at /work/chromium/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_finder.py:93
    '\n'.join(sorted(set([b.browser_type for b in browsers]))))
BrowserTypeRequiredException: --browser must be specified. Available browsers:
stable
system

Locals:
  b                   : PossibleDesktopBrowser(type=stable, executable=/opt/google/chrome/chrome, flash=None)
  browsers            : [PossibleDesktopBrowser(type=system, executable=/opt/google/chrome/chrome, flash=None), PossibleDesktopBrowser(type=stable, executable=/opt/google/chrome/chrome, flash=None)]
  curr_browsers       : []
  default_browsers    : []
  device              : <telemetry.internal.platform.desktop_device.DesktopDevice object at 0x7f9021d8c850>
  devices             : [<telemetry.internal.platform.desktop_device.DesktopDevice object at 0x7f9021d8c850>]
  finder              : <module 'telemetry.internal.backends.chrome.cros_browser_finder' from '/work/chromium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.pyc'>
  new_default_browser : None
  options             : [('android_blacklist_file', None), ('assert_gpu_compositing', None), ('benchmarks', [<class 'benchmarks.blink_perf.BlinkPerfLayout'>, <class 'benchmarks.memory.MemoryBenchmarkTrivialSitesDesktop'>, <class 'benchmarks.smoothness.SmoothnessGpuRasterizationToughScrollingCases'>, <class 'benchmarks.tracing.TracingWithBackgroundMemoryInfra'>, <class 'benchmarks.system_health.MobileMemorySystemHealth'>, <class 'benchmarks.speedometer2.V8Speedometer2Future'>, <class 'benchmarks.memory.MemoryLongRunningIdleGmail ... one), ('interval_profiling_frequency', 1000), ('interval_profiling_periods', []), ('interval_profiling_target', ''), ('json_filename', None), ('logging_verbosity', None), ('no_performance_mode', False), ('output_file', None), ('positional_args', []), ('print_bootstrap_deps', None), ('profile_dir', None), ('remote_platform_options', <telemetry.internal.platform.remote_platform_options.AndroidPlatformOptions object at 0x7f8f94804c10>), ('show_stdout', None), ('verbosity', 0), ('webview_embedder_apk', None)] (truncated)
 

Sign in to add a comment