New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852369 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocked on:
issue 854117



Sign in to add a comment

Clean logs on Chrome startup

Project Member Reported by olivierrobin@chromium.org, Jun 13 2018

Issue description

Starting bling produces 1801 lines of logs
(https://paste.googleplex.com/6598422081568768)

Some of these lines may be important and are completely not monitored.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01d76bd10f83504c3767f69faba059139a93e4af

commit 01d76bd10f83504c3767f69faba059139a93e4af
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Fri Jun 15 09:17:48 2018

Implement PowerMonitorDeviceSource::IsOnBatteryPowerImpl on iOS

The NOTIMPLEMENTED is reached at startup.
Implement the method.

Bug:  852369 
Change-Id: I843f7cd7e168a0b4317e030e3f48349ef3cd025c
Reviewed-on: https://chromium-review.googlesource.com/1098965
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567588}
[modify] https://crrev.com/01d76bd10f83504c3767f69faba059139a93e4af/base/power_monitor/power_monitor_device_source_ios.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/043afc5797ba61c80416d85872e1c1faa5e23ad5

commit 043afc5797ba61c80416d85872e1c1faa5e23ad5
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Mon Jun 18 09:54:24 2018

Do not start DnsConfigServiceThread on iOS

DnsConfigService on iOS doesn't watch the config so its result can become
inaccurate at any time.  Disable it to prevent promulgation of inaccurate
DnsConfigs.

https://cs.chromium.org/chromium/src/net/dns/dns_config_service_posix.cc?q=dns_config_service_po&sq=package:chromium&g=0&l=64
shows that this is not implemented on iOS.
Calling the method produces parasite log at startup.

Bug:  852369 
Change-Id: I3d24bcb1089fb3c9099b1fffcb829c2a5a2449dc
Reviewed-on: https://chromium-review.googlesource.com/1102317
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567963}
[modify] https://crrev.com/043afc5797ba61c80416d85872e1c1faa5e23ad5/net/base/network_change_notifier_mac.cc

Cc: gambard@chromium.org
Blockedon: 854117
Status: Fixed (was: Started)

Sign in to add a comment