New issue
Advanced search Search tips

Issue 852358 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 830963
Owner:
Closed: Sep 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

underspeciifed gn dependencies around add_event_listener_options_resolved.h

Project Member Reported by thakis@chromium.org, Jun 13 2018

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win/68623


FAILED: obj/third_party/blink/public/core_mojo_bindings_blink/broadcast_channel.mojom-blink.obj 
C:\b\swarming\w\ir\cache\goma\client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  "-imsvc..\..\..\..\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\win_sdk\Include\10.0.17134.0\um" "-imsvc..\..\..\..\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\win_sdk\Include\10.0.17134.0\shared" "-imsvc..\..\..\..\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\win_sdk\Include\10.0.17134.0\winrt" "-imsvc..\..\..\..\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\win_sdk\Include\10.0.17134.0\ucrt" "-imsvc..\..\..\..\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include" "-imsvc..\..\..\..\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\atlmfc\include" -DCONTENT_IMPLEMENTATION=1 -DBLINK_CORE_IMPLEMENTATION=1 -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D"CR_CLANG_REVISION=\"334100-1\"" -D_HAS_NODISCARD -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBP_EXTERN=extern -DUSE_EGL -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -DENABLE_IPC_FUZZER -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -D__STD_C -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -D"SK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"" -DGR_GL_FUNCTION_TYPE=__stdcall -DUSE_LIBJPEG_TURBO=1 -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DGTEST_RELATIVE_PATH -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_WIN -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -I../.. -Igen -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/libyuv/include -I../../third_party/wtl/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/blink/renderer/platform/wtf/os-win32 -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/boringssl/src/include -I../../third_party/libjpeg_turbo -I../../v8/include -Igen/v8/include -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Igen/v8/include /utf-8 /X -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- -fmsc-version=1911 -m32 /Brepro /W4 -Wimplicit-fallthrough -Wthread-safety /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /wd4200 /wd4201 /wd4204 /wd4221 /wd4267 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-address-of-packed-member -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /MT -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-inconsistent-missing-override /wd4305 /wd4324 /wd4714 /wd4800 /wd4996 -Xclang -add-plugin -Xclang blink-gc-plugin /wd4344 /wd4706 -imsvc ../../third_party/abseil-cpp /TP /wd4577 /GR- /c gen/third_party/blink/public/platform/modules/broadcastchannel/broadcast_channel.mojom-blink.cc /Foobj/third_party/blink/public/core_mojo_bindings_blink/broadcast_channel.mojom-blink.obj /Fd"obj/third_party/blink/public/core_mojo_bindings_blink_cc.pdb"
In file included from gen/third_party/blink/public/platform/modules/broadcastchannel/broadcast_channel.mojom-blink.cc:15:
In file included from gen\third_party/blink/public/platform/modules/broadcastchannel/broadcast_channel.mojom-blink.h:29:
In file included from gen\third_party/blink/public/mojom/message_port/message_port.mojom-blink.h:53:
In file included from ../..\third_party/blink/renderer/core/messaging/blink_cloneable_message.h:9:
In file included from ../..\third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h:42:
In file included from ../..\third_party/blink/renderer/core/imagebitmap/image_bitmap.h:12:
In file included from ../..\third_party/blink/renderer/core/html/canvas/image_element_base.h:10:
In file included from ../..\third_party/blink/renderer/core/imagebitmap/image_bitmap_source.h:10:
In file included from ../..\third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h:9:
In file included from ../..\third_party/blink/renderer/bindings/core/v8/to_v8_for_core.h:14:
In file included from ../..\third_party/blink/renderer/core/dom/node.h:32:
In file included from ../..\third_party/blink/renderer/core/dom/events/event_target.h:39:
../..\third_party/blink/renderer/core/dom/events/add_event_listener_options_resolved.h(8,10):  fatal error: 'third_party/blink/renderer/core/dom/events/add_event_listener_options.h' file not found
#include "third_party/blink/renderer/core/dom/events/add_event_listener_options.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.



The header is generated by //third_party/blink/renderer/bindings/core/v8:bindings_core_impl_generated


blink_core_sources("dom") includes the generated file in a header that other targets depend on, but it only lists that target in deps, not in public_deps.


The dep is new from https://chromium-review.googlesource.com/c/1093956/ (but the failing build had that change already). I think you just need to put that target in public_deps instead.
 
Owner: peria@chromium.org
Status: Assigned (was: Untriaged)
Everything in core should get this via core:prerequisites and core:all_generators. It appears that presently prerequisites isn't a public dep and while all_generators is, it doesn't include the IDL generator.

Triaging over to peria?

Comment 2 by peria@chromium.org, Jun 14 2018

Yes, I'll work for this.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35b562741d03ec39f2df10e935d4685998e406fb

commit 35b562741d03ec39f2df10e935d4685998e406fb
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Fri Jun 22 09:03:57 2018

gn: Move a dependency to generate bindings code

Some code (in)directly include generated header files,
and this CL adds a dependency edge to clarify it.
It needs to be in public_deps in case a dependent
target on dom/ is the main target.


Bug:  852358 
Change-Id: Ie652ba66095a5f3466fad661ec7be0a03b32e05d
Reviewed-on: https://chromium-review.googlesource.com/1111491
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569562}
[modify] https://crrev.com/35b562741d03ec39f2df10e935d4685998e406fb/third_party/blink/renderer/core/dom/BUILD.gn

Comment 4 by peria@chromium.org, Jun 24 2018

Status: Fixed (was: Assigned)
This issue should be fixed.  I'll revisit if this issue happens again.

Comment 5 by grt@chromium.org, Jun 27 2018

Status: Assigned (was: Fixed)
It's still happening; see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win/69379. I imagine there's a missing dependency a bit higher up the chain. Thanks for taking another look.
Mergedinto: 830963
Status: Duplicate (was: Assigned)

Sign in to add a comment