New issue
Advanced search Search tips

Issue 852353 link

Starred by 1 user
Status: Fixed
Owner:
edchin@chromium.org
Closed: Jul 13
Cc:
mard...@chromium.org
marq@chromium.org
pschaffner@chromium.org
martijnb@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Should not hide non-incognito tab switcher sections in app switcher

Project Member Reported by pschaffner@chromium.org, Jun 13 2018 
When Chrome is backgrounded, we hide both the incognito tab switcher and focused incognito tabs. In canary, however, we hide the tab switcher for all sections (including normal and recent tabs). This is incorrect and we should match the behavior in stable today.

Comment 1 by marq@chromium.org, Jun 13 2018

Labels: MS-Tab-Grid S-Polish Q2
Status: Assigned (was: Untriaged)

Comment 2 by edchin@chromium.org, Jun 13 2018

Labels: medium
NextAction: 2018-06-20

Comment 3 by edchin@chromium.org, Jun 13 2018

Labels: -medium
NextAction: ----

Comment 4 by marq@chromium.org, Jun 26 2018

Labels: Type-Bug

Comment 5 by marq@chromium.org, Jun 27 2018

Owner: edchin@chromium.org
Load shedding bugs to Ed.

Comment 6 by edchin@chromium.org, Jun 28 2018

Status: Started (was: Assigned)

Comment 7 by marq@chromium.org, Jul 10

Labels: M-69
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc2be1ca8c800b39f5872b28dbad90beba4c7851

commit fc2be1ca8c800b39f5872b28dbad90beba4c7851
Author: edchin <edchin@chromium.org>
Date: Fri Jul 13 01:35:22 2018

[ios] Fix incognito obscuring logic when backgrounded

Previously, the tab grid regular tabs panel was being obscured when
the app is backgrounded. This is not correct behavior.
This CL fixes the logic so that the app is only obscured when an
incognito tab is shown (either in tab view or tab grid).

Bug:  852353 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ieb1355601515acd3869a03406b5d9d20ffb61ee3
Reviewed-on: https://chromium-review.googlesource.com/1131917
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574805}
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/app/application_delegate/app_state.h
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/app/application_delegate/app_state.mm
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/app/application_delegate/app_state_unittest.mm
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/app/main_application_delegate.mm
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/app/main_controller.h
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/browser/ui/stack_view/stack_view_controller_unittest.mm
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator_unittest.mm
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/browser/ui/tab_grid/tab_grid_paging.h
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.h
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/fc2be1ca8c800b39f5872b28dbad90beba4c7851/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm

Comment 9 by edchin@chromium.org, Jul 13

Status: Fixed (was: Started)
►

Sign in to add a comment