New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 852344 link

Starred by 1 user
Status: Fixed
Owner:
█ alexclarke@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
gab@chromium.org
█ kraynov@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Review EnqueueOrder generation function

Project Member Reported by kraynov@chromium.org, Jun 13 2018
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ead9da4ac54464b137e7a5e7427e1a5e647f2ecf

commit ead9da4ac54464b137e7a5e7427e1a5e647f2ecf
Author: Alex Clarke <alexclarke@chromium.org>
Date: Fri Jun 15 09:14:59 2018

Use memory_order_relaxed in EnqueueOrderGenerator::GenerateNext

As gab@ pointed out we don't really need the memory barrier here.

Bug:  852344 
Change-Id: Iadff34dd8d571cdcc4323ce6dd0f1e757f4a0fd1
Reviewed-on: https://chromium-review.googlesource.com/1099163
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567586}
[modify] https://crrev.com/ead9da4ac54464b137e7a5e7427e1a5e647f2ecf/base/task/sequence_manager/enqueue_order.h

Comment 2 by kraynov@chromium.org, Jun 15 2018 

I guess it can be closed now :)

Comment 3 by alexclarke@chromium.org, Jun 15 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment